diff mbox

[V5,11/11,SCSI] aacraid: Requests at least 2 MSIx in pci_enable_msix_range()

Message ID 1437583757-5449-12-git-send-email-rajinikanth.pandurangan@pmcs.com (mailing list archive)
State New, archived
Headers show

Commit Message

rajinikanth.pandurangan@pmcs.com July 22, 2015, 4:49 p.m. UTC 
From: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.com>

Description:
        In MSIx mode, we need at least 2 vectors.

Changes from V4:
	Newly created for V5 based on review comment.

Signed-off-by: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.com>
---
 drivers/scsi/aacraid/comminit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tomas Henzl July 23, 2015, 12:55 p.m. UTC | #1 
On 22.7.2015 18:49, rajinikanth.pandurangan@pmcs.com wrote:
> From: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.com>
> 
> Description:
>         In MSIx mode, we need at least 2 vectors.
> 
> Changes from V4:
> 	Newly created for V5 based on review comment.
> 
> Signed-off-by: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.

Reviewed-by: Tomas Henzl <thenzl@redhat.com>

Tomas

> ---
>  drivers/scsi/aacraid/comminit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/aacraid/comminit.c b/drivers/scsi/aacraid/comminit.c
> index a02cfb3..0e954e3 100644
> --- a/drivers/scsi/aacraid/comminit.c
> +++ b/drivers/scsi/aacraid/comminit.c
> @@ -366,7 +366,7 @@ void aac_define_int_mode(struct aac_dev *dev)
>  
>  	if (msi_count > 1 &&
>  	    pci_find_capability(dev->pdev, PCI_CAP_ID_MSIX)) {
> -		min_msix = 1;
> +		min_msix = 2;
>  		i = pci_enable_msix_range(dev->pdev,
>  				    dev->msixentry,
>  				    min_msix,
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
James Bottomley Aug. 12, 2015, 6:29 p.m. UTC | #2 
> On 22.7.2015 18:49, rajinikanth.pandurangan@pmcs.com wrote:
> > From: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.com>
> > 
> > Description:
> >         In MSIx mode, we need at least 2 vectors.
> > 
> > Changes from V4:
> >       Newly created for V5 based on review comment.
> > 
> > Signed-off-by: Rajinikanth Pandurangan
> <rajinikanth.pandurangan@pmcs.
> 
> Reviewed-by: Tomas Henzl <thenzl@redhat.com>

I'm confused by your [PATCH v6] posting: where did this patch go ... do
you want it dropped or did you just forget to include it?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Harry Yang Aug. 12, 2015, 6:56 p.m. UTC | #3 
SGkgSmFtZXMsDQoNCkp1c3QgRllJDQoNClJhaiBpcyBubyBsb25nZXIgd2l0aCBQTUMtU2llcnJh
LiBXaGF0ZXZlciBwYXRjaGVzIGhlIHdhcyBoYW5kbGluZyBpcyBub3cgdGFrZW4gb3ZlciBieSBN
YWhlc2ggd2hvIGhhcyBhbHNvIGJlZW4gb24gYXNzb2NpYXRlZCBlbWFpbCB0aHJlYWRzLg0KDQoN
CkhpIE1haGVzaCwNCg0KUGxlYXNlIGZvbGxvdyB1cC4NCg0KUmVnYXJkcywNCg0KSGFycnkNCg0K
LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IEphbWVzIEJvdHRvbWxleSBbbWFpbHRv
OkphbWVzLkJvdHRvbWxleUBIYW5zZW5QYXJ0bmVyc2hpcC5jb21dIA0KU2VudDogV2VkbmVzZGF5
LCBBdWd1c3QgMTIsIDIwMTUgMTE6MjkgQU0NClRvOiBUb21hcyBIZW56bA0KQ2M6IFJhamluaWth
bnRoIFBhbmR1cmFuZ2FuOyBqYm90dG9tbGV5QHBhcmFsbGVscy5jb207IGxpbnV4LXNjc2lAdmdl
ci5rZXJuZWwub3JnOyBhYWNyYWlkQHBtYy1zaWVycmEuY29tOyBIYXJyeSBZYW5nOyBSaWNoIEJv
bm87IE1haGVzaCBSYWphc2hla2hhcmE7IEFjaGltIExldWJuZXI7IE11cnRoeSBCaGF0DQpTdWJq
ZWN0OiBSZTogW1BBVENIIFY1IDExLzExXSBbU0NTSV0gYWFjcmFpZDogUmVxdWVzdHMgYXQgbGVh
c3QgMiBNU0l4IGluIHBjaV9lbmFibGVfbXNpeF9yYW5nZSgpDQoNCg0KPiBPbiAyMi43LjIwMTUg
MTg6NDksIHJhamluaWthbnRoLnBhbmR1cmFuZ2FuQHBtY3MuY29tIHdyb3RlOg0KPiA+IEZyb206
IFJhamluaWthbnRoIFBhbmR1cmFuZ2FuIDxyYWppbmlrYW50aC5wYW5kdXJhbmdhbkBwbWNzLmNv
bT4NCj4gPiANCj4gPiBEZXNjcmlwdGlvbjoNCj4gPiAgICAgICAgIEluIE1TSXggbW9kZSwgd2Ug
bmVlZCBhdCBsZWFzdCAyIHZlY3RvcnMuDQo+ID4gDQo+ID4gQ2hhbmdlcyBmcm9tIFY0Og0KPiA+
ICAgICAgIE5ld2x5IGNyZWF0ZWQgZm9yIFY1IGJhc2VkIG9uIHJldmlldyBjb21tZW50Lg0KPiA+
IA0KPiA+IFNpZ25lZC1vZmYtYnk6IFJhamluaWthbnRoIFBhbmR1cmFuZ2FuDQo+IDxyYWppbmlr
YW50aC5wYW5kdXJhbmdhbkBwbWNzLg0KPiANCj4gUmV2aWV3ZWQtYnk6IFRvbWFzIEhlbnpsIDx0
aGVuemxAcmVkaGF0LmNvbT4NCg0KSSdtIGNvbmZ1c2VkIGJ5IHlvdXIgW1BBVENIIHY2XSBwb3N0
aW5nOiB3aGVyZSBkaWQgdGhpcyBwYXRjaCBnbyAuLi4gZG8geW91IHdhbnQgaXQgZHJvcHBlZCBv
ciBkaWQgeW91IGp1c3QgZm9yZ2V0IHRvIGluY2x1ZGUgaXQ/DQoNCkphbWVzDQoNCg0K
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mahesh Rajashekhara Aug. 13, 2015, 12:22 a.m. UTC | #4 
QXMgVG9tYXMgSGVuemwgc3VnZ2VzdGVkLCBJIGhhdmUgbWVyZ2VkIDEwIGFuZCAxMSBvZiBWNSBp
bnRvIHNpbmdsZSBwYXRjaCAoaS5lIDkgb2YgVjYpDQoNCkNoYW5nZXMgZnJvbSBWNToNCkFwcGxp
ZWQgZHJpdmVyIHVwZGF0ZSBjaGFuZ2UgYXQgdGhlIGVuZC4NCk1lcmdlZCAxMCBhbmQgMTEgb2Yg
VjUgaW50byA5IG9mIFY2Lg0KQUFDX01BWF9NU0lYIGRlZmluaXRpb24gY2hhbmdlLg0KYWFjX21z
aSBvcHRpb24gZGVzY3JpcHRpb24gYW5kIHN1YmplY3QgY2hhbmdlLg0KDQpUaGFua3MsDQpNYWhl
c2gNCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IEphbWVzIEJvdHRvbWxleSBb
bWFpbHRvOkphbWVzLkJvdHRvbWxleUBIYW5zZW5QYXJ0bmVyc2hpcC5jb21dIA0KU2VudDogV2Vk
bmVzZGF5LCBBdWd1c3QgMTIsIDIwMTUgMTE6NTkgUE0NClRvOiBUb21hcyBIZW56bA0KQ2M6IFJh
amluaWthbnRoIFBhbmR1cmFuZ2FuOyBqYm90dG9tbGV5QHBhcmFsbGVscy5jb207IGxpbnV4LXNj
c2lAdmdlci5rZXJuZWwub3JnOyBhYWNyYWlkQHBtYy1zaWVycmEuY29tOyBIYXJyeSBZYW5nOyBS
aWNoIEJvbm87IE1haGVzaCBSYWphc2hla2hhcmE7IEFjaGltIExldWJuZXI7IE11cnRoeSBCaGF0
DQpTdWJqZWN0OiBSZTogW1BBVENIIFY1IDExLzExXSBbU0NTSV0gYWFjcmFpZDogUmVxdWVzdHMg
YXQgbGVhc3QgMiBNU0l4IGluIHBjaV9lbmFibGVfbXNpeF9yYW5nZSgpDQoNCg0KPiBPbiAyMi43
LjIwMTUgMTg6NDksIHJhamluaWthbnRoLnBhbmR1cmFuZ2FuQHBtY3MuY29tIHdyb3RlOg0KPiA+
IEZyb206IFJhamluaWthbnRoIFBhbmR1cmFuZ2FuIDxyYWppbmlrYW50aC5wYW5kdXJhbmdhbkBw
bWNzLmNvbT4NCj4gPiANCj4gPiBEZXNjcmlwdGlvbjoNCj4gPiAgICAgICAgIEluIE1TSXggbW9k
ZSwgd2UgbmVlZCBhdCBsZWFzdCAyIHZlY3RvcnMuDQo+ID4gDQo+ID4gQ2hhbmdlcyBmcm9tIFY0
Og0KPiA+ICAgICAgIE5ld2x5IGNyZWF0ZWQgZm9yIFY1IGJhc2VkIG9uIHJldmlldyBjb21tZW50
Lg0KPiA+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IFJhamluaWthbnRoIFBhbmR1cmFuZ2FuDQo+IDxy
YWppbmlrYW50aC5wYW5kdXJhbmdhbkBwbWNzLg0KPiANCj4gUmV2aWV3ZWQtYnk6IFRvbWFzIEhl
bnpsIDx0aGVuemxAcmVkaGF0LmNvbT4NCg0KSSdtIGNvbmZ1c2VkIGJ5IHlvdXIgW1BBVENIIHY2
XSBwb3N0aW5nOiB3aGVyZSBkaWQgdGhpcyBwYXRjaCBnbyAuLi4gZG8geW91IHdhbnQgaXQgZHJv
cHBlZCBvciBkaWQgeW91IGp1c3QgZm9yZ2V0IHRvIGluY2x1ZGUgaXQ/DQoNCkphbWVzDQoNCg0K
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mahesh Rajashekhara Aug. 17, 2015, 2:12 p.m. UTC | #5 
Hi James,

Please let me know the status of V6 patchset.

Thanks,
Mahesh
-----Original Message-----
From: Mahesh Rajashekhara [mailto:Mahesh.Rajashekhara@pmcs.com] 

Sent: Thursday, August 13, 2015 5:52 AM
To: James Bottomley; Tomas Henzl
Cc: jbottomley@parallels.com; linux-scsi@vger.kernel.org; aacraid@pmc-sierra.com; Harry Yang; Rich Bono
Subject: RE: [PATCH V5 11/11] [SCSI] aacraid: Requests at least 2 MSIx in pci_enable_msix_range()

As Tomas Henzl suggested, I have merged 10 and 11 of V5 into single patch (i.e 9 of V6)

Changes from V5:
Applied driver update change at the end.
Merged 10 and 11 of V5 into 9 of V6.
AAC_MAX_MSIX definition change.
aac_msi option description and subject change.

Thanks,
Mahesh

-----Original Message-----
From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com] 

Sent: Wednesday, August 12, 2015 11:59 PM
To: Tomas Henzl
Cc: Rajinikanth Pandurangan; jbottomley@parallels.com; linux-scsi@vger.kernel.org; aacraid@pmc-sierra.com; Harry Yang; Rich Bono; Mahesh Rajashekhara; Achim Leubner; Murthy Bhat
Subject: Re: [PATCH V5 11/11] [SCSI] aacraid: Requests at least 2 MSIx in pci_enable_msix_range()


> On 22.7.2015 18:49, rajinikanth.pandurangan@pmcs.com wrote:

> > From: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.com>

> > 

> > Description:

> >         In MSIx mode, we need at least 2 vectors.

> > 

> > Changes from V4:

> >       Newly created for V5 based on review comment.

> > 

> > Signed-off-by: Rajinikanth Pandurangan

> <rajinikanth.pandurangan@pmcs.

> 

> Reviewed-by: Tomas Henzl <thenzl@redhat.com>


I'm confused by your [PATCH v6] posting: where did this patch go ... do you want it dropped or did you just forget to include it?

James
James Bottomley Aug. 17, 2015, 2:17 p.m. UTC | #6 
On Mon, 2015-08-17 at 14:12 +0000, Mahesh Rajashekhara wrote:
> Hi James,
> 
> Please let me know the status of V6 patchset.

Well, you altered it fairly significantly with the combination, so I
need the original reviewers at least to glance over it and say their
reviews stand.

If you kept the review tags going V5->V6, this would be a lot easier: as
long as the reviewers were cc'd, I could apply the series if they didn't
object.  Now I have to wait for them to say it's OK.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/scsi/aacraid/comminit.c b/drivers/scsi/aacraid/comminit.c
index a02cfb3..0e954e3 100644
--- a/drivers/scsi/aacraid/comminit.c
+++ b/drivers/scsi/aacraid/comminit.c
@@ -366,7 +366,7 @@  void aac_define_int_mode(struct aac_dev *dev)
 
 	if (msi_count > 1 &&
 	    pci_find_capability(dev->pdev, PCI_CAP_ID_MSIX)) {
-		min_msix = 1;
+		min_msix = 2;
 		i = pci_enable_msix_range(dev->pdev,
 				    dev->msixentry,
 				    min_msix,