From patchwork Sat Aug 1 17:19:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 6922501 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 8176D9F358 for ; Sat, 1 Aug 2015 17:19:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A004D20501 for ; Sat, 1 Aug 2015 17:19:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4196202B8 for ; Sat, 1 Aug 2015 17:19:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751410AbbHARTw (ORCPT ); Sat, 1 Aug 2015 13:19:52 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:34216 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbbHARTv (ORCPT ); Sat, 1 Aug 2015 13:19:51 -0400 Received: by pacan13 with SMTP id an13so60204941pac.1 for ; Sat, 01 Aug 2015 10:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7qlknD8OHwb2hPU1xwhYWb6ALwuOoishxuv12tD8Zi8=; b=0bWRiBuQbcluhzCybup/0yKmF/5GbFSbkM4vN0v26my+o+CX3m+97BC2W8q4FvjdUX xZH+AsznibS1CadgCb/4TXN62GswjFwEr3mtfMKaIJplRmnQGgrSet3Mia/AqCJBgyks 5V9pmmme/pP6Fx7gC4Dnen5sTC6YLtwIWSEcNXOvUIfIgH15G5kBm2ZXbdaJi6ci4F6N +0Z8sWMtTFzzd+uDuh8/T1aRAFUCfaJ5Hv3HjFAQLZrA6lqs0wm4jSaEXhTtzw+oW93V vQhBCfrCxuTouLwzNWjza1+KwDnIYj7rNiOgefYc0VigWuMgvy87Mdg/9sTk2+iN3DP4 FrMA== X-Received: by 10.68.178.65 with SMTP id cw1mr7625430pbc.111.1438449591170; Sat, 01 Aug 2015 10:19:51 -0700 (PDT) Received: from localhost.localdomain (KD113159139091.ppp-bb.dion.ne.jp. [113.159.139.91]) by smtp.gmail.com with ESMTPSA id tm3sm12259153pac.44.2015.08.01.10.19.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 01 Aug 2015 10:19:50 -0700 (PDT) From: Akinobu Mita To: linux-scsi@vger.kernel.org Cc: Akinobu Mita , Vinayak Holikatti , "James E.J. Bottomley" , Christoph Hellwig , Dolev Raviv , Sujit Reddy Thumma , Maya Erez , Raviv Shvili , Sahitya Tummala , Subhash Jadavani , "Rafael J. Wysocki" Subject: [PATCH v2 3/6] scsi: ufs: fix unbalanced power.disable_depth after reloading driver Date: Sun, 2 Aug 2015 02:19:17 +0900 Message-Id: <1438449560-4106-4-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1438449560-4106-1-git-send-email-akinobu.mita@gmail.com> References: <1438449560-4106-1-git-send-email-akinobu.mita@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Every time the driver is reloaded, the warning message "Unbalanced pm_runtime_enable!" is triggered due to unbalanced power.disable_depth. This is because pm_runtime_enable() is called during driver probe but pm_runtime_disable() is missed on driver remove. This also restores the device's runtime PM status to 'suspended' on driver remove as it was set to 'active' during driver probe. Signed-off-by: Akinobu Mita Cc: Vinayak Holikatti Cc: "James E.J. Bottomley" Cc: Christoph Hellwig Cc: Dolev Raviv Cc: Sujit Reddy Thumma Cc: Maya Erez Cc: Raviv Shvili Cc: Sahitya Tummala Cc: Subhash Jadavani Cc: "Rafael J. Wysocki" Cc: linux-scsi@vger.kernel.org --- drivers/scsi/ufs/ufshcd-pltfrm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c index 9beac71..12f1246 100644 --- a/drivers/scsi/ufs/ufshcd-pltfrm.c +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c @@ -369,6 +369,10 @@ static int ufshcd_pltfrm_remove(struct platform_device *pdev) pm_runtime_get_sync(&(pdev)->dev); ufshcd_remove(hba); pm_runtime_put_noidle(&pdev->dev); + + pm_runtime_disable(&pdev->dev); + pm_runtime_set_suspended(&pdev->dev); + return 0; }