From patchwork Tue Aug 4 18:25:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomer Barletz X-Patchwork-Id: 6943511 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DAE96C05AC for ; Tue, 4 Aug 2015 18:26:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DEB9220531 for ; Tue, 4 Aug 2015 18:26:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15DEF20528 for ; Tue, 4 Aug 2015 18:26:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752351AbbHDS0E (ORCPT ); Tue, 4 Aug 2015 14:26:04 -0400 Received: from mail-qg0-f51.google.com ([209.85.192.51]:34105 "EHLO mail-qg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751788AbbHDS0D (ORCPT ); Tue, 4 Aug 2015 14:26:03 -0400 Received: by qgeu79 with SMTP id u79so12956915qge.1; Tue, 04 Aug 2015 11:26:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6baZgvmRD8/bWoSTi7/fhv2zW1QIRzYlcSUaXWU+XWM=; b=APMv17bcnvhhBLAqJ6aw3T8iz4XJjBgOWxWBInsEfj6YHYCsJcgD8BAeZOiMO6VBWz Iulap/yaQgy8pHYepE687qz9Fi9h31r/O2p6xLDL7WyUiB5jz5cjOqYAMnAUiEp5zNhT pvndIPXHF2FnuccAJ8LN9mJra5/ErAXUhiQVGn1ynuRlOPynNQnRqnOEoWkspATWBRm4 deF4subMU17fK+CnYO5KjZk085LeRD3UKPwix4RkJgtYfQ/eRPXeuf73BorEgucpE6W8 o89sb+po/RgDJz3yPilkO5YCifsnJngdNQfH/eo/lyiK8ag7pjjnxVVJ9MWhQfd3+Nmq Ip3Q== X-Received: by 10.140.98.226 with SMTP id o89mr4282478qge.12.1438712761998; Tue, 04 Aug 2015 11:26:01 -0700 (PDT) Received: from tbarletz-t440.arrs.arrisi.com (kirkland-vpn.arrisi.com. [134.242.100.5]) by smtp.gmail.com with ESMTPSA id 198sm60188qhy.27.2015.08.04.11.26.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Aug 2015 11:26:01 -0700 (PDT) From: Tomer Barletz To: jayamohan.kallickal@avagotech.com, minh.tran@avagotech.com, sony.john-n@avagotech.com, JBottomley@odin.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Tomer Barletz Subject: [PATCH] scsi/be2iscsi: Fix logical-not-parentheses compilation warning Date: Tue, 4 Aug 2015 11:25:43 -0700 Message-Id: <1438712743-5821-1-git-send-email-barletz@gmail.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: References: Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This fixes the following warning seen with GCC v5.1: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]. Signed-off-by: Tomer Barletz Reviewed-by: Johannes Thumshirn --- drivers/scsi/be2iscsi/be_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 7a6dbfb..cf1908e 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -3184,7 +3184,7 @@ be_sgl_create_contiguous(void *virtual_address, { WARN_ON(!virtual_address); WARN_ON(!physical_address); - WARN_ON(!length > 0); + WARN_ON(length == 0); WARN_ON(!sgl); sgl->va = virtual_address;