| Message ID | 1439272701-15344-9-git-send-email-Mahesh.Rajashekhara@pmcs.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 11.8.2015 07:58, Mahesh Rajashekhara wrote: > Description: > Controller BIOS/UEFI driver used to send this request. But for > IBM-Power system there is no BIOS/UEFI driver. So this change is > required for IBM, otherwise controller will be read-only mode. > > Changes from V2: > None > > Signed-off-by: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com> > --- > drivers/scsi/aacraid/linit.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c > index 3b6e5c6..35dd849 100644 > --- a/drivers/scsi/aacraid/linit.c > +++ b/drivers/scsi/aacraid/linit.c > @@ -1270,8 +1270,11 @@ static int aac_probe_one(struct pci_dev *pdev, const struct pci_device_id *id) > shost->max_channel = aac->maximum_num_channels; > else > shost->max_channel = 0; > - > +#if defined(__powerpc__) || defined(__PPC__) || defined(__ppc__) > + aac_get_config_status(aac, 1); > +#else > aac_get_config_status(aac, 0); > +#endif If we use instead + aac_get_config_status(aac, 1); on all archs will it make problems ? Tomas > aac_get_containers(aac); > list_add(&aac->entry, insert); > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Aug 25, 2015 at 04:57:26PM +0200, Tomas Henzl wrote: > On 11.8.2015 07:58, Mahesh Rajashekhara wrote: > > +#if defined(__powerpc__) || defined(__PPC__) || defined(__ppc__) > > + aac_get_config_status(aac, 1); > > +#else > > aac_get_config_status(aac, 0); > > +#endif > > If we use instead > + aac_get_config_status(aac, 1); > on all archs will it make problems ? Yes, that should be our first choice. If that doesn't work it should be a #ifndef CONFIG_X86 with a comment explaining it. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Christoph, Hi Tomas, After discussed internally, this driver patch is required only if "auto commit" support is not available in the controller firmware. We have fix in the released controller firmware, so this driver patch is not needed. I'm removing this patch in V7. Hi James, As you suggested, will keep the review-tags going V6->V7 and add reviewers in CC list. Thanks, Mahesh -----Original Message----- From: Christoph Hellwig [mailto:hch@infradead.org] Sent: Tuesday, August 25, 2015 8:41 PM To: Tomas Henzl Cc: Mahesh Rajashekhara; JBottomley@Parallels.com; linux-scsi@vger.kernel.org; aacraid@pmc-sierra.com; Harry Yang; Rich Bono Subject: Re: [PATCH V6 08/10] [SCSI] aacraid: Send commit-config to controller firmware On Tue, Aug 25, 2015 at 04:57:26PM +0200, Tomas Henzl wrote: > On 11.8.2015 07:58, Mahesh Rajashekhara wrote: > > +#if defined(__powerpc__) || defined(__PPC__) || defined(__ppc__) > > + aac_get_config_status(aac, 1); > > +#else > > aac_get_config_status(aac, 0); > > +#endif > > If we use instead > + aac_get_config_status(aac, 1); > on all archs will it make problems ? Yes, that should be our first choice. If that doesn't work it should be a #ifndef CONFIG_X86 with a comment explaining it. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index 3b6e5c6..35dd849 100644 --- a/drivers/scsi/aacraid/linit.c +++ b/drivers/scsi/aacraid/linit.c @@ -1270,8 +1270,11 @@ static int aac_probe_one(struct pci_dev *pdev, const struct pci_device_id *id) shost->max_channel = aac->maximum_num_channels; else shost->max_channel = 0; - +#if defined(__powerpc__) || defined(__PPC__) || defined(__ppc__) + aac_get_config_status(aac, 1); +#else aac_get_config_status(aac, 0); +#endif aac_get_containers(aac); list_add(&aac->entry, insert);
Description: Controller BIOS/UEFI driver used to send this request. But for IBM-Power system there is no BIOS/UEFI driver. So this change is required for IBM, otherwise controller will be read-only mode. Changes from V2: None Signed-off-by: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com> --- drivers/scsi/aacraid/linit.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)