| Message ID | 1440672667-8203-2-git-send-email-Mahesh.Rajashekhara@pmcs.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 2015-08-27 at 06:50 -0400, Mahesh Rajashekhara wrote: > Description: > Driver sends the right size of the response buffer. > > Changes from V2: > None > > Reviewed By: Tomas Henzl <thenzl@redhat.com>, Murthy Bhat <Murthy.Bhat@pmcs.com>, Karthikeya Sunkesula <Karthikeya.Sunkesula@pmcs.com> > > Signed-off-by: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com> You've had hundreds of upstream confirmation emails over the years. They've all had one line per tag with no spaces. Next time can we please use the right format so I don't have to keep editing your commit messages. That is: Subject: One line summary Detailed Description of the change (without a Description: prefix) Reviewed-by: Tomas Henzl <thenzl@redhat.com> Reviewed-by: Murthy Bhat <Murthy.Bhat@pmcs.com> Reviewed-by: Karthikeya Sunkesula <Karthikeya.Sunkesula@pmcs.com> Signed-off-by: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com> --- Version notices and other context relevant only to the upstream process come here after the three dashes so it doesn't appear in the patch detailed description James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi James, I have taken care your review comments in V8 patch series. Thanks, Mahesh -----Original Message----- From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com] Sent: Thursday, August 27, 2015 8:38 PM To: Mahesh Rajashekhara Cc: JBottomley@Parallels.com; linux-scsi@vger.kernel.org; thenzl@redhat.com; Murthy Bhat; Karthikeya Sunkesula; aacraid@pmc-sierra.com; Harry Yang; Rich Bono Subject: Re: [PATCH V7 1/9] [SCSI] aacraid: Fix for logical device name and UID not exposed to the OS On Thu, 2015-08-27 at 06:50 -0400, Mahesh Rajashekhara wrote: > Description: > Driver sends the right size of the response buffer. > > Changes from V2: > None > > Reviewed By: Tomas Henzl <thenzl@redhat.com>, Murthy Bhat > <Murthy.Bhat@pmcs.com>, Karthikeya Sunkesula > <Karthikeya.Sunkesula@pmcs.com> > > Signed-off-by: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com> You've had hundreds of upstream confirmation emails over the years. They've all had one line per tag with no spaces. Next time can we please use the right format so I don't have to keep editing your commit messages. That is: Subject: One line summary Detailed Description of the change (without a Description: prefix) Reviewed-by: Tomas Henzl <thenzl@redhat.com> Reviewed-by: Murthy Bhat <Murthy.Bhat@pmcs.com> Reviewed-by: Karthikeya Sunkesula <Karthikeya.Sunkesula@pmcs.com> Signed-off-by: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com> --- Version notices and other context relevant only to the upstream process come here after the three dashes so it doesn't appear in the patch detailed description James
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c index 9b3dd6e..fe59b00 100644 --- a/drivers/scsi/aacraid/aachba.c +++ b/drivers/scsi/aacraid/aachba.c @@ -570,7 +570,7 @@ static int aac_get_container_name(struct scsi_cmnd * scsicmd) status = aac_fib_send(ContainerCommand, cmd_fibcontext, - sizeof (struct aac_get_name), + sizeof(struct aac_get_name_resp), FsaNormal, 0, 1, (fib_callback)get_container_name_callback, @@ -1052,7 +1052,7 @@ static int aac_get_container_serial(struct scsi_cmnd * scsicmd) status = aac_fib_send(ContainerCommand, cmd_fibcontext, - sizeof (struct aac_get_serial), + sizeof(struct aac_get_serial_resp), FsaNormal, 0, 1, (fib_callback) get_container_serial_callback,
Description: Driver sends the right size of the response buffer. Changes from V2: None Reviewed By: Tomas Henzl <thenzl@redhat.com>, Murthy Bhat <Murthy.Bhat@pmcs.com>, Karthikeya Sunkesula <Karthikeya.Sunkesula@pmcs.com> Signed-off-by: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com> --- drivers/scsi/aacraid/aachba.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)