| Message ID | 1443193731-12587-1-git-send-email-shraddha.6596@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 09/25/2015 05:08 PM, Shraddha Barke wrote: > Use module_pci_driver for drivers whose init and exit functions > only register and unregister respectively > > Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com> > --- > drivers/scsi/am53c974.c | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) > > diff --git a/drivers/scsi/am53c974.c b/drivers/scsi/am53c974.c > index beea30e..0234b38 100644 > --- a/drivers/scsi/am53c974.c > +++ b/drivers/scsi/am53c974.c > @@ -556,16 +556,6 @@ static struct pci_driver am53c974_driver = { > .remove = pci_esp_remove_one, > }; > > -static int __init am53c974_module_init(void) > -{ > - return pci_register_driver(&am53c974_driver); > -} > - > -static void __exit am53c974_module_exit(void) > -{ > - pci_unregister_driver(&am53c974_driver); > -} > - > MODULE_DESCRIPTION("AM53C974 SCSI driver"); > MODULE_AUTHOR("Hannes Reinecke <hare@suse.de>"); > MODULE_LICENSE("GPL"); > @@ -577,6 +567,4 @@ MODULE_PARM_DESC(am53c974_debug, "Enable debugging"); > > module_param(am53c974_fenab, bool, 0444); > MODULE_PARM_DESC(am53c974_fenab, "Enable 24-bit DMA transfer sizes"); > - > -module_init(am53c974_module_init); > -module_exit(am53c974_module_exit); > +module_pci_driver(am53c974_driver); > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
diff --git a/drivers/scsi/am53c974.c b/drivers/scsi/am53c974.c index beea30e..0234b38 100644 --- a/drivers/scsi/am53c974.c +++ b/drivers/scsi/am53c974.c @@ -556,16 +556,6 @@ static struct pci_driver am53c974_driver = { .remove = pci_esp_remove_one, }; -static int __init am53c974_module_init(void) -{ - return pci_register_driver(&am53c974_driver); -} - -static void __exit am53c974_module_exit(void) -{ - pci_unregister_driver(&am53c974_driver); -} - MODULE_DESCRIPTION("AM53C974 SCSI driver"); MODULE_AUTHOR("Hannes Reinecke <hare@suse.de>"); MODULE_LICENSE("GPL"); @@ -577,6 +567,4 @@ MODULE_PARM_DESC(am53c974_debug, "Enable debugging"); module_param(am53c974_fenab, bool, 0444); MODULE_PARM_DESC(am53c974_fenab, "Enable 24-bit DMA transfer sizes"); - -module_init(am53c974_module_init); -module_exit(am53c974_module_exit); +module_pci_driver(am53c974_driver);
Use module_pci_driver for drivers whose init and exit functions only register and unregister respectively Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com> --- drivers/scsi/am53c974.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-)