From patchwork Wed Oct 14 23:36:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis de Bethencourt X-Patchwork-Id: 7399251 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 13C11BEEA4 for ; Wed, 14 Oct 2015 23:36:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2C88A209D4 for ; Wed, 14 Oct 2015 23:36:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3593D209D0 for ; Wed, 14 Oct 2015 23:36:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754713AbbJNXgc (ORCPT ); Wed, 14 Oct 2015 19:36:32 -0400 Received: from lists.s-osg.org ([54.187.51.154]:56703 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753898AbbJNXgb (ORCPT ); Wed, 14 Oct 2015 19:36:31 -0400 Received: from snow.seri.co.uk (cpc9-slam5-2-0-cust824.2-4.cable.virginm.net [81.108.163.57]) by lists.s-osg.org (Postfix) with ESMTPSA id 0A6DC462A0; Wed, 14 Oct 2015 16:36:29 -0700 (PDT) From: Luis de Bethencourt To: linux-kernel@vger.kernel.org Cc: rdunlap@infradead.org, JBottomley@odin.com, linux-scsi@vger.kernel.org, Luis de Bethencourt Subject: [PATCH v2] scsi: kconfig: When possible, compile drivers with COMPILE_TEST Date: Thu, 15 Oct 2015 00:36:09 +0100 Message-Id: <1444865769-3380-1-git-send-email-luisbg@osg.samsung.com> X-Mailer: git-send-email 2.5.1 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP These drivers only have runtime but no build time dependencies, so they can be built for testing purposes if the Kconfig COMPILE_TEST option is enabled. This is useful to have more build coverage and make sure that drivers are not affected by changes that could cause build regressions. Signed-off-by: Luis de Bethencourt --- Hi, This version corrects a typo pointed out by Randy Dunlap. The validity of the patch is still in question after the comments by James Bottomley. [0] I just wanted to send a correct version as a thank you to Randy. Thanks, Luis [0] https://lkml.org/lkml/2015/10/14/995 drivers/scsi/Kconfig | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index d2f480b..e90e0ca 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -416,7 +416,7 @@ config SCSI_ACARD config SCSI_AHA152X tristate "Adaptec AHA152X/2825 support" - depends on ISA && SCSI + depends on (ISA || COMPILE_TEST) && SCSI select SCSI_SPI_ATTRS select CHECK_SIGNATURE ---help--- @@ -509,7 +509,7 @@ config SCSI_ADVANSYS config SCSI_IN2000 tristate "Always IN2000 SCSI support" - depends on ISA && SCSI + depends on (ISA || COMPILE_TEST) && SCSI help This is support for an ISA bus SCSI host adapter. You'll find more information in . If it doesn't work @@ -657,7 +657,7 @@ config SCSI_DMX3191D config SCSI_DTC3280 tristate "DTC3180/3280 SCSI support" - depends on ISA && SCSI + depends on (ISA || COMPILE_TEST) && SCSI select SCSI_SPI_ATTRS select CHECK_SIGNATURE help @@ -776,7 +776,7 @@ config SCSI_ISCI config SCSI_GENERIC_NCR5380 tristate "Generic NCR5380/53c400 SCSI PIO support" - depends on ISA && SCSI + depends on (ISA || COMPILE_TEST) && SCSI select SCSI_SPI_ATTRS ---help--- This is a driver for the old NCR 53c80 series of SCSI controllers @@ -796,7 +796,7 @@ config SCSI_GENERIC_NCR5380 config SCSI_GENERIC_NCR5380_MMIO tristate "Generic NCR5380/53c400 SCSI MMIO support" - depends on ISA && SCSI + depends on (ISA || COMPILE_TEST) && SCSI select SCSI_SPI_ATTRS ---help--- This is a driver for the old NCR 53c80 series of SCSI controllers @@ -970,7 +970,7 @@ config SCSI_IZIP_SLOW_CTR config SCSI_NCR53C406A tristate "NCR53c406a SCSI support" - depends on ISA && SCSI + depends on (ISA || COMPILE_TEST) && SCSI help This is support for the NCR53c406a SCSI host adapter. For user configurable parameters, check out @@ -1238,7 +1238,7 @@ config SCSI_NCR53C8XX_NO_DISCONNECT config SCSI_PAS16 tristate "PAS16 SCSI support" - depends on ISA && SCSI + depends on (ISA || COMPILE_TEST) && SCSI select SCSI_SPI_ATTRS ---help--- This is support for a SCSI host adapter. It is explained in section @@ -1252,7 +1252,7 @@ config SCSI_PAS16 config SCSI_QLOGIC_FAS tristate "Qlogic FAS SCSI support" - depends on ISA && SCSI + depends on (ISA || COMPILE_TEST) && SCSI ---help--- This is a driver for the ISA, VLB, and PCMCIA versions of the Qlogic FastSCSI! cards as well as any other card based on the FASXX chip @@ -1321,7 +1321,7 @@ config SCSI_SIM710 config SCSI_SYM53C416 tristate "Symbios 53c416 SCSI support" - depends on ISA && SCSI + depends on (ISA || COMPILE_TEST) && SCSI ---help--- This is support for the sym53c416 SCSI host adapter, the SCSI adapter that comes with some HP scanners. This driver requires that @@ -1372,7 +1372,7 @@ config SCSI_AM53C974 config SCSI_T128 tristate "Trantor T128/T128F/T228 SCSI support" - depends on ISA && SCSI + depends on (ISA || COMPILE_TEST) && SCSI select SCSI_SPI_ATTRS select CHECK_SIGNATURE ---help---