diff mbox

scsi: mvsas: fix indenting on return error code

Message ID 1451995000-9210-1-git-send-email-colin.king@canonical.com (mailing list archive)
State Rejected, archived
Headers show

Commit Message

Colin King Jan. 5, 2016, 11:56 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The return code and error return is incorrectly indented which
may cause some confusion as it appears at first sight to be associated
with a device not ready error (with missing { } braces) rather than
a DEV_IS_GONE() failure.

The incorrect indenting was introduced by commit
0b15fb1fdfd403726542cb6111bc916b7a9f7fad ("[SCSI] mvsas: add support
for Task collector mode and fixed relative bugs")

No functional change, just a minor code reformatting clean up.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/scsi/mvsas/mv_sas.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tomas Henzl Jan. 5, 2016, 12:35 p.m. UTC | #1 
On 5.1.2016 12:56, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The return code and error return is incorrectly indented which
> may cause some confusion as it appears at first sight to be associated
> with a device not ready error (with missing { } braces) rather than
> a DEV_IS_GONE() failure.
>
> The incorrect indenting was introduced by commit
> 0b15fb1fdfd403726542cb6111bc916b7a9f7fad ("[SCSI] mvsas: add support
> for Task collector mode and fixed relative bugs")
>
> No functional change, just a minor code reformatting clean up.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Tomas

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Martin K. Petersen Jan. 6, 2016, 8:29 p.m. UTC | #2 
>>>>> "Colin" == Colin King <colin.king@canonical.com> writes:

Colin,

Colin> The return code and error return is incorrectly indented which
Colin> may cause some confusion as it appears at first sight to be
Colin> associated with a device not ready error (with missing { }
Colin> braces) rather than a DEV_IS_GONE() failure.

This problem has already been addressed:

https://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/commit/?h=4.5/scsi-queue&id=7789cd39274c
diff mbox

Patch

diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
index 9c78074..e712fe7 100644
--- a/drivers/scsi/mvsas/mv_sas.c
+++ b/drivers/scsi/mvsas/mv_sas.c
@@ -737,8 +737,8 @@  static int mvs_task_prep(struct sas_task *task, struct mvs_info *mvi, int is_tmf
 			mv_dprintk("device %016llx not ready.\n",
 				SAS_ADDR(dev->sas_addr));
 
-			rc = SAS_PHY_DOWN;
-			return rc;
+		rc = SAS_PHY_DOWN;
+		return rc;
 	}
 	tei.port = dev->port->lldd_port;
 	if (tei.port && !tei.port->port_attached && !tmf) {