From patchwork Sat Jan 30 03:36:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: KY Srinivasan X-Patchwork-Id: 8169351 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BA8B0BEEE5 for ; Sat, 30 Jan 2016 02:00:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D8CC920395 for ; Sat, 30 Jan 2016 02:00:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA4AD2038E for ; Sat, 30 Jan 2016 02:00:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753754AbcA3B76 (ORCPT ); Fri, 29 Jan 2016 20:59:58 -0500 Received: from p3plsmtps2ded04.prod.phx3.secureserver.net ([208.109.80.198]:47693 "EHLO p3plsmtps2ded04.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877AbcA3B75 (ORCPT ); Fri, 29 Jan 2016 20:59:57 -0500 Received: from linuxonhyperv.com ([72.167.245.219]) by : HOSTING RELAY : with SMTP id PKpPaYEfnWOsdPKpPaxnEh; Fri, 29 Jan 2016 18:59:56 -0700 x-originating-ip: 72.167.245.219 Received: by linuxonhyperv.com (Postfix, from userid 507) id 6BDB31902B2; Fri, 29 Jan 2016 19:36:28 -0800 (PST) From: "K. Y. Srinivasan" To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, ohering@suse.com, James.Bottomley@HansenPartnership.com, hch@infradead.org, linux-scsi@vger.kernel.org, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, martin.petersen@oracle.com, hare@suse.de Cc: "K. Y. Srinivasan" Subject: [PATCH V2 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot Date: Fri, 29 Jan 2016 19:36:27 -0800 Message-Id: <1454124987-20848-1-git-send-email-kys@microsoft.com> X-Mailer: git-send-email 1.7.4.1 X-CMAE-Envelope: MS4wfFVW8TrrtxKZjafwXq0fOOa19OSMEZU/awt+CJjegEQfhmWh0nLqR6wcs340XiX7forsw4GUA2/uHqtOGgo2KvhhOSBpS6UU5mCLyu9wSsTG+BHbe/Ya XXDzLxKtYCSxfhVbeELbyNLefrNJ5d6v1nrv5VPpY/N7maZo68tcn2akGffx+ZgupYom0oss8+a0wwT8H1jI/8LjMkKQd/4D4Z/Aw0MqAOemojoaZaxe8Smy HQygMbLMCVYLyXgHIzct9Y42jnMfw8vCtJe39ue732aAQmL175xvmtN0e2EPdaztOQ1mBxCZj3O7e4mauAe39NJwrMC9wTTLQNw6W0rRbYs0yB5Dtc2BQRvN m/rARkN+KcHM7v6DEDtxIXJHcnr5zXfiLMW90Q1UDbeU/epxZ1601nnW2I19heHT5ULGtFXBCb2kl8uGDllpZB/+XOdwWOTukAZzs0oIc2IVKJUI1WQCEnAM qQ1Q+vFHdiXBfz7GEmVdqCqaNWgkZp6LSCRUkyACJSM2jCNsVSiwzXFnrDTXwJb5Vf0UjaqXzReQMuvVj46ZA2G3EuO9cgMDt95I8uipEMAzlDqWRV4Oh1/c cU8EM5DP81NLjPI/gW8vmzku Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP tree: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit.kernel.org%2fpub%2fscm%2flinux%2fkernel%2fgit%2ftorvalds%2flinux.git&data=01%7c01%7ckys%40microsoft.com%7ce2e0622715844b79ad7108d32796ec3c%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=ubr4GbBaNS%2ftOz%2buJBk0CL9N0UNG9x2TidLgy6Yovg4%3d master head: 03c21cb775a313f1ff19be59c5d02df3e3526471 commit: dac582417bc449b1f7f572d3f1dd9d23eec15cc9 storvsc: Properly support Fibre Channel devices date: 3 weeks ago config: x86_64-randconfig-s3-01281016 (attached as .config) reproduce: git checkout dac582417bc449b1f7f572d3f1dd9d23eec15cc9 # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/built-in.o: In function `storvsc_remove': >> storvsc_drv.c:(.text+0x213af7): undefined reference to `fc_remove_host' drivers/built-in.o: In function `storvsc_drv_init': >> storvsc_drv.c:(.init.text+0xcbcc): undefined reference to `fc_attach_transport' >> storvsc_drv.c:(.init.text+0xcc06): undefined reference to `fc_release_transport' drivers/built-in.o: In function `storvsc_drv_exit': >> storvsc_drv.c:(.exit.text+0x123c): undefined reference to `fc_release_transport' With this commit, the storvsc driver depends on FC atttributes. Make this dependency explicit. Signed-off-by: K. Y. Srinivasan Reported-by: Fengguang Wu --- V2: Fixed the dependency based on suggestion by James Bottomley drivers/scsi/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 64eed87..ce0d07b 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -594,6 +594,7 @@ config XEN_SCSI_FRONTEND config HYPERV_STORAGE tristate "Microsoft Hyper-V virtual storage driver" depends on SCSI && HYPERV + depends on SCSI_FC_ATTRS || SCSI_FC_ATTRS !=m default HYPERV help Select this option to enable the Hyper-V virtual storage driver.