| Message ID | 1454542114-1797-2-git-send-email-tyreld@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Wed, Feb 03, 2016 at 05:28:29PM -0600, Tyrel Datwyler wrote: > The enum values for VIOSRP_LINUX_FORMAT and VIOSRP_INLINE_FORMAT are > off by one. They are currently defined as 0x06 and 0x07 respetively. > These values are defined in PAPR correctly as 0x05 and 0x06. This > inconsistency has gone unnoticed as neither enum is currently used. > The possible future support of PING messages between the VIOS and > client adapter relies on VIOSRP_INLINE_FORMAT crq messages. > Corrected these enum values to match PAPR definitions. > > Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com> > --- > drivers/scsi/ibmvscsi/viosrp.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/ibmvscsi/viosrp.h b/drivers/scsi/ibmvscsi/viosrp.h > index 1162430..d1044e9 100644 > --- a/drivers/scsi/ibmvscsi/viosrp.h > +++ b/drivers/scsi/ibmvscsi/viosrp.h > @@ -56,8 +56,8 @@ enum viosrp_crq_formats { > VIOSRP_MAD_FORMAT = 0x02, > VIOSRP_OS400_FORMAT = 0x03, > VIOSRP_AIX_FORMAT = 0x04, > - VIOSRP_LINUX_FORMAT = 0x06, > - VIOSRP_INLINE_FORMAT = 0x07 > + VIOSRP_LINUX_FORMAT = 0x05, > + VIOSRP_INLINE_FORMAT = 0x06 > }; > > enum viosrp_crq_status { > -- > 2.5.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
diff --git a/drivers/scsi/ibmvscsi/viosrp.h b/drivers/scsi/ibmvscsi/viosrp.h index 1162430..d1044e9 100644 --- a/drivers/scsi/ibmvscsi/viosrp.h +++ b/drivers/scsi/ibmvscsi/viosrp.h @@ -56,8 +56,8 @@ enum viosrp_crq_formats { VIOSRP_MAD_FORMAT = 0x02, VIOSRP_OS400_FORMAT = 0x03, VIOSRP_AIX_FORMAT = 0x04, - VIOSRP_LINUX_FORMAT = 0x06, - VIOSRP_INLINE_FORMAT = 0x07 + VIOSRP_LINUX_FORMAT = 0x05, + VIOSRP_INLINE_FORMAT = 0x06 }; enum viosrp_crq_status {
The enum values for VIOSRP_LINUX_FORMAT and VIOSRP_INLINE_FORMAT are off by one. They are currently defined as 0x06 and 0x07 respetively. These values are defined in PAPR correctly as 0x05 and 0x06. This inconsistency has gone unnoticed as neither enum is currently used. The possible future support of PING messages between the VIOS and client adapter relies on VIOSRP_INLINE_FORMAT crq messages. Corrected these enum values to match PAPR definitions. Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/viosrp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)