From patchwork Wed Feb 24 10:28:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 8404281 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 878AAC0553 for ; Wed, 24 Feb 2016 10:28:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AC994201EC for ; Wed, 24 Feb 2016 10:28:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CC6F20219 for ; Wed, 24 Feb 2016 10:28:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753007AbcBXK2N (ORCPT ); Wed, 24 Feb 2016 05:28:13 -0500 Received: from mail-pf0-f170.google.com ([209.85.192.170]:35897 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752132AbcBXK2K (ORCPT ); Wed, 24 Feb 2016 05:28:10 -0500 Received: by mail-pf0-f170.google.com with SMTP id e127so10759068pfe.3; Wed, 24 Feb 2016 02:28:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=fPs4zQ7uKkwzVdO0lsdSNQu+1DqzTr3+cWNPOI5T9Wc=; b=rQenrUCYvFA6FdQpHHhdTg0Q4iSIVskODJaRSC1LCAVsGDaUmOoiQTT3TF5PhytSk1 XHdbveSWNG9mHbOU9erxbjzZMW0K3v3ZhPfrFtBslwPmgfms7SjxTo6Sf0Ieo90RXwSM Kq6apSe3OFtXH46zaOo5vUAjBA2yI6WiensNPRiXZWmY4F7AhfvnMZx7XqikZ5bJHcwl ZGoxaIsUfZiT9hD9O9RbVe8ZsiP3lc60QmJu3ObYc5/LUqBpUt6KYDaSFY/dy56pWwy9 wYONGqU0aJLoq+TSPafChI5Rx56zUG6NbsdRedJcyS14VlZTcFVbGv4pXexinCe5OEJA QdHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fPs4zQ7uKkwzVdO0lsdSNQu+1DqzTr3+cWNPOI5T9Wc=; b=Khgkcw3kCWx0ovoj8i2LJ4hlu/4V2vNaVHIJPrSNOt4qE2Q0AUzmQpsP9QtIl1APN1 6xfkWrt8cDGmU6Qgw5NYx8DYrdATv+T4ufQmClP19GliyzfcQdJOlD9+lwqP0UBNQ2gq 93wWcTAcxO1cWH7TmpBqety72Qo2GfOWMeD9frvZn7uKVT8BHo9QOLlChbkANvMuOQne jvSl+OW9GDeGq77HsyudrMe1vjFbWBmFHR6LNj5uWEIQN3juktvyshkWTtRDfenG8HSk DuonroHLAqzPqBNtt853Shgw3ue/Q6cKjeAEuK3AcFDIzRgDLbJACbUqLOx2FDDWKflz gKDw== X-Gm-Message-State: AG10YOROxlQA2XYesbBIcTwTlAFmieedoz+Kok8khO2YDqkdsnKqHjh7JU7rS/CWytD2Fw== X-Received: by 10.98.12.133 with SMTP id 5mr54013656pfm.20.1456309690289; Wed, 24 Feb 2016 02:28:10 -0800 (PST) Received: from sudip-pc.vectortproxy.org ([14.195.230.182]) by smtp.gmail.com with ESMTPSA id x88sm3912073pfi.66.2016.02.24.02.28.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 24 Feb 2016 02:28:09 -0800 (PST) From: Sudip Mukherjee To: Boaz Harrosh , Benny Halevy , "Martin K. Petersen" Cc: linux-kernel@vger.kernel.org, osd-dev@open-osd.org, linux-scsi@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] osd: remove deadcode Date: Wed, 24 Feb 2016 15:58:00 +0530 Message-Id: <1456309680-17847-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The variable is_ver1 is always true and so OSD_CAP_LEN can never be used. Signed-off-by: Sudip Mukherjee --- drivers/scsi/osd/osd_initiator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c index d8a2b51..3b11aad 100644 --- a/drivers/scsi/osd/osd_initiator.c +++ b/drivers/scsi/osd/osd_initiator.c @@ -2006,9 +2006,8 @@ EXPORT_SYMBOL(osd_sec_init_nosec_doall_caps); */ void osd_set_caps(struct osd_cdb *cdb, const void *caps) { - bool is_ver1 = true; /* NOTE: They start at same address */ - memcpy(&cdb->v1.caps, caps, is_ver1 ? OSDv1_CAP_LEN : OSD_CAP_LEN); + memcpy(&cdb->v1.caps, caps, OSDv1_CAP_LEN); } bool osd_is_sec_alldata(struct osd_security_parameters *sec_parms __unused)