From patchwork Mon Mar 14 14:29:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 8579681 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CC6939F294 for ; Mon, 14 Mar 2016 14:32:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F21F3203A5 for ; Mon, 14 Mar 2016 14:31:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7554620377 for ; Mon, 14 Mar 2016 14:31:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965107AbcCNOaz (ORCPT ); Mon, 14 Mar 2016 10:30:55 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:57076 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932864AbcCNOau (ORCPT ); Mon, 14 Mar 2016 10:30:50 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue101) with ESMTPA (Nemesis) id 0LmuGy-1aBeSw0eGS-00h2i4; Mon, 14 Mar 2016 15:30:14 +0100 From: Arnd Bergmann To: martin.petersen@oracle.com, James.Bottomley@HansenPartnership.com, Adaptec OEM Raid Solutions , "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Johannes Thumshirn , Tomas Henzl , Mahesh Rajashekhara , Raghava Aditya Renukunta , Fengguang Wu Subject: [PATCH 1/3] aacraid: add missing curly braces Date: Mon, 14 Mar 2016 15:29:43 +0100 Message-Id: <1457965789-3373916-2-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1457965789-3373916-1-git-send-email-arnd@arndb.de> References: <1457965789-3373916-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:tZ3PF1flLyNf9KNymC/UmKBRxITIFTE9Z84p/UMdXMzDwJCxRss Wn8HjB8roqcVAS1jGANmt/Wrotxmv2T1RZXHM3keCM6VS4UrPSBFnvIhB6856xE2nXazMRU SivdKGYE8sJIQoCvelaXM4T3prj76Zs5qgfc4ihqiG0L4QLQzMdWQZGk2fWmVI/5O92hMbf klgqoVWdt/gjzfPBRuQbg== X-UI-Out-Filterresults: notjunk:1; V01:K0:G2kOh2X94W8=:0rUA0OKHfNWnYPUbfqxoMg F57slL80ccYNom7kKG4MkgkfTOL4yCsrvIxRROpu/ATebNXH7s4uXK/M2l6jfdXPUIawuqhwb ICFyQUsLp9eJjC4sgmYC/RE6vWbsAj7T1lD87Muc7nX6NEyhE2zlNMr1c+N6P+B/YqStNjN8o 1WfJOski0C14IvPzcprKGVbKcCa2odX+QjvHDXYvPdsuzdC13VuqeCUxFafBhM3gNE0Jpgoyr MC50SfHGqEeCcfj9m05BDbMr6RZ2kUXL5vTrrkfvs9kePjbpQs+pyKEum7+ZQpuX0yPdj/J0b 4BOWDjNxhoJ5QE1t6dWtLAuOXIq9FVGgtgKbScQqb7nBMtLOdkj4ktyJu5QB1SGgp5ftRINwW Q6ElxhPvrkqTJSswNI8TP3j7jOWfu5ZxfUOPHcQ3ke0SUZsRsZrw4hcEl9xqHtkizjBST/5cH bmsqWR33cDu8QzO2Lh1u4t1foEouzlGf/16fjSfQ3Pxc5qeVJ3iYy6mS8QaWSkL3WvPKyuv2+ 19Zxpv23SAWn4WjCOozuhAh/OLi+tEp63sH+MOPYDMggjBGaDBw9I/9zHPsZytY/5vPGuT488 YU6nZUEIiijdLuvGRDtwCTxMZRWCJiFenoC/sqHrGN/eDlDuDA7GTh+HxwTUl9pKG4bYcQfr9 fpwjXQ4yu9q7THHH1CwE1exEpYe3jNGXmeNO0tPn5LkhZv2wFcAn8ADCCprYA0hSytHs= Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP gcc-6 warns about obviously wrong indentation for newly added code in aac_slave_configure(): drivers/scsi/aacraid/linit.c: In function 'aac_slave_configure': drivers/scsi/aacraid/linit.c:458:3: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation] sdev->tagged_supported = 1; ^~~~ drivers/scsi/aacraid/linit.c:455:4: note: ...this 'else' clause, but it is not gcc is correct, and evidently this was meant to be within the curly braces that should have been there to start with. This patch adds them, which avoids the warning and makes it clear what was intended here. Nothing changes in behavior because in the 'if' block, the sdev->tagged_supported flag is known to be set already. Signed-off-by: Arnd Bergmann Fixes: 6bf3b630d0a7 ("aacraid: SCSI blk tag support") Reviewed-by: Raghava Aditya Renukunta < raghavaaditya.renukunta@pmcs.com > --- drivers/scsi/aacraid/linit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index 21a67ed047e8..ff6caab8cc8b 100644 --- a/drivers/scsi/aacraid/linit.c +++ b/drivers/scsi/aacraid/linit.c @@ -452,10 +452,11 @@ static int aac_slave_configure(struct scsi_device *sdev) else if (depth < 2) depth = 2; scsi_change_queue_depth(sdev, depth); - } else + } else { scsi_change_queue_depth(sdev, 1); sdev->tagged_supported = 1; + } return 0; }