| Message ID | 1459493857-4724-3-git-send-email-hare@suse.de (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 2016-04-01 08:57, Hannes Reinecke wrote: > VPD pages 0x0 and 0x83 are mandatory even for SPC-2, so we should > be lowering the restriction to avoid having to whitelist every > SPC-2 compliant device. > > Signed-off-by: Hannes Reinecke <hare@suse.com> Looks good, Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>> "Hannes" == Hannes Reinecke <hare@suse.de> writes:
Hannes> VPD pages 0x0 and 0x83 are mandatory even for SPC-2, so we
Hannes> should be lowering the restriction to avoid having to whitelist
Hannes> every SPC-2 compliant device.
Linus took patch 1/2 for 4.6rc3 so I have rebased 4.7/scsi-queue and
applied patch 2/2.
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index 1d4a329..40a789f 100644 --- a/include/scsi/scsi_device.h +++ b/include/scsi/scsi_device.h @@ -541,9 +541,9 @@ static inline int scsi_device_supports_vpd(struct scsi_device *sdev) /* * Although VPD inquiries can go to SCSI-2 type devices, * some USB ones crash on receiving them, and the pages - * we currently ask for are for SPC-3 and beyond + * we currently ask for are mandatory for SPC-2 and beyond */ - if (sdev->scsi_level > SCSI_SPC_2 && !sdev->skip_vpd_pages) + if (sdev->scsi_level >= SCSI_SPC_2 && !sdev->skip_vpd_pages) return 1; return 0; }
VPD pages 0x0 and 0x83 are mandatory even for SPC-2, so we should be lowering the restriction to avoid having to whitelist every SPC-2 compliant device. Signed-off-by: Hannes Reinecke <hare@suse.com> --- include/scsi/scsi_device.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)