diff mbox

megaraid_sas: trivial fix, add missing space in dev_err message

Message ID 1461621523-30162-1-git-send-email-colin.king@canonical.com (mailing list archive)
State Changes Requested, archived
Headers show

Commit Message

Colin King April 25, 2016, 9:58 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Add a missing space in dev_err message, missed because the string
spans a few lines.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Joe Perches April 26, 2016, 1:05 a.m. UTC | #1 
On Mon, 2016-04-25 at 22:58 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Add a missing space in dev_err message, missed because the string
> spans a few lines.

This is a dev_notice() not dev_err().

> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
[]
> @@ -3345,7 +3345,7 @@ megasas_internal_reset_defer_cmds(struct megasas_instance *instance)
>  			if (!list_empty(&cmd->list)) {
>  				dev_notice(&instance->pdev->dev, "ERROR while"
>  					" moving this cmd:%p, %d %p, it was"
> -					"discovered on some list?\n",
> +					" discovered on some list?\n",
>  					cmd, cmd->sync_cmd, cmd->scmd);
>  
>  				list_del_init(&cmd->list);

Better would be to coalesce the format, but perhaps
this dev_notice should be dev_err?

				dev_notice(&instance->pdev->dev,
					   "ERROR while moving this cmd:%p, %d %p, it was discovered on some list?\n",
					   cmd, cmd->sync_cmd, cmd->scmd);

And the message seems oddly phrased.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index e6ebc7a..1c038bc 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -3345,7 +3345,7 @@  megasas_internal_reset_defer_cmds(struct megasas_instance *instance)
 			if (!list_empty(&cmd->list)) {
 				dev_notice(&instance->pdev->dev, "ERROR while"
 					" moving this cmd:%p, %d %p, it was"
-					"discovered on some list?\n",
+					" discovered on some list?\n",
 					cmd, cmd->sync_cmd, cmd->scmd);
 
 				list_del_init(&cmd->list);