From patchwork Wed May 11 09:19:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: zengzhaoxiu@163.com X-Patchwork-Id: 9066331 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 98099BF29F for ; Wed, 11 May 2016 09:21:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B718F20154 for ; Wed, 11 May 2016 09:21:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D201B200DE for ; Wed, 11 May 2016 09:20:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932145AbcEKJUd (ORCPT ); Wed, 11 May 2016 05:20:33 -0400 Received: from m50-133.163.com ([123.125.50.133]:53034 "EHLO m50-133.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932071AbcEKJUb (ORCPT ); Wed, 11 May 2016 05:20:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=U/v5agsqI63z8SpXxH ief2x7ysOjBQTcprygl6sLI14=; b=lYMEROkyUb7SwWPEupXsxS0yP3n09IbqTP 266/lorZekJgbrW0Kd90MPHbgB8CqO2G3G0nzyA8u/Q5WP5kvlLHSpWhM5fnP1AB WBbpmm0NCvqKneQ8acwbF6bXst3nqznpHV3B+lP7ZoQuJxy9EJ+RTiaSH6oOv/Rd QL2LauGMo= Received: from zhaoxiuzeng-VirtualBox.spreadtrum.com (unknown [112.95.225.98]) by smtp3 (Coremail) with SMTP id DdGowACHDEE++TJXbXOIAA--.10967S2; Wed, 11 May 2016 17:20:03 +0800 (CST) From: zengzhaoxiu@163.com To: linux-kernel@vger.kernel.org Cc: Zhaoxiu Zeng , Intel SCU Linux support , Artur Paszkiewicz , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [patch V4 18/31] scsi: use parity32 in isci's phy Date: Wed, 11 May 2016 17:19:56 +0800 Message-Id: <1462958396-25400-1-git-send-email-zengzhaoxiu@163.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1462955158-28394-1-git-send-email-zengzhaoxiu@163.com> References: <1462955158-28394-1-git-send-email-zengzhaoxiu@163.com> X-CM-TRANSID: DdGowACHDEE++TJXbXOIAA--.10967S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7ArW5Xr4xJFWUJFW3GFWfKrg_yoW8JFW8pa 1fJ347Z3y8Wr17Zw1UJ3W8JF409ay8GFy3JrZxGas5ZFn7ArWj9r43A3yrXFyakry0gFW7 tFs5WF9rZFsIyrUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07ju89NUUUUU= X-Originating-IP: [112.95.225.98] X-CM-SenderInfo: p2hqw6xkdr5xrx6rljoofrz/1tbiJQNmgFUL-n-LcAAAsk Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Zhaoxiu Zeng Signed-off-by: Zhaoxiu Zeng --- drivers/scsi/isci/phy.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/scsi/isci/phy.c b/drivers/scsi/isci/phy.c index cb87b2e..a06aff6 100644 --- a/drivers/scsi/isci/phy.c +++ b/drivers/scsi/isci/phy.c @@ -122,8 +122,6 @@ sci_phy_link_layer_initialization(struct isci_phy *iphy, int phy_idx = iphy->phy_index; struct sci_phy_cap phy_cap; u32 phy_configuration; - u32 parity_check = 0; - u32 parity_count = 0; u32 llctl, link_rate; u32 clksm_value = 0; u32 sp_timeouts = 0; @@ -225,18 +223,7 @@ sci_phy_link_layer_initialization(struct isci_phy *iphy, /* The SAS specification indicates that the phy_capabilities that * are transmitted shall have an even parity. Calculate the parity. */ - parity_check = phy_cap.all; - while (parity_check != 0) { - if (parity_check & 0x1) - parity_count++; - parity_check >>= 1; - } - - /* If parity indicates there are an odd number of bits set, then - * set the parity bit to 1 in the phy capabilities. - */ - if ((parity_count % 2) != 0) - phy_cap.parity = 1; + phy_cap.parity = parity32(phy_cap.all); writel(phy_cap.all, &llr->phy_capabilities);