From patchwork Fri Jul 8 10:20:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sumit Saxena X-Patchwork-Id: 9220381 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 24E10607D9 for ; Fri, 8 Jul 2016 10:21:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 151492867B for ; Fri, 8 Jul 2016 10:21:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 079DE2867D; Fri, 8 Jul 2016 10:21:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CA4242867B for ; Fri, 8 Jul 2016 10:21:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754613AbcGHKUx (ORCPT ); Fri, 8 Jul 2016 06:20:53 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:34446 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754595AbcGHKUt (ORCPT ); Fri, 8 Jul 2016 06:20:49 -0400 Received: by mail-pa0-f45.google.com with SMTP id bz2so12676148pad.1 for ; Fri, 08 Jul 2016 03:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5Lo8YxpUvp7B1cQdCPPxwBVhl2FLRz0B8zuxg1tNVpo=; b=QmBblDFeRaWA/zdENOoKxr+u11Q/96UnC3YhpFTwXKjow5XKlGrQM+KgONJkvTfaA7 zdYOdC2m3OhzNh4oD9ti8sllp6ViiD3uPCntuKaf1oOTfUKiDPFd5uy3FvHvkh3Kqu8G gSLTJPHvWk9+9BRXk5tKSUIEZeeYyTMMot9tM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5Lo8YxpUvp7B1cQdCPPxwBVhl2FLRz0B8zuxg1tNVpo=; b=OEk6cx14zoryyUirVI9BGBJned7SYergN2oRLN+jDARBkJzdc4BiPI/xVNG501Dft9 DbMZAnfpxnGa8JIEjvVnd5Z7jRhbCA4EqtfWVOHJnWPStfszb+jgk+dCTnoLyb0YVaNZ VoX+tbVGOZpkMPMRO9w8cr2vroQxPmAnhYv/SMZnkhtsLZhxDTlx8eZhWXuIsPzBCCiz StxAZIuPmIL87GMzIChX0vNG/0pYtEN/+O0rI2GvPgp2seHagS00RBRc6J6E8dbWbc6L znTjnXE2FVT1qbv/gDN+EyysipVCwocWyLuMsHlboYizigoh7zcvbtH54PAjFNTrXY0a zlmA== X-Gm-Message-State: ALyK8tJm4To3O8e/ZYPh9JtdAt2df0mV22eM6s0Md48U5NhghvMEqUT9ZUdgOiBVxFcfEYCy X-Received: by 10.66.89.66 with SMTP id bm2mr8532127pab.154.1467973248446; Fri, 08 Jul 2016 03:20:48 -0700 (PDT) Received: from dhcp-135-24-192-142.localdomain ([192.19.239.250]) by smtp.gmail.com with ESMTPSA id z29sm3664040pff.0.2016.07.08.03.20.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Jul 2016 03:20:47 -0700 (PDT) From: Sumit Saxena To: James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, kashyap.desai@broadcom.com, lucz@geza.com, , Sumit Saxena Subject: [PATCH] Do not fire MR_DCMD_PD_LIST_QUERY to controllers which do not support it Date: Fri, 8 Jul 2016 03:20:32 -0700 Message-Id: <1467973232-17382-1-git-send-email-sumit.saxena@broadcom.com> X-Mailer: git-send-email 2.4.3 MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There was an issue reported by Lucz Geza on Dell Perc 6i. As per issue reported, driver goes into an infinite error reporting loop as soon as there is a change in the status of one of the arrays (degrade, resync online etc …). Below are the error logs reported continuously- Jun 25 08:49:30 ns8 kernel: [ 757.757017] megaraid_sas 0000:02:00.0: DCMD failed/not supported by firmware: megasas_get_pd_list 4115 Jun 25 08:49:30 ns8 kernel: [ 757.778017] megaraid_sas 0000:02:00.0: DCMD failed/not supported by firmware: megasas_get_pd_list 4115 Jun 25 08:49:30 ns8 kernel: [ 757.799017] megaraid_sas 0000:02:00.0: DCMD failed/not supported by firmware: megasas_get_pd_list 4115 Jun 25 08:49:30 ns8 kernel: [ 757.820018] megaraid_sas 0000:02:00.0: DCMD failed/not supported by firmware: megasas_get_pd_list 4115 Jun 25 08:49:30 ns8 kernel: [ 757.841018] megaraid_sas 0000:02:00.0: DCMD failed/not supported by firmware: megasas_get_pd_list 4115 This issue is very much specific to controllers which do not support DCMD- MR_DCMD_PD_LIST_QUERY. In case of any hotplugging/rescanning of drives, AEN thread will be scheduled by driver and fire DCMD- MR_DCMD_PD_LIST_QUERY and if this DCMD is failed then driver will fail this event processing and will not go ahead for further events. This will cause infinite loop of same event getting retried infinitely and causing above mentioned logs. Fix for this problem is: not to fire DCMD MR_DCMD_PD_LIST_QUERY for controllers which do not support it and send DCMD SUCCESS status to AEN function so that it can go ahead with other event processing. Reported-by: Lucz Geza Cc: Signed-off-by: Sumit Saxena --- drivers/scsi/megaraid/megaraid_sas_base.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index f4b0690..2dab3dc 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -4079,6 +4079,12 @@ megasas_get_pd_list(struct megasas_instance *instance) struct MR_PD_ADDRESS *pd_addr; dma_addr_t ci_h = 0; + if (instance->pd_list_not_supported) { + dev_info(&instance->pdev->dev, "MR_DCMD_PD_LIST_QUERY " + "not supported by firmware\n"); + return ret; + } + cmd = megasas_get_cmd(instance); if (!cmd) {