From patchwork Mon Jul 18 20:27:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Winkler, Tomas" X-Patchwork-Id: 9235231 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E05BC6075D for ; Mon, 18 Jul 2016 20:30:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CFDDD1FF65 for ; Mon, 18 Jul 2016 20:30:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C4B58205B0; Mon, 18 Jul 2016 20:30:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B9FF41FF65 for ; Mon, 18 Jul 2016 20:30:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752692AbcGRU3j (ORCPT ); Mon, 18 Jul 2016 16:29:39 -0400 Received: from mga03.intel.com ([134.134.136.65]:52416 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752663AbcGRU3h (ORCPT ); Mon, 18 Jul 2016 16:29:37 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 18 Jul 2016 13:29:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,385,1464678000"; d="scan'208";a="997766650" Received: from twinkler-lnx.jer.intel.com ([10.12.87.167]) by orsmga001.jf.intel.com with ESMTP; 18 Jul 2016 13:29:32 -0700 From: Tomas Winkler To: Greg Kroah-Hartman , Ulf Hansson , Adrian Hunter , James Bottomley , "Martin K. Petersen" , Vinayak Holikatti , Andy Lutomirski , =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Michael Ryleev , Joao Pinto , Christoph Hellwig , Yaniv Gardi Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org, Tomas Winkler Subject: [PATCH v5 3/8] char: rpmb: add device attributes Date: Mon, 18 Jul 2016 23:27:48 +0300 Message-Id: <1468873673-21776-4-git-send-email-tomas.winkler@intel.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1468873673-21776-1-git-send-email-tomas.winkler@intel.com> References: <1468873673-21776-1-git-send-email-tomas.winkler@intel.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add attribute type that displays underlay storage type technology EMMC, UFS, and attribute id, that displays underlay storage device id. For EMMC this would be content of CID and for UFS serial number from the device descriptor. Signed-off-by: Tomas Winkler --- V2: resend V3: set kernel version to 4.7 V4: update target date to Maj V5: adjust date and kernel version Documentation/ABI/testing/sysfs-class-rpmb | 24 ++++++++++++ drivers/char/rpmb/core.c | 63 ++++++++++++++++++++++++++++++ 2 files changed, 87 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-class-rpmb b/Documentation/ABI/testing/sysfs-class-rpmb index 3ffcd2d1f683..7ca97d86bd97 100644 --- a/Documentation/ABI/testing/sysfs-class-rpmb +++ b/Documentation/ABI/testing/sysfs-class-rpmb @@ -18,3 +18,27 @@ Contact: Tomas Winkler Description: The /sys/class/rpmb/rpmbN directory is created for each RPMB registered device + +What: /sys/class/rpmb/rpmbN/id +Date: Aug 2016 +KernelVersion: 4.8 +Contact: Tomas Winkler +Description: + The /sys/class/rpmb/rpmbN/id file contains device id + in a binary form + +What: /sys/class/rpmb/rpmbN/type +Date: Aug 2016 +KernelVersion: 4.8 +Contact: Tomas Winkler +Description: + The /sys/class/rpmb/rpmbN/type file contains device + underlay storage type technology: EMMC, UFS + +What: /sys/class/rpmb/rpmbN/reliable_wr_cnt +Date: Aug 2016 +KernelVersion: 4.8 +Contact: Tomas Winkler +Description: + The /sys/class/rpmb/rpmbN/reliable_wr_cnt file contains + number of blocks that can be written in a single request diff --git a/drivers/char/rpmb/core.c b/drivers/char/rpmb/core.c index ff10cbb7b644..63271c7ed072 100644 --- a/drivers/char/rpmb/core.c +++ b/drivers/char/rpmb/core.c @@ -308,6 +308,67 @@ struct rpmb_dev *rpmb_dev_find_by_device(struct device *parent) } EXPORT_SYMBOL_GPL(rpmb_dev_find_by_device); +static ssize_t type_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct rpmb_dev *rdev = to_rpmb_dev(dev); + ssize_t ret; + + switch (rdev->ops->type) { + case RPMB_TYPE_EMMC: + ret = scnprintf(buf, PAGE_SIZE, "EMMC\n"); + break; + case RPMB_TYPE_UFS: + ret = scnprintf(buf, PAGE_SIZE, "UFS\n"); + break; + default: + ret = scnprintf(buf, PAGE_SIZE, "UNKNOWN\n"); + break; + } + + return ret; +} +static DEVICE_ATTR_RO(type); + +static ssize_t id_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct rpmb_dev *rdev = to_rpmb_dev(dev); + size_t sz = min_t(size_t, rdev->ops->dev_id_len, PAGE_SIZE); + + if (!rdev->ops->dev_id) + return 0; + + memcpy(buf, rdev->ops->dev_id, sz); + return sz; +} +static DEVICE_ATTR_RO(id); + +static ssize_t reliable_wr_cnt_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct rpmb_dev *rdev = to_rpmb_dev(dev); + + return scnprintf(buf, PAGE_SIZE, "%u\n", rdev->ops->reliable_wr_cnt); +} +static DEVICE_ATTR_RO(reliable_wr_cnt); + +static struct attribute *rpmb_attrs[] = { + &dev_attr_type.attr, + &dev_attr_id.attr, + &dev_attr_reliable_wr_cnt.attr, + NULL, +}; + +static struct attribute_group rpmb_attr_group = { + .attrs = rpmb_attrs, +}; + +static const struct attribute_group *rpmb_attr_groups[] = { + &rpmb_attr_group, + NULL +}; + /** * rpmb_dev_unregister - unregister RPMB partition from the RPMB subsystem * @@ -377,6 +438,8 @@ struct rpmb_dev *rpmb_dev_register(struct device *dev, dev_set_name(&rdev->dev, "rpmb%d", id); rdev->dev.class = &rpmb_class; rdev->dev.parent = dev; + rdev->dev.groups = rpmb_attr_groups; + ret = device_register(&rdev->dev); if (ret) goto exit;