From patchwork Thu Jul 21 09:08:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jitendra Bhivare X-Patchwork-Id: 9241235 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3DCE160871 for ; Thu, 21 Jul 2016 09:09:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2D556206AF for ; Thu, 21 Jul 2016 09:09:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2239E26253; Thu, 21 Jul 2016 09:09:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B151427A98 for ; Thu, 21 Jul 2016 09:09:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905AbcGUJJw (ORCPT ); Thu, 21 Jul 2016 05:09:52 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:38850 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951AbcGUJJl (ORCPT ); Thu, 21 Jul 2016 05:09:41 -0400 Received: by mail-wm0-f51.google.com with SMTP id o80so16924927wme.1 for ; Thu, 21 Jul 2016 02:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xeOKpxXPYYTAi7GxsZ1rJmEqT9KylceNzA44ChNJg7g=; b=KR9c8A2eLc5kJu7EbND7ug8ASbiLrPyQIY/bA7B1AMPd9SKVnOZFGdzdiMrkJa7VTH LfbLVotn5fmX4lOyeU656mFszkvBcxUYopdVQzrvafPdr71iY/n/yvb1L7jJidYu61eC 39+Yl2JuxZTwh+CLS9IKJGqfnpEw5UtGL0mbM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xeOKpxXPYYTAi7GxsZ1rJmEqT9KylceNzA44ChNJg7g=; b=UuVMiNSTIxJRf/cAaLzQnfDuQGqOwzJJ1Iel89EM0d5OOxDla8zv09W4VwFGzqNqjP alpvzSrmMa7XOzS8I46pa/CuRGheab9OXGINSse6VDEP5bkFccbnAXdzdvm6GnSPgCqv StdbcgHM0525NiEsXELL2/CzEDokr8+1X0NHuxVglazmuTua7hTvfaURsN/0EvCJM55h nQaTjpHUCoULFhORaXpMr28tjCpeAihw5sr/nqi+IRCu+CbcUvW6DZH7GVKv4k2uz23r q6vL3k6hKMfGOvUId5BscjQyGwIwDK9E1KoQZ8+zCGKCiXuiqygOzIR+zH8TfXSXjPL+ SQNQ== X-Gm-Message-State: ALyK8tKwgRrEttesfMpmkV1g2uMJMIVeCpVwaN/aFPeY5HqqekhKJmy+rbpmtBLqy0xh++kC X-Received: by 10.28.193.8 with SMTP id r8mr470345wmf.13.1469092179766; Thu, 21 Jul 2016 02:09:39 -0700 (PDT) Received: from android.dhcp.avagotech.net ([192.19.239.250]) by smtp.gmail.com with ESMTPSA id f4sm2353184wmf.8.2016.07.21.02.09.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 21 Jul 2016 02:09:39 -0700 (PDT) From: Jitendra Bhivare To: linux-scsi@vger.kernel.org Cc: mchristi@redhat.com, Jitendra Bhivare Subject: [PATCH 24/28] be2iscsi: Add FUNCTION_RESET during driver unload Date: Thu, 21 Jul 2016 14:38:01 +0530 Message-Id: <1469092085-14311-25-git-send-email-jitendra.bhivare@broadcom.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1469092085-14311-1-git-send-email-jitendra.bhivare@broadcom.com> References: <1469092085-14311-1-git-send-email-jitendra.bhivare@broadcom.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Driver unload should call COMMON_FUNCTION_RESET. For TPE feature, this ensures that FW has knowledge about driver getting unloaded and can reset its bit vector. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_cmds.c | 2 +- drivers/scsi/be2iscsi/be_cmds.h | 2 ++ drivers/scsi/be2iscsi/be_main.c | 3 +++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c index ad7405d..5fe1610 100644 --- a/drivers/scsi/be2iscsi/be_cmds.c +++ b/drivers/scsi/be2iscsi/be_cmds.c @@ -1595,7 +1595,7 @@ int beiscsi_check_fw_rdy(struct beiscsi_hba *phba) return rdy; } -static int beiscsi_cmd_function_reset(struct beiscsi_hba *phba) +int beiscsi_cmd_function_reset(struct beiscsi_hba *phba) { struct be_ctrl_info *ctrl = &phba->ctrl; struct be_mcc_wrb *wrb = wrb_from_mbox(&ctrl->mbox_mem); diff --git a/drivers/scsi/be2iscsi/be_cmds.h b/drivers/scsi/be2iscsi/be_cmds.h index 26d7921..8283344 100644 --- a/drivers/scsi/be2iscsi/be_cmds.h +++ b/drivers/scsi/be2iscsi/be_cmds.h @@ -762,6 +762,8 @@ struct be_cmd_set_features { } param; } __packed; +int beiscsi_cmd_function_reset(struct beiscsi_hba *phba); + int beiscsi_cmd_special_wrb(struct be_ctrl_info *ctrl, u32 load); int beiscsi_check_fw_rdy(struct beiscsi_hba *phba); diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 29d5291..1cc155b 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -3780,9 +3780,12 @@ static void hwi_cleanup_port(struct beiscsi_hba *phba) beiscsi_cmd_q_destroy(ctrl, q, QTYPE_EQ); } } + /* this ensures complete FW cleanup */ + beiscsi_cmd_function_reset(phba); /* last communication, indicate driver is unloading */ beiscsi_cmd_special_wrb(&phba->ctrl, 0); } + static int hwi_init_port(struct beiscsi_hba *phba) { struct hwi_controller *phwi_ctrlr;