From patchwork Mon Aug 15 14:25:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Bottomley X-Patchwork-Id: 9281059 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7C9EF600CB for ; Mon, 15 Aug 2016 14:26:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6DCB628CCA for ; Mon, 15 Aug 2016 14:26:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6214628CF7; Mon, 15 Aug 2016 14:26:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 01DE828CCA for ; Mon, 15 Aug 2016 14:26:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753022AbcHOO0L (ORCPT ); Mon, 15 Aug 2016 10:26:11 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:7659 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752488AbcHOO0D (ORCPT ); Mon, 15 Aug 2016 10:26:03 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u7FEJbmK004221 for ; Mon, 15 Aug 2016 10:26:02 -0400 Received: from e18.ny.us.ibm.com (e18.ny.us.ibm.com [129.33.205.208]) by mx0b-001b2d01.pphosted.com with ESMTP id 24tgxrwecv-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 15 Aug 2016 10:26:02 -0400 Received: from localhost by e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 15 Aug 2016 10:26:01 -0400 Received: from d01dlp02.pok.ibm.com (9.56.250.167) by e18.ny.us.ibm.com (146.89.104.205) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 15 Aug 2016 10:25:58 -0400 X-IBM-Helo: d01dlp02.pok.ibm.com X-IBM-MailFrom: jejb@linux.vnet.ibm.com Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id E30036E8047; Mon, 15 Aug 2016 10:25:36 -0400 (EDT) Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u7FEPt9A60424330; Mon, 15 Aug 2016 14:25:59 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 465E3124047; Mon, 15 Aug 2016 10:25:57 -0400 (EDT) Received: from [153.66.254.194] (unknown [9.80.237.228]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTPS id 00C6D124014; Mon, 15 Aug 2016 10:25:55 -0400 (EDT) Subject: Re: [PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas_attached From: James Bottomley To: kbuild test robot , Johannes Thumshirn Cc: kbuild-all@01.org, "Martin K . Petersen" , Hannes Reinecke , Linux Kernel Mailinglist , Linux SCSI Mailinglist , stable@vger.kernel.org, #@suse.de, v4.5+@suse.de Date: Mon, 15 Aug 2016 07:25:53 -0700 In-Reply-To: <201608152258.TcR75AwO%fengguang.wu@intel.com> References: <201608152258.TcR75AwO%fengguang.wu@intel.com> X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16081514-0044-0000-0000-000000EAE2A6 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005598; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000181; SDB=6.00744983; UDB=6.00351046; IPR=6.00517536; BA=6.00004662; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012338; XFM=3.00000011; UTC=2016-08-15 14:26:00 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16081514-0045-0000-0000-000005012927 Message-Id: <1471271153.2428.5.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-08-15_05:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608150159 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, 2016-08-15 at 22:11 +0800, kbuild test robot wrote: > Hi Johannes, > > [auto build test ERROR on scsi/for-next] > [also build test ERROR on v4.8-rc2 next-20160815] > [if your patch is applied to the wrong git tree, please drop us a > note to help improve the system] This is happening because scsi_is_sas_rphy wasn't designed to be used outside the SAS transport class, so it's failing when the ATTRs aren't defined. This is the way you fix it (needs to be a precursor patch to 1/2): James --- -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/scsi/scsi_transport_sas.h b/include/scsi/scsi_transport_sas.h index 13c0b2b..0e1c50e 100644 --- a/include/scsi/scsi_transport_sas.h +++ b/include/scsi/scsi_transport_sas.h @@ -15,8 +15,13 @@ static inline int is_sas_attached(struct scsi_device *sdev) { return 0; } +static inline int scsi_is_sas_rphy(const struct device *) +{ + return 0; +} #else extern int is_sas_attached(struct scsi_device *sdev); +extern int scsi_is_sas_rphy(const struct device *); #endif static inline int sas_protocol_ata(enum sas_protocol proto) @@ -202,7 +207,6 @@ extern int sas_rphy_add(struct sas_rphy *); extern void sas_rphy_remove(struct sas_rphy *); extern void sas_rphy_delete(struct sas_rphy *); extern void sas_rphy_unlink(struct sas_rphy *); -extern int scsi_is_sas_rphy(const struct device *); struct sas_port *sas_port_alloc(struct device *, int); struct sas_port *sas_port_alloc_num(struct device *);