| Message ID | 1471768105-14730-1-git-send-email-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
>>>>> "Christophe" == Christophe JAILLET <christophe.jaillet@wanadoo.fr> writes:
Christophe> The 2nd parameter of 'find_first_bit' is the number of bits
Christophe> to search. In this case, we are passing 'sizeof(unsigned
Christophe> long)' which is likely to be 4.
Kashyap? Sumit?
>-----Original Message----- >From: Christophe JAILLET [mailto:christophe.jaillet@wanadoo.fr] >Sent: Sunday, August 21, 2016 1:58 PM >To: kashyap.desai@avagotech.com; sumit.saxena@avagotech.com; >uday.lingala@avagotech.com; jejb@linux.vnet.ibm.com; >martin.petersen@oracle.com >Cc: megaraidlinux.pdl@avagotech.com; linux-scsi@vger.kernel.org; linux- >kernel@vger.kernel.org; kernel-janitors@vger.kernel.org; Christophe JAILLET >Subject: [PATCH] megaraid_sas: Fix the search of first memory bar > >The 2nd parameter of 'find_first_bit' is the number of bits to search. >In this case, we are passing 'sizeof(unsigned long)' which is likely to be >4. > >It is likely that the number of bits in a long was expected here, so use >BITS_PER_LONG instead. > >Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> >--- >Other options are possible: > - 'bar_list' being a 'unsigned long', use __ffs to reduce code verbosity > - PCI_NUM_RESOURCES, which is the maximum number of bits that can be set > by 'pci_select_bars()' >--- > drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c >b/drivers/scsi/megaraid/megaraid_sas_base.c >index c1ed25adb17e..7d3de811d33c 100644 >--- a/drivers/scsi/megaraid/megaraid_sas_base.c >+++ b/drivers/scsi/megaraid/megaraid_sas_base.c >@@ -5036,7 +5036,7 @@ static int megasas_init_fw(struct megasas_instance >*instance) > > /* Find first memory bar */ > bar_list = pci_select_bars(instance->pdev, IORESOURCE_MEM); >- instance->bar = find_first_bit(&bar_list, sizeof(unsigned long)); >+ instance->bar = find_first_bit(&bar_list, BITS_PER_LONG); > if (pci_request_selected_regions(instance->pdev, 1<<instance->bar, > "megasas: LSI")) { > dev_printk(KERN_DEBUG, &instance->pdev->dev, "IO memory >region busy!\n"); Acked by: Sumit Saxena <sumit.saxena@broadcom.com> >-- >2.7.4 > > >--- >L'absence de virus dans ce courrier électronique a été vérifiée par le >logiciel >antivirus Avast. >https://www.avast.com/antivirus -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>> "Christophe" == Christophe JAILLET <christophe.jaillet@wanadoo.fr> writes:
Christophe> The 2nd parameter of 'find_first_bit' is the number of bits
Christophe> to search. In this case, we are passing 'sizeof(unsigned
Christophe> long)' which is likely to be 4.
Christophe> It is likely that the number of bits in a long was expected
Christophe> here, so use BITS_PER_LONG instead.
Applied to 4.9/scsi-queue.
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index c1ed25adb17e..7d3de811d33c 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -5036,7 +5036,7 @@ static int megasas_init_fw(struct megasas_instance *instance) /* Find first memory bar */ bar_list = pci_select_bars(instance->pdev, IORESOURCE_MEM); - instance->bar = find_first_bit(&bar_list, sizeof(unsigned long)); + instance->bar = find_first_bit(&bar_list, BITS_PER_LONG); if (pci_request_selected_regions(instance->pdev, 1<<instance->bar, "megasas: LSI")) { dev_printk(KERN_DEBUG, &instance->pdev->dev, "IO memory region busy!\n");
The 2nd parameter of 'find_first_bit' is the number of bits to search. In this case, we are passing 'sizeof(unsigned long)' which is likely to be 4. It is likely that the number of bits in a long was expected here, so use BITS_PER_LONG instead. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Other options are possible: - 'bar_list' being a 'unsigned long', use __ffs to reduce code verbosity - PCI_NUM_RESOURCES, which is the maximum number of bits that can be set by 'pci_select_bars()' --- drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)