Message ID | 1472036754-156813-7-git-send-email-john.garry@huawei.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers | show |
On 08/24/2016 01:05 PM, John Garry wrote: > When the port is detached we cannot execute a TMF, > as there can be no device attached to the port. > > Signed-off-by: John Garry <john.garry@huawei.com> > --- > drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c > index 280a19d..73f581f 100644 > --- a/drivers/scsi/hisi_sas/hisi_sas_main.c > +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c > @@ -204,7 +204,7 @@ static int hisi_sas_task_prep(struct sas_task *task, struct hisi_hba *hisi_hba, > return rc; > } > port = device->port->lldd_port; > - if (port && !port->port_attached && !tmf) { > + if (port && !port->port_attached) { > if (sas_protocol_ata(task->task_proto)) { > struct task_status_struct *ts = &task->task_status; > > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c index 280a19d..73f581f 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_main.c +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c @@ -204,7 +204,7 @@ static int hisi_sas_task_prep(struct sas_task *task, struct hisi_hba *hisi_hba, return rc; } port = device->port->lldd_port; - if (port && !port->port_attached && !tmf) { + if (port && !port->port_attached) { if (sas_protocol_ata(task->task_proto)) { struct task_status_struct *ts = &task->task_status;
When the port is detached we cannot execute a TMF, as there can be no device attached to the port. Signed-off-by: John Garry <john.garry@huawei.com> --- drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)