diff mbox

SCSI: remove one useless stack variable

Message ID 1476113133-24092-1-git-send-email-tom.leiming@gmail.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Ming Lei Oct. 10, 2016, 3:25 p.m. UTC
The local variable of 'devname' in scsi_report_lun_scan()
isn't used any more, so remove it.

Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
 drivers/scsi/scsi_scan.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Christoph Hellwig Oct. 10, 2016, 4:51 p.m. UTC | #1
On Mon, Oct 10, 2016 at 11:25:33PM +0800, Ming Lei wrote:
> The local variable of 'devname' in scsi_report_lun_scan()
> isn't used any more, so remove it.

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Martin K. Petersen Oct. 11, 2016, 10:02 p.m. UTC | #2
>>>>> "Ming" == Ming Lei <tom.leiming@gmail.com> writes:

Ming> The local variable of 'devname' in scsi_report_lun_scan() isn't
Ming> used any more, so remove it.

Applied to 4.9/scsi-fixes.
diff mbox

Patch

diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index bb9b58e21d95..6f7128f49c30 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -1307,7 +1307,6 @@  static void scsi_sequential_lun_scan(struct scsi_target *starget,
 static int scsi_report_lun_scan(struct scsi_target *starget, int bflags,
 				enum scsi_scan_mode rescan)
 {
-	char devname[64];
 	unsigned char scsi_cmd[MAX_COMMAND_SIZE];
 	unsigned int length;
 	u64 lun;
@@ -1349,9 +1348,6 @@  static int scsi_report_lun_scan(struct scsi_target *starget, int bflags,
 		}
 	}
 
-	sprintf(devname, "host %d channel %d id %d",
-		shost->host_no, sdev->channel, sdev->id);
-
 	/*
 	 * Allocate enough to hold the header (the same size as one scsi_lun)
 	 * plus the number of luns we are requesting.  511 was the default