From patchwork Mon Oct 17 10:24:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Saxena X-Patchwork-Id: 9378891 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 24A5E60780 for ; Mon, 17 Oct 2016 10:24:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 170712912D for ; Mon, 17 Oct 2016 10:24:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0B75A29132; Mon, 17 Oct 2016 10:24:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D5052912D for ; Mon, 17 Oct 2016 10:24:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934285AbcJQKY0 (ORCPT ); Mon, 17 Oct 2016 06:24:26 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:33890 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933510AbcJQKYZ (ORCPT ); Mon, 17 Oct 2016 06:24:25 -0400 Received: by mail-pa0-f50.google.com with SMTP id rz1so62500488pab.1 for ; Mon, 17 Oct 2016 03:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=05O+JgIl/BAMCgF6nY4MukWlXe2OMgRYHl1rzOc7AaY=; b=fp0TpjCwVPyM8RZhaxecC/BNoXDDiqor+q1qrcl1KImw6hsC76q4px4z1vi8DnEqa1 K+qwuiADTmW1vRAc+Rm7jI1GM9jJMZDOivmm6r4FD6TFhqzT6qHDzJKD6F8gqNmVlhPy u6u+Ut+l6pfFSkJSt2Gd9e94bqvLxc4HK8qqM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=05O+JgIl/BAMCgF6nY4MukWlXe2OMgRYHl1rzOc7AaY=; b=MYL4ePMy3tiGL9S602FQp4TbQ5UUcV1iJZAF+ZtVv+2M7+5nQxGoJut7OKQjDUArBI m+kH/keMxY8KQoFezYaSBDj28rbpf8IqRDRqOp25mLHlvUnm4TrjunXT+/ThSF6882Fn XM5QXDt1i5YBYWJDWnUz8gbPO9Zs6XoCsJfVYfvoUCVum6zp5dupxoOwEvyJOYZgVg+K gT8BCnX7lextrnR1EL0CTyOkS4hJc+YWIYGDYIQkaCur7wfo/scMj9aTLsmWTQYowUEV mQQ7Bu0RWmY6/Kpi/ahlmA93IHIxJ3n8MyCgmAl+VPmouNcegYt1xjZ8MebDYW8r2GKC wFtA== X-Gm-Message-State: AA6/9RmCHULQIUtJho88bfkgQSqUKl+sYyMQhv1497exUesHeyS+mH/oeQr32XngMQZ9mYgs X-Received: by 10.66.159.200 with SMTP id xe8mr30666415pab.21.1476699864198; Mon, 17 Oct 2016 03:24:24 -0700 (PDT) Received: from dhcp-135-24-192-142.localdomain ([192.19.239.250]) by smtp.gmail.com with ESMTPSA id dj3sm36203777pad.1.2016.10.17.03.24.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Oct 2016 03:24:23 -0700 (PDT) From: Sumit Saxena To: linux-scsi@vger.kernel.org Cc: martin.petersen@oracle.com, thenzl@redhat.com, jejb@linux.vnet.ibm.com, kashyap.desai@broadcom.com, Sumit Saxena , stable@vger.kernel.org, Kiran Kumar Kasturi Subject: [PATCH 1/7] megaraid_sas: For SRIOV enabled firmware, ensure VF driver waits for 30secs before reset Date: Mon, 17 Oct 2016 03:24:04 -0700 Message-Id: <1476699850-25083-2-git-send-email-sumit.saxena@broadcom.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1476699850-25083-1-git-send-email-sumit.saxena@broadcom.com> References: <1476699850-25083-1-git-send-email-sumit.saxena@broadcom.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP For SRIOV enabled firmware, if there is a OCR(online controller reset) possibility driver set the convert flag to 1, which is not happening if there are outstanding commands even after 180 seconds. As driver does not set convert flag to 1 and still making the OCR to run, VF(Virtual function) driver is directly writing on to the register instead of waiting for 30 seconds. Setting convert flag to 1 will cause VF driver will wait for 30 secs before going for reset. CC: stable@vger.kernel.org Signed-off-by: Kiran Kumar Kasturi Signed-off-by: Sumit Saxena Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index 52d8bbf..61be7ed 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -2823,6 +2823,7 @@ int megasas_wait_for_outstanding_fusion(struct megasas_instance *instance, dev_err(&instance->pdev->dev, "pending commands remain after waiting, " "will reset adapter scsi%d.\n", instance->host->host_no); + *convert = 1; retval = 1; } out: