From patchwork Tue Oct 18 04:49:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Gautam X-Patchwork-Id: 9381267 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 91F3C600CA for ; Tue, 18 Oct 2016 04:50:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 804EF291F2 for ; Tue, 18 Oct 2016 04:50:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 71B7129232; Tue, 18 Oct 2016 04:50:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 01BEF291F2 for ; Tue, 18 Oct 2016 04:50:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757655AbcJREth (ORCPT ); Tue, 18 Oct 2016 00:49:37 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35952 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754912AbcJREtX (ORCPT ); Tue, 18 Oct 2016 00:49:23 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E3C4361822; Tue, 18 Oct 2016 04:49:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1476766162; bh=H6zvccWP8FmYT8fatdA7eZdBsyVYlFZjzfLT67Cl/WA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fRpRE/9zSneNZ/KB7gXOcoXRQeJXVBSL9NNjoHcWFxqH/Dvn2vqn2b+p/qU8pu0bu e5JUOPIcF2dNhEE9SV5ki0BYkqwRwKhc8JHwhcr1L4WybWgmhB3xsHcy0Cq+Ya/M7s UUBBz7HQG90wJ7i2Vjov5cz8nYepA24/bwBGSSjI= Received: from blr-ubuntu-41.ap.qualcomm.com (unknown [202.46.23.61]) (using TLSv1.1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: vivek.gautam@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7A03D61814; Tue, 18 Oct 2016 04:49:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1476766162; bh=H6zvccWP8FmYT8fatdA7eZdBsyVYlFZjzfLT67Cl/WA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fRpRE/9zSneNZ/KB7gXOcoXRQeJXVBSL9NNjoHcWFxqH/Dvn2vqn2b+p/qU8pu0bu e5JUOPIcF2dNhEE9SV5ki0BYkqwRwKhc8JHwhcr1L4WybWgmhB3xsHcy0Cq+Ya/M7s UUBBz7HQG90wJ7i2Vjov5cz8nYepA24/bwBGSSjI= DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 7A03D61814 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=vivek.gautam@codeaurora.org From: Vivek Gautam To: kishon@ti.com, jejb@linux.vnet.ibm.com, vinholikatti@gmail.com, martin.petersen@oracle.com, linux-kernel@vger.kernel.org Cc: subhashj@codeaurora.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, Vivek Gautam Subject: [PATCH 2/7] phy: qcom-ufs: Remove unnecessary BUG_ON Date: Tue, 18 Oct 2016 10:19:00 +0530 Message-Id: <1476766145-27583-3-git-send-email-vivek.gautam@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1476766145-27583-1-git-send-email-vivek.gautam@codeaurora.org> References: <1476766145-27583-1-git-send-email-vivek.gautam@codeaurora.org> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP BUG_ON() are not preferred in the driver, plus the variable on which BUG_ON is asserted is already checked in the code before passing. Signed-off-by: Vivek Gautam Reviewed-by: Subhash Jadavani --- drivers/phy/phy-qcom-ufs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c index 183ec04..805c91d 100644 --- a/drivers/phy/phy-qcom-ufs.c +++ b/drivers/phy/phy-qcom-ufs.c @@ -335,8 +335,6 @@ int ufs_qcom_phy_cfg_vreg(struct phy *phy, struct ufs_qcom_phy *ufs_qcom_phy = get_ufs_qcom_phy(phy); struct device *dev = ufs_qcom_phy->dev; - BUG_ON(!vreg); - if (regulator_count_voltages(reg) > 0) { min_uV = on ? vreg->min_uV : 0; ret = regulator_set_voltage(reg, min_uV, vreg->max_uV);