From patchwork Thu Oct 20 09:05:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Saxena X-Patchwork-Id: 9386355 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 23542607F0 for ; Thu, 20 Oct 2016 09:05:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 12F0529B11 for ; Thu, 20 Oct 2016 09:05:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 07C4429B5C; Thu, 20 Oct 2016 09:05:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A6B9729B11 for ; Thu, 20 Oct 2016 09:05:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755218AbcJTJFX (ORCPT ); Thu, 20 Oct 2016 05:05:23 -0400 Received: from mail-pf0-f171.google.com ([209.85.192.171]:33819 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752711AbcJTJFV (ORCPT ); Thu, 20 Oct 2016 05:05:21 -0400 Received: by mail-pf0-f171.google.com with SMTP id r16so32856810pfg.1 for ; Thu, 20 Oct 2016 02:05:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8OY0Gg7Wg7CasCxnBj/KtbTVxyTMzHUS52/LxV3fXdI=; b=CuCs8z9hYBfDeOklzkUIrrEiCUkRu1yQiHipKJY2vcbYRNDG8MR9eiWEUQWXYsqm7w j9OMpvTMD0X5UA04T4KNhEwqBCqJXzMVVBWEjZTM8X+AswfpwuDC8yI+koZlNBBZOXhI FAcnLzkT4inXoDcyIwUon80xWsmh04f82NZv0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8OY0Gg7Wg7CasCxnBj/KtbTVxyTMzHUS52/LxV3fXdI=; b=lgAK3UNjro4i0R+Oyk81H4Q30UN58kxfnZ6S9tQ4EPPkyUflVRinxQFxuJaZyXdjHG RqadIWagbjEXmFQ6Jr3FbR6eyPVrBsx/RN8lT1fiRexSY3nhZGW8mlFoZ29ZwXd54RZO uShq6JgcVCSh5/VSAXpuZEg+KcNWibM/luqKq/qPEXKIlefm9nw17cmvJ97Hfzhkos2P 7kDwwOHiqnBZDSF5xbqpHvo3wASob6lWsT6l5tNZ2qlP5WIthLVjZ4Yaq2UIl/JkHXP0 ibeXPm6S0iC81YbXXyQ8QJ47cYk1no3XdF6/+Adl0fvcQry4bfNt7pCF5C/LnlNbThkJ I/QQ== X-Gm-Message-State: AA6/9RlMgCdV0EKLw9O3rJc36s6v7/YUqyY/thhpRQDm//Xh/EKtZAhurQ3R1DNB4wuykbaZ X-Received: by 10.98.64.76 with SMTP id n73mr19455298pfa.33.1476954320342; Thu, 20 Oct 2016 02:05:20 -0700 (PDT) Received: from dhcp-135-24-192-142.localdomain ([192.19.239.250]) by smtp.gmail.com with ESMTPSA id 136sm69738199pfu.87.2016.10.20.02.05.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Oct 2016 02:05:19 -0700 (PDT) From: Sumit Saxena To: linux-scsi@vger.kernel.org Cc: martin.petersen@oracle.com, thenzl@redhat.com, jejb@linux.vnet.ibm.com, kashyap.desai@broadcom.com, Sumit Saxena , Kiran Kumar Kasturi Subject: [PATCH v2 2/7] megaraid_sas: Send correct PhysArm to FW for R1 VD downgrade Date: Thu, 20 Oct 2016 02:05:00 -0700 Message-Id: <1476954305-576-3-git-send-email-sumit.saxena@broadcom.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1476954305-576-1-git-send-email-sumit.saxena@broadcom.com> References: <1476954305-576-1-git-send-email-sumit.saxena@broadcom.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes the issue of wrong PhysArm was sent to firmware for R1 VD downgrade. Signed-off-by: Kiran Kumar Kasturi Signed-off-by: Sumit Saxena Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_fp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c b/drivers/scsi/megaraid/megaraid_sas_fp.c index e413113..f237d00 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fp.c +++ b/drivers/scsi/megaraid/megaraid_sas_fp.c @@ -782,7 +782,8 @@ static u8 mr_spanset_get_phy_params(struct megasas_instance *instance, u32 ld, (raid->regTypeReqOnRead != REGION_TYPE_UNUSED)))) pRAID_Context->regLockFlags = REGION_TYPE_EXCLUSIVE; else if (raid->level == 1) { - pd = MR_ArPdGet(arRef, physArm + 1, map); + physArm = physArm + 1; + pd = MR_ArPdGet(arRef, physArm, map); if (pd != MR_PD_INVALID) *pDevHandle = MR_PdDevHandleGet(pd, map); } @@ -879,7 +880,8 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow, pRAID_Context->regLockFlags = REGION_TYPE_EXCLUSIVE; else if (raid->level == 1) { /* Get alternate Pd. */ - pd = MR_ArPdGet(arRef, physArm + 1, map); + physArm = physArm + 1; + pd = MR_ArPdGet(arRef, physArm, map); if (pd != MR_PD_INVALID) /* Get dev handle from Pd */ *pDevHandle = MR_PdDevHandleGet(pd, map);