From patchwork Tue Dec 6 20:30:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9463237 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0BCA760236 for ; Tue, 6 Dec 2016 20:31:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F36ED284CD for ; Tue, 6 Dec 2016 20:31:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E854A284DE; Tue, 6 Dec 2016 20:31:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7CFD1284CD for ; Tue, 6 Dec 2016 20:31:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752640AbcLFUbf (ORCPT ); Tue, 6 Dec 2016 15:31:35 -0500 Received: from mail-by2nam03on0085.outbound.protection.outlook.com ([104.47.42.85]:40736 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752492AbcLFUbW (ORCPT ); Tue, 6 Dec 2016 15:31:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DyTl5KiYexDmOkSZLkQBg78rVhuIHmbylLzJwwCvMWE=; b=Iv9Hu4E781HBSFCPOR/zrbE9FtAqc82P/fuicLbpKL/8C6YcARWcZphCbyM3/sU21XvtY++PFLMdqx9NQXTJKLtlvcc+Psa0SocOfMj7QCq3e7gUxdhnoiCgBtwdYHsPfNrvroMsG+S1ZVQQuam5gdqGjtk6RHDPv6MOljBvTYc= Received: from SN1PR0701CA0014.namprd07.prod.outlook.com (10.162.96.24) by BN1PR07MB200.namprd07.prod.outlook.com (10.242.216.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.761.9; Tue, 6 Dec 2016 20:31:19 +0000 Received: from BN1BFFO11FD018.protection.gbl (2a01:111:f400:7c10::1:121) by SN1PR0701CA0014.outlook.office365.com (2a01:111:e400:5173::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.761.9 via Frontend Transport; Tue, 6 Dec 2016 20:31:19 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1BFFO11FD018.mail.protection.outlook.com (10.58.144.81) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.734.4 via Frontend Transport; Tue, 6 Dec 2016 20:31:19 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:; UpperCasedChecksum:; SizeAsReceived:1149; Count:15 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.309.2; Tue, 6 Dec 2016 12:30:54 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id uB6KUsug002391; Tue, 6 Dec 2016 12:30:54 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id uB6KUsjI002390; Tue, 6 Dec 2016 12:30:54 -0800 From: Himanshu Madhani To: , CC: , , Subject: [PATCH 13/22] qla2xxx: Fix invalid handle erroneous message. Date: Tue, 6 Dec 2016 12:30:42 -0800 Message-ID: <1481056251-2310-14-git-send-email-himanshu.madhani@cavium.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1481056251-2310-1-git-send-email-himanshu.madhani@cavium.com> References: <1481056251-2310-1-git-send-email-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-IncomingHeaderCount: 15 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(428002)(189002)(199003)(50986999)(76176999)(101416001)(356003)(81156014)(81166006)(8676002)(33646002)(36756003)(8936002)(50226002)(50466002)(42186005)(48376002)(39850400001)(92566002)(39840400001)(39450400002)(39410400001)(106466001)(105586002)(38730400001)(5001770100001)(5003940100001)(15650500001)(4001430100002)(305945005)(2906002)(4326007)(189998001)(6666003)(80596001)(107886002)(626004)(2950100002)(5660300001)(4720700003)(86362001)(47776003)(7846002)(69596002)(87636001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN1PR07MB200; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD018; 1:K2PngDjkJyzArqQImsjAC9KFo+DxreuynDut8UN7qS0Km6isPHRju4cpxRnRnDgwTVGA2oLIvED9EnqhdGdC8O5NIwUOT+hOofDp4ZOZXSYNAEQi8YZAWwdyRXvTAxvqjGP7rlI3E9bUX/UZ+g0puHGF9I63W4wfg5i5ZJPBMRZPUVeksC/gUUSc38H5ichXe64Ji5mE/DG+B9OKu40ih3Xs0SFgHbkcNBIBCCWbzXluWWDPG77Af5gfp/7aXvUhUJtB1VkSfVctX2i7Gy6rdaJxLl7+fvPai2Z67S5SaGiKz5sZlQt9kBXXXvsTq2RsAcenmmepkpS5FQYMfUhwD49RMHkE6odwjNLra/PS03R5IOgK/1BKJqfgIHigiRxAP+hTI4I8LBXCVxBLeTH/NMJfky6I2kxGLOkOsghcFQz30KcGVbfofUcgWLQkFY+JuBeIBKe5fU4y8iqQIqTHXDX8TZ1Ag2ursfcVox7TjpZNgzFc02WMSGn+ABtLQheC4pE3+FxfWb9CuoDZde6UOQ== X-MS-Office365-Filtering-Correlation-Id: 858d1555-4bb3-474b-ed39-08d41e16d61a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BN1PR07MB200; X-Microsoft-Exchange-Diagnostics: 1; BN1PR07MB200; 3:eKS1Z0m3eVfEIXLse4yOtO/jYkd2eVbBgbLVBTGDCHI2kjbsmyr56L+sJdQiMZJewh0eDq1BunLwLVa/3qECPq70GKHSVW+/62F3uRp61MsMezu944itJdngPR6TD+KcTbRL1hItVpKnzXVwjq7oiktBLW6cxSHUCNWWqdpE439SK5G8Z25KgMuQWyZlSX5g5rt0knt47HKlvicptEXR221L7nBOTugO2VD3z3lydzRtUrBj0IelACMs8n2jJ9oG9M2KhtgyxlAwB+NrJq0g4TBLpZuNwAlbsKBzrlSaXwTeydo6hbX9mU/aHM8qoueRc70oPdw066MY1Ao6hb1LaI091D/i+RD74U9NrgfW6Po=; 25:RyGvSPwmWSv78BLb9KhHshvsh0ZkU8+rPPT/wZva0zLaBSzXej5pxGkSEEjLsF9wG/9ljv2rrLWoa4kU+CVT4Ttz7gEvBWHcGxnmLC3OgzmIFQzkqagEnFlqdLXRbEIp8SDbB9ZnKCKntYmF8A6kS5o3yBoCI2WDNnI0B41Gs/zscENlkwPPtVC+zLdZwD+dv9T24Eo1vny1xIaw0fHCqnt6jGctygVugE6BwuOAflRBuu50/HA8XFTDRmR6TeIgIWq3tvfJPMcuPbNuqjnvnpdDaW2jLgUXyyM2bQgH6PNBrgRZkC7xbeqqEs6EMd3L73svD5K69EYshQkQMUqPTRIs5kK06yGQbAa3TJQLdbbMM8DyF7EHDqlpanvjcS7i9lzN27GIVUTsUeEsA3En9STK9OpI3G7cMIDnFygRnF5rmXXAhMkheevgLqvV64PtAPpeAc71hCls11ByhX/ypw== X-Microsoft-Exchange-Diagnostics: 1; BN1PR07MB200; 31:DguUiNh836nch9b69VYMltFyzqDVytdEzSHPvJNBg7UZY5tv1fgDFJSwEHHUsIO1gdXC23+c10qy5xnPSXbt+ti53SkzXXBOn4uiIBjhQgZv9U9Y/zteBMb//iUN103QkElUIo/2WVRhBcJBwyGPzzB/3+9eE/8tOeodJnOM10DrtxBnNEuObDZ4nWbEEHURvz/Rel9zsFju1iJjPscS+0wkmNlBCATyzVN3FHyXw7852MflnxufNPC78wPKIQWntuv6LKkyuT6Wdgkf2GVnWQ==; 20:rZchm17SQIsRl7Yypro5hGBBNPXjcW/1CV2FrmlgdHytdjEZgqjCzrWsLTRYWpjPTXxGuFICLMdDwDxQ7SdHQmoO9n09t/l7xYEQg/ZpKABFVSE8kS84y3lT8/TUd5aqqZ9QWeJErOC9vrEYOEnbMKlbeNszRdZFuCxmuTIdQ/uBbfleWGC2b4P4a+79xs6VSiqJsxZBvpV1oto60zem+ygWGsSFBg9nKC/DkDQ5suYLLqNSb1TSuhMW5L2glMlzgb3hedmyHbj6UsKA6aGNrzn6nF0Sw38nXHjOkKRKHXwNt4uwIVfyyks2MOOBeYe8ydHN72f3nAsJYJ7MzgaanzNmjblNRh4jN6p1k0PQ1mEpyFDXZ6juSZdjiw4PQTYF795fMAeoAWGFCqezEIJtr8/6/WXyUv/Wco0nbqFUHBC4EUqOH0hmWrM0gb/KxDgy+54OcUWP6kGwr0fq+leqFzEo79T1llZco4AKy66+L6EPjZ+BKf7epuvRpm5yxakq X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(13024025)(13023025)(13017025)(13015025)(13018025)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(20161123558021)(6072148); SRVR:BN1PR07MB200; BCL:0; PCL:0; RULEID:; SRVR:BN1PR07MB200; X-Microsoft-Exchange-Diagnostics: 1; BN1PR07MB200; 4:NGbjjreXwmTnHK1K4sRaWnm7LugelK+Vz+GHnOJk3ZPVXMk+BSDtGJfpwJ4d3e4/ulEjaTf39L2k2u9NI+AnP6ToET4oBWR+RIQ31XJVy4OESLN3OIMK0hh+zUBhStnC7tbjE/NYkytiipAz18NtNiWzquZWONO98Z52NIYD+iS+PmPCJb1gnzUlVRa4mplTS2T1UNE9otUf2ulGE/b44IfjYTVz+mKVwoiTsOruiCY01rs2GNz7PvDfzdllsYGM3zqFUgBUZBwfB7Nln6Dj6g0sw9saRsoTwwq3K0fbcO5nAM8ylL2nJT1iUEu5Cx721+EcAJ9lBn83KD8c9jEV94KIHoCRnfOaMjtF2TeIh5+FrrfgLqOc3+TZqojohv1B5zkAoKddurjINmq+XRtcwEd/I4b2tD6FkJKwOsIfy4AHR0bPmzVPYVtyH7qyT6kN28KmBWH5WzVBlavF+KblS/7XKMsimOBGH0HzKDcwbZ0aUejanT7QAPXF+X2lwbc0RwAH0uXWlIKImyJY5AfBUfTXojQXmwoxn/5OeSCCFMQ/3rs2Hsr/68UwqiIo1NPg6D37oxQGsPC4Ryd3JEi7ij2KImvkiSNo/KPIbQi8wGfCfG1CTHC4CoqLz3br8qCXz4KfhPP4sKSvdXwrDm6AJKsXfdB/a0guMbueUmizCMH3tvUUs5OjdzyEQ8EEb0o2dKaYFreCF/W5J97AeY2nlw== X-Forefront-PRVS: 01480965DA X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN1PR07MB200; 23:biXdUdsvBljIe8uUT5J0le8BZEeooA5jFdHXURV0mH?= =?us-ascii?Q?2SQ5fjFXPgZau+Y1hi1xil/aZlbpY+HmbjGpcmtwByXrEoN96fT95Ssfz3M2?= =?us-ascii?Q?j2qz+lUEMbl7wDzsdvXn8UeMhidDtibtFMrHIHK4VrVyXcv0JkvPzKTzwQE3?= =?us-ascii?Q?YIudH1lMQL0fTiBFqqzLK+YGpzhdftgyppZQ7FJnIwSrZOVlw8/tQ8Mzjopo?= =?us-ascii?Q?l5yGQNMKMbFS/Zs20oi5KuHwhYa8C6JyC9J5Xm4yomBSZ/1vVUZjTRykN+tu?= =?us-ascii?Q?qB+3H9thxHc48drNjwdvaV20JiG3QIX0FVa9nJOKKXlK7tYjMr6ZHu0caD6s?= =?us-ascii?Q?xDGhNYqVUcsVIXOFSQS1Y5fvPJsOXpRNeJ4Fw6XBnykseQB8pY4pgZ1fqF2s?= =?us-ascii?Q?ZchUiuWcyojc1wCVOrFQTOTDr+7d2nJ/WmKBfVDBH+FBz8Lw1er1ZHSfep5y?= =?us-ascii?Q?lCIJEo3m4jRMiBOyAYgzO6wS5Tn8f4Sm5TbBm+qqX2JVX9rT2HKofPP3amYY?= =?us-ascii?Q?2bhxQx/9fZpdGkgbkHlwEXIhQgqUjRxv5yoEGE9B3r+CjZQjovQ0GT+X+c6H?= =?us-ascii?Q?4XNJu6IDg3YA0KMplaXDJD92ZxI4bkdlo4gr6SKAsIuWjCy7rzT93TFFJuje?= =?us-ascii?Q?nu3HdtwxBNjr30mu6lt9+7TCSXaatIKqqmnUV7pwhu81gFxWxUbDmTNRMGlb?= =?us-ascii?Q?rb4r5R653FWXNTSDLPCKPBhoWx4YtWXIMDAaPBOe+9Phahdo2kbFbJEV6vDW?= =?us-ascii?Q?xVFnLdQrdGmKgFMbK/bU7c1mgzdocFuzn2eb+xZMbB9tTS30Ptq96RJ/W0Os?= =?us-ascii?Q?iXLU7vheFcMVIRgM0HGJIr08EJm/Y4WIhE7CpxwWd1Ftss8Lu0LZ4c2molyn?= =?us-ascii?Q?Kw3jxAtRZQGv9gyDyOIDjLlw5+CwQ836YfsUljfSvO+7ZpiwGH0YNcuzZ1ma?= =?us-ascii?Q?BdkAq6+hi5w85l9cHhEYFaRUycBPheqei/H1k4GIr7u8dR2dfO9xgQN5JC1N?= =?us-ascii?Q?Q/GLwvAXVFVQdjcvmu5KdWyo0C5YtDNQxKMLz/zc3HAEBgPEvLROOn9QQcGK?= =?us-ascii?Q?GNJoEP3ZJTnhVdRhZyz+HxzPOFMS1/xCrZ+gtoD1QQQmsGRNB510faBjZHuo?= =?us-ascii?Q?RlIx08Y/IjlJeEKthYz8vfSzJkrJTrbgj3J+cKz5s3MpNRtEYoO9Ysv8Nvrl?= =?us-ascii?Q?eFIkcgbh32TbBYu2hyexOiABnp2AD6up+/?= X-Microsoft-Exchange-Diagnostics: 1; BN1PR07MB200; 6:/1AIiozwt1v+edpvJ/cmc3v3KUzkiPvqkHNRSNjE9pQVp7J4OV4TnxS5ufMZr2I3zTOpNzZFA14zkhQ0uLrVd0v2wUYbya+4PJKVyXGLbuKdCtw/8g1dG3IN4AEKHXWS0CPGtnR6ecWTJEIzmubGfbFswVbPKKxsSOtF8swN8AkXWNUsTaykraGpDy8s1o6qswLbkXB5tx9stK0FUvjGmSFlti9Uzrho4O4zQgdOxvKGexL9pvBo0uYHCS7YTIl100K7AoEyPyhVd31mm5Nl2APUFdWYEXevu2e4vEuAZ18C+llYadH+LE/i1tbEgqk2sGYO5E2RsUX6xDN3rR8NSrMETTuUCcnmASCISY0RJJWIljyrgrKmvym8fOhmrAe2WqQxgZQf1vn66vkgmAdcKpjjJ+2ilWuxMShNZvLGv7Y=; 5:BwPwHsu3auC3ESr9uXvwGG6iTUM5UUm7ev4sVfgq4x5tzMAZFl0lnws0uRWoPuLlZGIpV0U/wm8pfW4t+eWClMLTyK5Uw8Eiwhd8T9Mo4d2yY3Wa6jM7sFv+fmgk8QYVL9SiYwOoJCLe+JAfX2+jGQ==; 24:WazsviixI6BKbE1MJEp1kWdh0OHVLQAbIGl4kmwTzsNKsG9PEtVTRh56IOAJiwv4UXkvJyOfRPrmKNdQm8l76RUm3RFFK4Ut7/h21g80v0U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN1PR07MB200; 7:jB+5l564MRFswAQF7C7SM3K4/Ns5w4DW/G6GMsvbcxbjfZ8ZVw6XcCj8F8fiWwc7J1KIJz8NLgZBhGAgAkxXajlD38qXn6HTSKILsC9cu2gSkk7Rh7qEXV2wL53rYEU+kImTUDJDmiUdjQGz3NCG/d4JDQkyzlx3g7k9R5WzzbY4FOVSn/4ERVb5kj9drB6Zhn2+5KcSjEFHAA8hUubHsMJNjwi9CSvhMUTWVn9NbJDRoDX+pNPtyWZQrcgegmbRnCcUVeibKUB8A7WfOzJP/cmknVObCFYx0PzcndmjHITKYMB31OGSGInP+DOmdl0VZJOw/gladCoAXKnoVb6n0ItYaNQhyU2AZzuhsM7Mhn4g9n3ZChSklEKk/Yi08NW7nS5mAfzYZRenahwDdBVhIJKTnHHnjOqOkfVSrddOqi+fH4ncm5dIjNIlAoXqIW1Y2k8vRC4OUdIkBfESMFao8g== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2016 20:31:19.2697 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR07MB200 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran Termination of Immediate Notification IOCB was using wrong IOCB handle. IOCB completion code was unable to find appropriate code path due to wrong handle. Following message is seen in the logs. "Error entry - invalid handle/queue (ffff)." Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_isr.c | 9 +++++++++ drivers/scsi/qla2xxx/qla_target.c | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index 04899f4..c7f73b1 100644 --- a/drivers/scsi/qla2xxx/qla_isr.c +++ b/drivers/scsi/qla2xxx/qla_isr.c @@ -2630,6 +2630,15 @@ struct scsi_dif_tuple { if (pkt->entry_status & RF_BUSY) res = DID_BUS_BUSY << 16; + if ((pkt->entry_type == NOTIFY_ACK_TYPE) && + (pkt->handle == QLA_TGT_SKIP_HANDLE)) { + /* There are some NACK that uses the SP method and + * some are not using the SP method of sending. filter + * NACK here to prevent erroneous err. + */ + return; + } + sp = qla2x00_get_sp_from_handle(vha, func, req, pkt); if (sp) { sp->done(vha, sp, res); diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 8ccbd74..e6b2a45 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -3344,7 +3344,7 @@ static int __qlt_send_term_imm_notif(struct scsi_qla_host *vha, pkt->entry_type = NOTIFY_ACK_TYPE; pkt->entry_count = 1; - pkt->handle = QLA_TGT_SKIP_HANDLE | CTIO_COMPLETION_HANDLE_MARK; + pkt->handle = QLA_TGT_SKIP_HANDLE; nack = (struct nack_to_isp *)pkt; nack->ox_id = ntfy->ox_id;