From patchwork Sun Dec 18 09:02:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9479239 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 53A5E60830 for ; Sun, 18 Dec 2016 09:03:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 413412845B for ; Sun, 18 Dec 2016 09:03:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 356CB2847D; Sun, 18 Dec 2016 09:03:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A8B202845B for ; Sun, 18 Dec 2016 09:03:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759890AbcLRJDr (ORCPT ); Sun, 18 Dec 2016 04:03:47 -0500 Received: from mail-by2nam03on0076.outbound.protection.outlook.com ([104.47.42.76]:19872 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759748AbcLRJDp (ORCPT ); Sun, 18 Dec 2016 04:03:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ou0/fXI4q9eK3msJV9ZsLSn7alv6mYHDowAvnQ2+RF8=; b=aensDSowqz8UV0GNGFQ67Xh7m1PfAVZMLdeE/g/whjR/YyODDRVgZJMnOleuCRlBj4y9dxyym3n0QNoa4U2AdpZeklswXaVjX2LWpcX2vNCS/DFszbegbrKBYqe2Qk/c6NYLAuFEUGOmMvBA3tO9tKLh28h/yx9FE4IsyXggRk8= Received: from MWHPR07CA0037.namprd07.prod.outlook.com (10.169.230.23) by BLUPR0701MB2083.namprd07.prod.outlook.com (10.163.122.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Sun, 18 Dec 2016 09:03:42 +0000 Received: from BN1BFFO11FD038.protection.gbl (2a01:111:f400:7c10::1:189) by MWHPR07CA0037.outlook.office365.com (2603:10b6:300:1c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14 via Frontend Transport; Sun, 18 Dec 2016 09:03:41 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; linux-iscsi.org; dkim=none (message not signed) header.d=none; linux-iscsi.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1BFFO11FD038.mail.protection.outlook.com (10.58.144.101) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.789.10 via Frontend Transport; Sun, 18 Dec 2016 09:03:41 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.309.2; Sun, 18 Dec 2016 01:03:19 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id uBI935oD022994; Sun, 18 Dec 2016 01:03:05 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id uBI9351Z022993; Sun, 18 Dec 2016 01:03:05 -0800 From: Himanshu Madhani To: , , , CC: , , Subject: [PATCH 6/9] qla2xxx: Remove direct access of scsi_status field in se_cmd Date: Sun, 18 Dec 2016 01:02:46 -0800 Message-ID: <1482051769-22941-7-git-send-email-himanshu.madhani@cavium.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1482051769-22941-1-git-send-email-himanshu.madhani@cavium.com> References: <1482051769-22941-1-git-send-email-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(2980300002)(428002)(189002)(199003)(76176999)(50986999)(5660300001)(4001430100002)(2906002)(4326007)(626004)(4720700003)(101416001)(92566002)(6666003)(2950100002)(47776003)(189998001)(107886002)(5001770100001)(356003)(38730400001)(33646002)(39060400001)(106466001)(305945005)(105586002)(50226002)(5003940100001)(42186005)(81156014)(8676002)(36756003)(8936002)(81166006)(86362001)(48376002)(50466002)(80596001)(69596002)(2201001)(87636001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB2083; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD038; 1:FqUPXjDsY4xddIG2T4J9zWGMPDDQNW+EG7AbWU/OJCQ1Ci/vviveWdUaexuFjpntuUszqu/4RdniixdeJ8PHns7QA7zYSIuNUy1q2zUsDDtuih7Af1dqS52gqaR06mAj+jlAUl4j9jmMm0u2zTMBflLVTVZa+QKubPXJlm2rheNrW+Gkyt0f/c82s50ELpwZVLUdxfOoWA5mpznDaHAwZTesyQY/ALmxuUofpULdIp9crIl/vl60tYGH47i69YSZwbGe90EY1yxQb7rBt7sHJqXbmXrU0rrHIfhYpE8UDkCBw8Vipt8q+2C/Do0dNQWNNVHoXGizw5Y4XyPai1oSmMsZOXiXwbD8RcEeMUZW4js3xqsgLxf82fFmhhOH/61I6zP9WWdeMuHccv7Ts7VCeqUu5j8XELwgNU00NwM0AjUsFECCogfquc1y/zjyfURZ1FdVM9hgglZBuVACg+wEQNyQxhUjkDZwnwHOMKFCqxyLni6/t6TKFuEaVAKiEz5/6T+Bo8XYGY0c7iAehYFVuCmY5MGkgEDjddNk3+wF2MrAaRd6DCT25Du5C3b+kWPG X-MS-Office365-Filtering-Correlation-Id: 7508e079-f1d8-47f5-4b48-08d42724c348 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR0701MB2083; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2083; 3:9nrMPbsOSattudD0LXnon9p+7c08hd6Cbw4A1cf/HIFjltYyxxR1+6zfPx+vhqVUXiEd4+uy73sadRCWclfFyujAjwkl6uSncUyp+uH9HAK6M4xlww924S6UbLfIQVuKgTTpSOW2i+SbtYFounLDeD+ZKF1nZcU3eMX36RxenKf9VETW4Arq4Nh5cP7A5/jLQjPL8s2pGliar4o/HT3T6OIPh1F8zw/Y3TKADWF+gBRwnrckswRf2wbREALwsYo0N5E73vb74WDmATWO+6ngJxGmdq1p413GxF1W3eD3avHVKq1gseENDEYRRVs0yRpmDKq2APc9h2v/6Q4aNlHIpphO0L69D9FQrs4W2vuukqi1vZTdiTWRFVwYdXF5i5Ez; 25:BiJQkG6I4AJwulk7HHkMavLa0EqshzM+hTMjkEBOFPydIroT7Oxm5zkUrWGGsUKs20M8mUoT4mbqagv+NIlzwBFUFN4OjidJPXl4wXkommoy9tAA4CaJPwWJPw/3TSAY1+eQxJGmfh4wzGFylus1LEPG/DHpN1sRfaCl3gvdWkyFeQOZKR5JvwjnIbG1ZmY56xa6S2stNkLnUZhyR7nHHTL3ATv84Ex4NAjS2Xi0WCJZaQi+MFJIIUqAAetH8mPR9nJuEK1TjxGqz1PugGBD8nthJ8xiz2w49DDBQFf7phaJUJHxyTLHCEWuGmkndOmQwmtqwC8j5xOe49zxNSYDH+lR8iYk6qKUotGGob8zQH+tTqozAZdJgG5MvXynRXEQv8x/8U3gB6X9QqiLnu9jWiZY2iedu43pK+QjzkG/EfODaQacrq/8CwmWudE/tYVqjBaqg1yjFAG0g+lWus1qHQ== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2083; 31:hlRsC8gJfZ9/tTHRFXmjaaTu5nVACOvekEGmj2wsoICExsXpe3InK4Xxw0tMLKcbvL0NoTOdJ5ManGSrl/7TmdTbgLo1p5QcWx8mdq+913Q0TB+319Bb64NoP6g0gvNrSdZ4YtCEn8gi6btsvlpoWVCA5YIzGuXVU2N2vIR7Dfl3k20l1bS4Avm2TNfP+uHGafj1yvsuN0bIg6vWBNgcLfTHmeao3bAsIIC9QuQbwEEmiTNuFZQIYAT/fOF5UR4Tw0OkBrOKbwebJpzgZp5xyo9iykkYMvaGvFY0fvYLoAY=; 20:MRIfJmZmxnXCntUoYTXg+Ubx1Zsgp6soHnbl79UCvg/cHtfn0L10gFDF2d99r1z9LT9Oe1r44gyZ9rEkGp/oiwV+gF9QQxwAbkbCi8/1312oQI9NJDALGlw/lQQ1gCG2ZBMbQwyJb/xAix5WiZGWa/g73LD8mHMQ6/XnmLu+6AH497xGeF3JoCtdsnfpa6ff6UhofP7bgPJjY/Mk3a+0DRdv600R+bdyx1xWuC9fP5nHovYqsneHCuS4WXEIm5ftaRKfmW3gwneW/+6y1gJAWiQ0cc4sx2zy5G3amEOBfXaoVw4Y9pfNrBV/QewOOip9bWkGCoYrBjvpI2/5U3DOflFnsS+i5Lkid0IBvuFothnm3uTxB803W/zV2vBf1dZ/Ih1Z2nMdAgIftdX/E4VbSZXkM8Z0HsbpwGc1jzMvE86cUd2Lv0u1pQfmK1WGI1Y2L2YWW7pComifonZlG7ZuF2ZXJPIuoHnar30cfrRy285wcAKy8zq2De68w4UZBjoe X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(13023025)(13015025)(13018025)(13024025)(13017025)(10201501046)(3002001)(6041248)(20161123560025)(20161123555025)(20161123558021)(20161123564025)(20161123562025)(6072148); SRVR:BLUPR0701MB2083; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB2083; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2083; 4:UgUHaNycSEBb2QJoXERDrxK9zFTqr//yDCwdohCkgixaKclU6Othg0on+L/btP0jNAW7SFNoLssgexH/N+UACvgF8G4xL4UjwcTpqegvPRvOejcBAoIJN28JapX8UFZub2KQj++yWWHBZAUUgBCliPNCYOJpE8dPfC3/ooe14Jkj+r7+Mm/KgXrui8HDjsshehjCnKzGZqO9IB0UrqX/aAzfETh1XXp3HprCIlz+DbZAV52ruwLJS1Q/2uHw8DsZHuIXP2OJAGg6iyafFdrIH27ecugrOS7x04bKsArWappgNzeA8f7tmOx/05xMdLgWhejpop2f8U1RQS+MXlKVsgnrghvnP2oF+Y4EkArAHpFEVSYo3HRiNhv9R0sm7ZHc4N2iSrrJvNteRb3TrgEQacEMW4ptSt8Z3gW6PbqHnBJikgjD8zFRCb1CbS+TdNWEZzip/wsO/lne6DI8OxviBSmUNgyxn9aekvpmH8dbuJM9pgOlFi2VsUuaChyiYVFKZHVaAa7EQOqvfKWl1ZUDUAp+TApIs5ZcTtkAeXFKQXecxVvJtUBiTtQjIod2hWqEhkIGWfhA1Yyv75YRoA6mcU/w6x6EumSuxwGpn5/xubXyPcbV26S5c3HvVKKUbdgrrRvXUnYM8LRfRiqrR17Y+i9JaVDyXTxMnoI9rmn3Z3gnyc6fxP228EV9cHCd/9q+K8cuFXUAdjTkLjnSwwr0ag== X-Forefront-PRVS: 01604FB62B X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB2083; 23:qNrCaAS2iUsRBjcLpcpPA0Vr2DBo+noxfRGGDA/?= =?us-ascii?Q?xuDS9zmrMoIW0XawP6h4V52LbOO2qlPtGtBKueo8NWRK3EUCOKwgPE28wZhg?= =?us-ascii?Q?Olr+92V3lOzSJFyr6Z2UI1jHWvXBh2PSLHrJpz2gSNFYjvNQUMf8fAZ8ZJ5p?= =?us-ascii?Q?fodt4gudjkqTDQnRsXOYMjaQDDC1bNoFyKxgGJsUxIWV7U2z5n6BmJvwEjFu?= =?us-ascii?Q?FdY8LaUwHHJd/1VzgkdtEAHL06lc0CVMbkqS3fC/bi/f+jzTqSA/JD1NFcYF?= =?us-ascii?Q?IyuKgCByzcGuPsr1wVkIl1k3Tl5hBmAiQNPfTIFU97EME99cbN2aEk6fujdW?= =?us-ascii?Q?OWIJxQKjMbwrmHZc/8s1JZNeex3w/6Li11MBmm//TU2BTr5yDfqMEaildP/r?= =?us-ascii?Q?SMtUdEEK9wbqwf4pjinHAJ5e8cErbjuqipaO9KyEaq24k/UxclSKa+vd9FvK?= =?us-ascii?Q?lM9P3u8h3JUE06YzFM73fodTWaw2xsXhmqgwjz2MBgZwbAPccs1WGU/iI/O2?= =?us-ascii?Q?N0PaP7CXEFNGYxRizGsaCyLwp16e4HJ8p9buxUYiJWwxswTpHURoDQWHOS15?= =?us-ascii?Q?fdo/7KkqNuccPdF978Ka6gbCxnshz/FkIRZRkfsYnY8SZLHqyZ4RkiD6zbnu?= =?us-ascii?Q?rYqIfANZ2K/GocnlmGN9jgNwNemoxVGtPmtlmx1OkNPhWbvwwmSF7JPkUYup?= =?us-ascii?Q?ezA2drkaq5DuYI9gJGq6X2zk62BKT9fLa25bLQW5pbo3iQtOUqTjuucPIyPF?= =?us-ascii?Q?VelWsPLJLXHzWI6RZhAy23c2AQwmy0z2yaWObVcxvQkOM+O7nM2dHxngps1W?= =?us-ascii?Q?YLKKyrBRgZVga//YwpF9pPNlnmlRMnLd9GGcNeSlBnWdD17kbMpATFgW2joD?= =?us-ascii?Q?VZDxjNeZJyYhIrRIo7YlA/ib5BLjSUiTJ341Y2QuZcJwhOuftJPv7vTs361t?= =?us-ascii?Q?3fvGO8gU1UQ8SZptT+u/5IL/pE0zjXGuFbwWNzoHk00LBGU7Iulkxzbkf8g1?= =?us-ascii?Q?ED7EA9wpj5mN+RuegplL5eQm1T7iYIpP9N2IbV0xBtQ0LytU7WwGEoSbVIt4?= =?us-ascii?Q?YA78ZillTGm6/djUJ8EJDjI+iIWPuusHGFCuS87n8fHh6UFt2bqLQn2QP34o?= =?us-ascii?Q?ofUbqkQaZ170=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2083; 6:yVaLjxe9AnJ7loH5+i3JxVgkT439JyV0PbagbXED7bfqpgScqmy7YHkwF2V79LNlfrbhJRzr51mvOrgq1qPDiXJdO5rGs8e5SfJtmHUP2M5t20gqi6HPxbzgs3eGG4YJUkywwNC1sWSvHa61nzSgbsAv1+k/13thC1DMDkTS7JR4Lg8hWtxKXlsa2tWogUGMpeBx3zs5hMjgydx+TZPcfMiuINdNo5D8ZIw4IXUVU40PqYSouw+Aw5RvyiF5AzpnDaFOxv+3Fff0NNPhJHgXEqc/UkJN+ZAnCwH4qmpYjzSX2dRLEan+CJ4AeaXMB9VOKzVBdjJSWz/advVPOS+3E4B2uXgMqHfh7T4oDiU/Uj+YWAmOZyZwq5QgaIGMa/smFPAA+QA7mHvK9IqT6EYlgZbWm0iZJ1q3AMZWoimS57I=; 5:f/cSsXZO222hWDMJqG7WYErJeXWpNP2J0JBjp1CYxJP+/aCr+8NyoDHRN23zHAm+J1tFCye4q+IaGDixnS5BN/eJ5xu31E+WNZMaf6hwZH0sv8SCV/Hi9IE3T5dOas6hz4TP2Fho80pfwV5y0voVlA==; 24:5GVytKK9Aa4MLmfDB1WpE5+LT3TvThNOM20SE5xwthaZlAZg4EdY/+pelmZtWI3rvPHbYU/cj3NwzngLjlp1RfYI6y2UEa6/faDfJzuADY4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2083; 7:D+EsnwvvxW5q5AoK3UVLEstJA9D/p5kaFYQSNPN8Et1iW7O5DVgukk4bnkV3qEY+O1U98MLHufJXwS7msCL+j1NBKaII4UXqy2+qrjUNanz9uddId4bKh/rZ2mFAP2K+eUqUAw6zAXOGra3r3nSeaHs0A9WX2HJOofdbCGnjOmY9+wp0QZzTZ9F5SjZrbkNNArFI/I8wkAkSbWMn+DIcZg/o5FuSVeJjKmMZNcOiPcqfObCqnnIumvKiVJeEFgJ3k8PWA38vLUo8HqANCAJsEPUBHpzn4TJaniN3rpg7FJStJh+rl5/9LvbVR7K1b4hY/CiX5v58nLEOG69yoisYKeaYHucBaQEbZkuyCO+2gviXkv1LgYplEtmE1A/mAb6MGLYAzavK+NXPi6l+uR1RPgruA4H2qcB8Z+hxr6n8JAsqetT5LptGXsCGR7L4KK62bwULfsC+Dqiv7qAX0RNVZA== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2016 09:03:41.1251 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB2083 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Reviewed-by: Christoph Hellwig --- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_target.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h index f7df01b..1f9d2b9 100644 --- a/drivers/scsi/qla2xxx/qla_def.h +++ b/drivers/scsi/qla2xxx/qla_def.h @@ -1793,6 +1793,7 @@ struct crc_context { #define SS_RESIDUAL_OVER BIT_10 #define SS_SENSE_LEN_VALID BIT_9 #define SS_RESPONSE_INFO_LEN_VALID BIT_8 +#define SS_SCSI_STATUS_BYTE 0xff #define SS_RESERVE_CONFLICT (BIT_4 | BIT_3) #define SS_BUSY_CONDITION BIT_3 diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 20f1b50..1690794 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -2277,7 +2277,7 @@ static void qlt_24xx_init_ctio_to_isp(struct ctio7_to_24xx *ctio, int i; if (qlt_need_explicit_conf(prm->tgt->ha, prm->cmd, 1)) { - if (prm->cmd->se_cmd.scsi_status != 0) { + if ((prm->rq_result & SS_SCSI_STATUS_BYTE) != 0) { ql_dbg(ql_dbg_tgt, prm->cmd->vha, 0xe017, "Skipping EXPLICIT_CONFORM and " "CTIO7_FLAGS_CONFORM_REQ for FCP READ w/ "