From patchwork Tue Dec 20 04:33:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9481073 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7796E60237 for ; Tue, 20 Dec 2016 04:33:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 68EA627DC2 for ; Tue, 20 Dec 2016 04:33:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5939A284A9; Tue, 20 Dec 2016 04:33:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 01ED027DC2 for ; Tue, 20 Dec 2016 04:33:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754831AbcLTEdy (ORCPT ); Mon, 19 Dec 2016 23:33:54 -0500 Received: from mail-dm3nam03on0088.outbound.protection.outlook.com ([104.47.41.88]:45183 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751432AbcLTEdw (ORCPT ); Mon, 19 Dec 2016 23:33:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=aa/HtM8WN0LRiNkUDiWHx4qZMvpjctmQpG7gxcgYBNE=; b=gFFvALmZ1xUABvVdaz+n94LMqts7wAohlcndCMEfRTONbSh3GnwFWgq+qHZZfuWKkP2Qgg2jeJUzrte0uFFJImwnta0kkagTxSDnO29ZrH9jNtql+78BqmSGloQhxBx5vtFKjNaQ+k8HIm4Rmhcf4RSmmCb/uES6/m0gEZEc1Hk= Received: from BY2PR07CA0087.namprd07.prod.outlook.com (10.166.107.40) by BY2PR07MB025.namprd07.prod.outlook.com (10.255.241.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Tue, 20 Dec 2016 04:33:48 +0000 Received: from BN1BFFO11FD046.protection.gbl (2a01:111:f400:7c10::1:170) by BY2PR07CA0087.outlook.office365.com (2a01:111:e400:7bff::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14 via Frontend Transport; Tue, 20 Dec 2016 04:33:48 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; linux-iscsi.org; dkim=none (message not signed) header.d=none; linux-iscsi.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1BFFO11FD046.mail.protection.outlook.com (10.58.145.1) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.789.10 via Frontend Transport; Tue, 20 Dec 2016 04:33:47 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.309.2; Mon, 19 Dec 2016 20:33:45 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id uBK4XjOn012391; Mon, 19 Dec 2016 20:33:45 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id uBK4Xj6n012390; Mon, 19 Dec 2016 20:33:45 -0800 From: Himanshu Madhani To: , , , CC: , , Subject: [PATCH 01/10] qla2xxx: Fix wrong IOCB type assumption. Date: Mon, 19 Dec 2016 20:33:35 -0800 Message-ID: <1482208424-12358-2-git-send-email-himanshu.madhani@cavium.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1482208424-12358-1-git-send-email-himanshu.madhani@cavium.com> References: <1482208424-12358-1-git-send-email-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:CAL; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(2980300002)(428002)(189002)(199003)(50986999)(81156014)(2906002)(80596001)(38730400001)(4720700003)(5003940100001)(6666003)(105586002)(5001770100001)(305945005)(2950100002)(48376002)(69596002)(8676002)(106466001)(42186005)(50466002)(626004)(107886002)(356003)(76176999)(4326007)(81166006)(92566002)(101416001)(86362001)(50226002)(26826002)(36756003)(47776003)(33646002)(5660300001)(4001430100002)(2201001)(8936002)(189998001)(39060400001)(87636001)(266194004); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR07MB025; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD046; 1:RnqCR4PGEgYL7DII6FPflC0j1C5XXXkMC/z8Lf11icdOASj2RYIZf4EOXOYLMpTdM2WSOvCmrSNFSuvTUECNUcLDcbabtjIfFa0sdMK/SboFU1IPTAMzEwELKzS8mcIThjrX4G6EiNQJ0X0vZ4/fIPRdIeiEQtwAwD3EyO04WYHEKhDF6VF/LzVePnplJWiwfA3amlO1goWU4FyllnA47rVaiiv80FxoXsT5u0O+koPOHIvEMGmEsLMlOludUJUhUbirp0ChwiCKHw/BsR6MN82qltMWnLgF4oscL4N5oXo8vbBQ07qANC5FNAdF/S2uUVgpbWQB8/c0DR+7VSGrXQ8ZhjQWHlaaGGd0o3wjeikDISdAc5mO4+cLfyu1cKNUG2a+iO+5yqqmTqxvvep+Jy7RnSy78H+r7YQ9FgE/cOH/3q3g61vAO86dzNo3/HoE4BqycZOzRXok1dbh1KytCOx1Cyr0M3G/ufS7eiLSgBf7/ixCxJbAL02tGDn2HDJLaZrLhAAxFT2ZwpFCjLN70w== X-MS-Office365-Filtering-Correlation-Id: fd9375aa-cfd0-49af-8634-08d428916425 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY2PR07MB025; X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB025; 3:r+6tLL9savFdvjNouxKUyRs01qiHytHMN9gIHGGD7MBRfSgn62gzW+wZ0R7JTqh0FzQBd8iLNuhmPrOeXFZ4Cp1yRfZ2t+WpEhuTCxdWj49Df8dpZpd6jG0QW/4KHRKOUt9ZEyn/pSN+pENVuERcLJmdsW022/NjgOBZ4jeZeC1xXMGeonqBr0MeiVziQYOFwlOc/ajUOOvZux1Sc+WQzqFw2jvWmXz+DJSdoc6Xk7p9eI7gWjPDYinsidX/zctdlFefaSl34m6dwqgggnA5PITQ7x3KUSfessKQKQpfBXLZwlaTCLeNh1UQd7yzh2AnfFtE1iIVh00v9VSnsENPhH7nQGRPnrwAqzcX7jbZeO1pLl54vEVsWLykSXn/5KIa; 25:tDiz8q+oN+LvFVmbEIqLfC5oA+xUF6cImzirZPICrTbEoAmEs+th0kvC9qNfa9n5ptOoMCPqoIng+698F9okAtj4HYkzNqj0nSkba79q5cJoZrsljFu4diBfPYNecS7t9xhQUyOHZvclzndZAujCms0DCfzgsaOKmrt2ufFHgV34VQvR7Y2I/rBhbqFAtqPXSNP9Q+4clZ4tDLUcZcLFnkfAb0guzSxlvor9Cgf/vnGoHC6ptZHbMMgaYp182LA3Gk9im7tO5cmUp5JTz8jwT+TDzI77pSLWvBEP93kJft5jU9srENeQ6dBZ5vmcGDVYwND1Pyiu/fxXpwjds0mKwPQYTPzoE0u7Rwk9zuScHynrOHK1b3igCq/c1yg+qAsZjc+aVX1k4Ly97NmQVSFkzZvjxYxhFRNJfxkTWmAko27S0harp57ZJGhOdDMWCq9GIOe2Of7fe5kYoEvkLW8qTg== X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB025; 31:foM4y9c0RUGjSiImhVgftYiFH3DRSG+ZymBMYXo6NIAD/i1bFpd3KD9EsnUXRp+DFvYdhxFAlb77kFg2RWtz+mYici/uXuQdKZsWUQ0f1VXkosthMXpwXR3UKSfoBRDGZWHYqoizPgTd4lN9HB41pFOqVeSSorx2GLNLn6suhQF1yUvllUj5R6K7YLe1EjWt9Qwd86fbjW05V/cLSKd8OmZ/WChv59VnwYr7LPp3dzz+FsXFiUHDs6spwl5nYjvXd8JGzXn7e2JDodOG0n4ALO6JvGAhrty1xVVcowSDwF0=; 20:umwW7bPvkFEIHGA9jLdAIVXx0VI52xuIlIYbHQwJY01eguxK/d3ok52q08iEYBRg2jcqKBh2f1tVcJG0qIPBZvaEzY2/u4cM7CnOBB0Y/wKJRl/cd/zhZ/2uJj0z3tkIQxu9qazmTnXCEJq8ilqiCTYQfLp2Ves4tVz8s8C5KVP7i2v+edHRw3RqTs4KfI6to6Uhp6XsTMKfe/+fJPIhW9jfnS1lGDy+KAae7YUI7LcmXL1Tx7pkLpO4qTqCp/KllN7yNi0O0+fGqshBCPQvNqwI1JUb/7eT0GdeETWu0IFXEFl1nrm1DgsbCyOBGlRgEl+p7rXeCdt95fsOOPw8ITHPdSKfpHUNrD6woIQRTxn5d5vPwyEdy/WDPg44kDHtQ5VYetmN1ZH3Tx8R3v+Kkh+ds/pHGwFqYQvd0RKwaohW7poJr6QqAuy/+ZM2mOOFilV/JENnvgrFw01Xd9qKEpUKtH03XZ66PPHcG6rft/KtF0AO2dPOUcBXsiepjoFf X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(13021025)(13023025)(13013025)(3002001)(10201501046)(6041248)(20161123555025)(20161123562025)(20161123560025)(20161123564025)(6072148); SRVR:BY2PR07MB025; BCL:0; PCL:0; RULEID:; SRVR:BY2PR07MB025; X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB025; 4:vCR/DM7DNopWx/Hfa9NvELfL6T66kSH4rp0DyHgJEB2bEENUZLUJaqPS9VdZaKapraCpZAqPhkgp7GaLJOho1XHx4Oa79/pjfFlcBPwGhBekolrxfExYHUcLvncYc2QPIjpdbb2LpmU/AApJ5uRvFgFMlXADggFP6siv7LDVZEyEOPBL7fObEcHmlKCInsBNJKHsPX+GwVgJnEjVGBSLwv5mepihQN822Xe46iqD5kaEgenJA+pk271LdM6/YD+cgib188gkBZcIpDT1kxj5iVsNFNZ9C34cQa6pVoJdYTUYurjF9dI26A5k8NtTuYzioOqLD/EFkiRKJF5bhkgAafIzl2OwDVt/ZQTE+gFkDTckAyhmP7DKtjZdJLEc0DweTnpW1aQpzu8SWIn+AsYmSM0h8sB9BHHKhfCv1WhwwQ1/oVy7yQbNiB96Q9agPpTRf+XwPWz/l/9S/c81+btzKdAE8Xtn0khQpNdbYQFCWoQxcD+xAbdj6mYnefhG/CigOCmi4B9I0ZeKRC+sxMSJPFOhXmQsLS/1O1XAArSu0+0EdbhPUAom7QEI93v3MK41FFIcg3QwT4yMsl9RLJa7b8BUuuGSWctGEqxkU69Th1ruGSdKi3Gayrj5k7VIn9GW X-Forefront-PRVS: 0162ACCC24 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR07MB025; 23:H+cQZ63ZV3/juyGmu48yS7c55YMl1dlPftbLLQ50t1?= =?us-ascii?Q?v9qHgIKm2KwTb1p1UvxVUxGcw0lL10Bwe97b8cEOi23GTa+E0ziY6W5WhCo1?= =?us-ascii?Q?OP0yxFxOzu39V2VkKeAxpixsC+qyLxxFYZtdwwhFdO2QiEJc6NKfumdc7rI/?= =?us-ascii?Q?iT09qBG+zyVtO7Qzn2QIRAeoO3XyIjy54voSgydBM0VvBBf6fvshCtEIcF0B?= =?us-ascii?Q?oLMKZ5ohV2LXHbp2EV5Sj7u7xMkaoMvCDOgL4T2hiwUHaFj6wSghtoWPQQ2w?= =?us-ascii?Q?dCF+ZnDfihlv8Yoo27MveXYJNAbhCXEREC6yPkHeQfyd+P5p63FsMy0U9JbF?= =?us-ascii?Q?XYJ6gYiyTkuSL4Y6MOhRVv8Xf4/Z7r+vj60kE07BN+dmuXHn/qBu2VC4WRGV?= =?us-ascii?Q?LoQ+O0czps9Q70N6z+kQg/cNtmae7WBAOoaJqXlxY0bQzdVKZxGXup9OVdiT?= =?us-ascii?Q?gBYHY0GezU4WbPFkvxIu2LpEtjBcM6mNYsIk6t0tMaQuV3jRfukq5KXtlJU4?= =?us-ascii?Q?jtzmXDrqRKsFQduKmOEk7bp8s+I7cP4wC5imnmSOemkPwNau5T3e23Apgv3t?= =?us-ascii?Q?bq+JJpNV9a5Z6ACRNjpFKkO+BfSi1t9vD019imVPtGDZD79b/RVw16QWAWnZ?= =?us-ascii?Q?SSkBQtngjzJeBfD8UXxIiyZEyalqNjeKyGVFCGOun4nnxYhJrXnR3VRdSham?= =?us-ascii?Q?feMwMWLh5ZE6bl+0QpK8Ci1HEb05YrYBr6LXaJIfP+/tTOz3ymwV6vL5vBRb?= =?us-ascii?Q?2qEk+QyDknZLw/jpR2jj971N91pffmCiYvrJ4FD6GCvOhuJrmQfnZIJhsi1k?= =?us-ascii?Q?1CU4DKKFOvy3FVMEEzJ1DC6QeOui0rrObdz85b6RoffHpJ5oG1EeleSRPwn2?= =?us-ascii?Q?uAbuLszBlh/VaZAhy3gn2vguoLz6Nw6X3Q45AdD0mjQ7IfTHZXx0Hy2BLO76?= =?us-ascii?Q?CfvLygt1csLoYEvNySZTzqUk8WhK2yGQm8Y9ubtEEjZEDMRrguKmokORm2EX?= =?us-ascii?Q?MTeL2dXO7Y0GkL6SWZmeuD/p+yTzcwDq1ZgQ6/DHccXCiolH4RXPX5KICCGp?= =?us-ascii?Q?J+vHkBTOtv0DWyrvVKH+zWVEB0jBtl2Rdo6dJeKrDyqcZ6hdhHNwPFJ2hbvF?= =?us-ascii?Q?fc6isJ/Yp/xuZV3KKtRtwBU1lMjoXqdroMkEpihiIzTXCZkQprTA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB025; 6:Ole2Uh8pfXPMq+0F/Y5QA8V56CxklFP44HlImbrutbhCFpoW51mpxtjIltSvsNpk8ADkIO1+0RCwx6QnLR4G15DV6dyf/loKUpgs4DmCoK4UOQNY9nIthGTkTjy1cIDnav6Q1Th178HHBleQjRP+ijKTvf1qYDJA+VDRLpbGwPoWshMOA5ZGDDo+vdTfbhuErIWJXcxYXjFmwFE1XrDQyQC7rfR0sioTsV1Ho4jcXZ/Xpo8ElO+lbrl0fs5blLPpMe2Er1V6/KOhf9RSNm3Lm8cepSoZPneTYoRzie4VPPWffrGoJsr75hPtMUXVkazwfB1IPxhaqI6uy1RIJgXPMH9OqgBLidf7qjzbNUlIMPzR2QbWcj2JXHJhOvg2BcoH8iTGp5Q/1mkGOZ0wqFtBW7rKhjlEju+8cZJT8fEJ6mg=; 5:/BoBCAT7f92/RkyxZwGI/gCuTQtT4BKCR1TxT6fCGbwIsbAxbeoI7WrjvTzGeEwpEMe/fOvwJ8XTyDMceRyopOBD1l1fc5yVmQxGYhGjnoMc7Afjsea+w+T0fX3QAmX40H5YfuBqxCsIyrKmDsirnn8awtUln8TqH7ACHnpOHiI=; 24:Vz8AOAiDaLFsekTzQSMYK+ysQn+dG/fvo+X4Fm675ZSDz+f4fh70BTLpTJXg5RNS4b74Ds90Myz/UCdO/WFoy6Rb2eofvChtJ1R0CsjE5Cs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB025; 7:uuF8QB/CzwloO7IXv+DGvgZ5AyHwpM7zhfDlWGhKFtkyRpKhW2VRy1lv1mM+5utVDhwyhr2INCeINAVE+0lyypO8Vn4r33TpT3Bml2K3I8PdbatG/WGDmWHfEwIezdF8XLd05pPLaua20G04pOX047sSF0ddrIdbqOw90qPL4i0KGIazHr0By4zGbZBXhGTJvYH8t7Va6JhLbkqHx3CkRXX7tIqzuF9Qp/VZ+LcBA9ivcgDAGjaUL1cgzTciaM3GnOlSsxm5cAQeqJRrnlBJeD7qy7j+IX4/8Dfwqv2VvfrRkgKhJW/2EjtqkEtw3LVss6pfVkYnNCgc6Z9mG5svilWB60TaqwunMXIJmAW8x1wynTEa1vuLfwRSr7/IkXo6O+ggECAnNocc/u2Z3UmE12amfbKJJaXryo9/t3fIbHHXBGesfBvbxWkbdS3149GsqiGdeldmu9U15YaALlXzfQ== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2016 04:33:47.8044 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR07MB025 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran qlt_reset is called with Immedidate Notify IOCB only. Current code wrongly cast it as ATIO IOCB. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Reviewed-by: Christoph Hellwig --- drivers/scsi/qla2xxx/qla_target.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index bff9689..b9c559c 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -668,11 +668,9 @@ static int qlt_reset(struct scsi_qla_host *vha, void *iocb, int mcmd) { struct qla_hw_data *ha = vha->hw; struct qla_tgt_sess *sess = NULL; - uint32_t unpacked_lun, lun = 0; uint16_t loop_id; int res = 0; struct imm_ntfy_from_isp *n = (struct imm_ntfy_from_isp *)iocb; - struct atio_from_isp *a = (struct atio_from_isp *)iocb; unsigned long flags; loop_id = le16_to_cpu(n->u.isp24.nport_handle); @@ -725,11 +723,7 @@ static int qlt_reset(struct scsi_qla_host *vha, void *iocb, int mcmd) "loop_id %d)\n", vha->host_no, sess, sess->port_name, mcmd, loop_id); - lun = a->u.isp24.fcp_cmnd.lun; - unpacked_lun = scsilun_to_int((struct scsi_lun *)&lun); - - return qlt_issue_task_mgmt(sess, unpacked_lun, mcmd, - iocb, QLA24XX_MGMT_SEND_NACK); + return qlt_issue_task_mgmt(sess, 0, mcmd, iocb, QLA24XX_MGMT_SEND_NACK); } /* ha->tgt.sess_lock supposed to be held on entry */