From patchwork Wed Dec 21 21:57:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9483819 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DA884601D2 for ; Wed, 21 Dec 2016 21:58:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CBE8228481 for ; Wed, 21 Dec 2016 21:58:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BE6BC28494; Wed, 21 Dec 2016 21:58:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5E4A528481 for ; Wed, 21 Dec 2016 21:58:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760087AbcLUV6l (ORCPT ); Wed, 21 Dec 2016 16:58:41 -0500 Received: from mail-sn1nam01on0058.outbound.protection.outlook.com ([104.47.32.58]:46356 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760017AbcLUV6e (ORCPT ); Wed, 21 Dec 2016 16:58:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=C1NRH9LKqqCdYdUfZoIfJlaIj/peP2m8UYWNTbxAPMI=; b=AoY58OKepKS+6nGfmnNPPv38213n29eRUOQDbHIvJgysCRT+YTvXcCXUAp1/PcVHZzccJm35XpsD1ePPT36DvWRr0NZmfP0TPEq10ln0sUD5bUJQcMrV1x/3MI7tNUWinLk5trjJW8GBGKg8nBNf7wJQswocqGc6M/fN8caaazc= Received: from BLUPR07CA0052.namprd07.prod.outlook.com (10.255.223.165) by BLUPR07MB018.namprd07.prod.outlook.com (10.255.209.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Wed, 21 Dec 2016 21:58:31 +0000 Received: from BN1BFFO11FD015.protection.gbl (2a01:111:f400:7c10::1:121) by BLUPR07CA0052.outlook.office365.com (2a01:111:e400:841::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14 via Frontend Transport; Wed, 21 Dec 2016 21:58:25 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; linux-iscsi.org; dkim=none (message not signed) header.d=none; linux-iscsi.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1BFFO11FD015.mail.protection.outlook.com (10.58.144.78) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.789.10 via Frontend Transport; Wed, 21 Dec 2016 21:58:25 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.309.2; Wed, 21 Dec 2016 13:58:09 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id uBLLvuxk031148; Wed, 21 Dec 2016 13:57:56 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id uBLLvtBx031147; Wed, 21 Dec 2016 13:57:55 -0800 From: Himanshu Madhani To: , , , CC: , , Subject: [PATCH v2 10/10] qla2xxx: Disable Out-of-order processing by default in Firmware Date: Wed, 21 Dec 2016 13:57:39 -0800 Message-ID: <1482357459-31079-11-git-send-email-himanshu.madhani@cavium.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1482357459-31079-1-git-send-email-himanshu.madhani@cavium.com> References: <1482357459-31079-1-git-send-email-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(2980300002)(428002)(189002)(199003)(38730400001)(42186005)(4720700003)(39060400001)(33646002)(5001770100001)(5820100001)(107886002)(189998001)(23676002)(230783001)(36756003)(6666003)(626004)(69596002)(105586002)(80596001)(5660300001)(2201001)(50986999)(4326007)(4001430100002)(8936002)(81156014)(86362001)(47776003)(50226002)(106466001)(2950100002)(50466002)(356003)(92566002)(76176999)(101416001)(8676002)(81166006)(2870700001)(305945005)(2906002)(87636001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR07MB018; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD015; 1:kDx25e0NUzlJXBEso7+QIep2nAmuXBt4os1tomK6V1cNywU1Ye09ZtNcQllHEyYR+LjE0S2YEPySG5vd4GAj38CmZVw5EnfhwLBANs6To65Mx3DMLvD3GyVkGHwGZ4F6kmwFewnneITvYIlE1xEpXMqP0qh/DbYRE83tpp+I/HEDHi5vM/wBgSiNxL/nN/NuprOSjNqrBBEjNZrSj1Wz6LKxoJc0JpllIU/rURpzGcMD9AvtpH40Wwj7tL16CBvzRhBy0up99d6hctgmL38agXh4DuDK52E8eNmZQWPwPz1E9lw//NUhTQcd0k/UdcwhNdxcIljvR59m39c/pWR3IJbabKyO5NuucFsQAcXWBk6GmpxTcscarD97YELMCkd1YsS/3Wp4OPmvwtOeIl+IW5GN2I/RVytHzSA2wj0TvNQEKXu65E0q8MLHH16IuhEtr86BqnHo07/6ni9lLR0Gqubwpz/hLK//O3lB59AYig+VeEAW844DXOY/ylksxWtaXKRP9YlCHXKlQ+W/ZL9/GZqivgo69LhfLbV3eucDzAFBBmhSwOABvVESelxfOmEh X-MS-Office365-Filtering-Correlation-Id: f3daf6b1-68e2-41a8-7f71-08d429ec7d13 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR07MB018; X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB018; 3:wie4AaXou0pm9NXbLjxyH7U7Vp6xhmkuJZMY3OyO3zv5z9f1vLQ5m4PhiwNPD7frABH//H6/hicnOtHkYDO7yocPnOkO/czj4lVECTi/WrxHYw5j00hZB4cWPT/nPaIk5F1Ou3RyT3olewhbiq6RXA+nAq7wWS6iWBsktsfwUsuFCa8VwSL6tuyD0MZJ/P7odvDDg8YEWnERYy1MxzwFH9y3rau3E2wIEpArNwXktETbnhplAdATFyvq7+Xnz2lDtTjUHfr3ogBRgRLYiXttDN+fY19R4qXBRbKl3Q/T7Ys+Yi0Jik/ZkNozG1BifO+2Jbxoz9+IuIxOvVBI8Qt3GXrDb+Qsiyi7U/ht2lSu/JAatV9ABQ+DT3NQBW78xfEu; 25:XF3/rj7aOEWkaqxc2nrQZX7DcC745QwLFSrgV2ZcM3q2akH4KghDZCr72YivbswXuSdXSRX3NmBi63SRjGKAgRz2HSAYO4IQHmkQ6tK1lkjeWYQjcr9X65VAA+XxglDKkqLx2B/CSXP/qJUmkxlXMPhphn078GxdwB1zfqns2vLdAU14hiuLJRoDSIfQYOuZpBw8cyMhNarM6dLKH0aZwpCsmIcGDblT+rUCkhuHS/YiOqFeB+ZFIAb/Z+K/f1U9fd7kp5ETxzMhLhRnuw5gCxx4TzCQlQN0RpVEKM4ekngu6Cp7G2TK435E0VgGj1mdvuLsDdWrcP3AXTYGmQivmR+6as2jmR6ytJEmCKSv29zeDDgeaw8wG+VojGO17IM0+E0Flt/gK/HQVF7leWAZz2sUqyg1yFhmihj8L6glx75cfZm2bvNrmwa0WAihJljVN/CLRUoGdL1uUfANj14qzg== X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB018; 31:JmUqPcHW/QqnvHxUI1odmKaJQiUW7g2okehkGGvzimjtHK6ng26+omaoYTIzE8xVcPvrBC9y6UJQrnz3vd9xC6KTb0b4QEN1dg0D+vBedH0kouvwIZXZs2gw3lEwlCLtRQhqhrJkaiH/x/1t+oTQ3PV/XcXfCEUiCujYp2BycFgTMM9ovH2QGCAArS2k+e7/2xgesGvw7w6nwUL/NJ+Z0l0JqHr5DV5MKBFussm9IvbzEmV5rvPNIomphVNXT+fQbOqVFuQ9tq/CbS8u8BDE2mjab3wXcM03rTjWmZqbjfA=; 20:VmRIy2coZs7Cob3qjk9/Y/IxiHI2/a4CqzOq6pQQz8cSA8r+j1ZfM7ra85rVMv3wEytkLaeIxQSsgEabLu6Hj05gnhdqXwV16KWAfSpMGeM7gjwf4QpaWwvJBBjoMv12T3pUMIozD9nsL5/eqrjYXAbwQMREqv+LPMBHW4kW6OOZG+BpznRbGeDkKb6K92hyJnunBxh8n9xZskESqJraf+y9r4i1XLAsPpETNyiPao8l7YCCruzCrMjq9jDc6ZXLPItoQQYLziY5hCoFKB1hnMD8MA7z/M1nLOS75E+KMNitStiUYCoTvnVZFGKa4rg+lR/vks2g57huzcqaz0ndSMTu3VKUigAsGubIPQ65T9BUaSYIt/6iJ0W3MLpq4ayHtCcIBkP17caDaCflll/6FPSQBZcubyr6WIac4lp2cbeICmbzlzAf3IgS9uSI4B5lBh+Xq3urL/2n0+IfIbZXXbP/uRKjoRKCc6xTwqFdPoqdVv8vrXBbxmHmTFPf98A2 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(13018025)(13024025)(13017025)(13023025)(13015025)(3002001)(10201501046)(6041248)(20161123555025)(20161123562025)(20161123560025)(20161123564025)(6072148); SRVR:BLUPR07MB018; BCL:0; PCL:0; RULEID:; SRVR:BLUPR07MB018; X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB018; 4:i/qDM/IsUlRiKktk02nX7TiDVaAm+cI0Gzg9SzK+PN5kFYoONmPF6PtsZDKewBjC8vEKYltgOws+OTNLc4NNwbUrtXuj0DCQeZWpN7kFKjFaYMG6wcFvrINXOpnUMvF7bANbXMC01hvwGc8ilMicYoecXabLfw7X42DDCgWcy0nRKSJHnjyxWxMu1JIK/oNlxhdxiDKVu9pMEzrIOEydt0xBb/UvYO0/AkeB7xEVzFnxqHsO+UbYfX+gE2MkUjz6uGhN1lWbMeyWwlZah9t1xT2FCCYouzn2P8DOcQb+uFJhIJ2eKweAV0leovz2t/xkxtOfIS1TjwsUoKAzTTqASF04qS/+mFO9fb0NyW82lpljNJR9wNCsxsufuruR5Feo1IepBEZp2odRxcJ6E88Ez5pf/FtjTov0qSml00F9rVihfzawf7xVBNMk6cCPdBpI0ZBeTSmiYhe/0bbe+DaSH1eHbFSiEK8VS4bDAYdRNqlVD2PRAcBwxpRAr2Jkawiv1FFjGlIHCMFA49IL3rNH83IBkJ+WPjcsMYOVJd1C/BWUIwZOKXbYbELPUIO7mADZiERXC7vEhBXMy+RyEhRfP2z9/tEgNCzQB2zaLW+d2AU8qtjqw557bcBB9Oa3czYJZOocPvbYwLqz+UmfbJiiBf8Vl53AnGdyOnXkvaDKHtg= X-Forefront-PRVS: 01630974C0 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjA3TUIwMTg7MjM6S2ptS2FqTWdrODRiaVJNSUtlRzJ4cU9nTGlP?= =?utf-8?B?Rm4zWnJTa0xtZUNyVjdBTUxYcXp4VHVPRVVMNWFxUVByemduWllsVGFCdjJM?= =?utf-8?B?VXFQdUNrK1YyTllZSFYra05PK0E0Q2EyOUVKdDBjamZzaS9DSDUvYU5VeVZq?= =?utf-8?B?REx4QmtkUjVISFJlK2oxcUpEUTU5WVFaSHlBY2tkdlVoVS9WdjE2WmcxY1pt?= =?utf-8?B?eVRKWGRQRlM1QjNTRTduWUdhTzVDVWpDT0RPallETHpDSFJMQmluMnBUbnhi?= =?utf-8?B?M0pVRDRIdnppUHFsM2tYRzJ2TFJmTlVScUxEbHVneVRUb3hUZHBtRlBsVDRH?= =?utf-8?B?ajJwSDZySERMaWQrMjh4REZ3QURRbldaR0NNT3FmN0hBVVBlaUs3cTNtY1py?= =?utf-8?B?WUY5WE1FaU1WRkw0YklRM2NFaUNQK2ZYREpaL1VJTGtyUCtLaGUxazdFdDRP?= =?utf-8?B?aGJMb2tKZHJoYU1SYXQ1YWJyY2cyUFdFM1d0RU5qcmY5VkI1ZDdwdG80Tlo5?= =?utf-8?B?TEJIYXJWMksyMWR5LzNGaVJJTTZqNTBHY09GTjhoSjU4ckNSMXJoTXZZZ1g1?= =?utf-8?B?TjVrYjRsanhoL0ZDVW8vcVkwV29nUEZDenZuSitDV3k3aGozOUQyRTFXV3Zp?= =?utf-8?B?aGREcFRTZWQwY0V5YWVpUEpna2pTbUQwOWc0cUZZeXlyRnlDbXNEQWpJRDdJ?= =?utf-8?B?TzhkZEFZMGlEempFQXFQRnFPMVdsUlRpMDFmaklOYUhmWEZZbmxURHRPQ25E?= =?utf-8?B?ekl0eDMxL1ZoQzY2S1l2Yy9rNzMrRUw2RjczUkY4TEN3Q1dNM1dhbFJIZVgw?= =?utf-8?B?K1VNeGhra25PMUZUK1dpK2FBSUVUdUlZSHA4M25nYUZseWQ5MU1uMjFNam5O?= =?utf-8?B?VitoK1FnS0pwRy9TWnl2ZG5qTHhweFd1TnN6K0EwSFpnaE9KNlJteWJwNmZx?= =?utf-8?B?bE42c0dBYUZUNExwWkhNOTNGZ0FHRTRmek1MVFhuUEVKRThSWmorbVVrVUwv?= =?utf-8?B?K0F3R2lhUTZuRGRGRFZiaE1LUHJIT0UwbWJ5VWVlaG9sNXJmU1NnYU90K0hV?= =?utf-8?B?WDY4ays4VkhGcWxMZU1hc0NYbnlKNjdkNFBXZ09iYnNXUHFDaVcrQXkrRTg4?= =?utf-8?B?SW1CcjFrc3B4anFuUVl4ZlNUSlYxVEprL3hvenNqQzNrVlRoTmF1RHdqbDRC?= =?utf-8?B?T3NWYnc2WFBLRms1Vk1VQjhHKzh1OFBlanhkMDJQTmdMMkdpUmQvUWRDV2Vn?= =?utf-8?B?UGNGNW9RV0RLVkRubkRDTXE2ZlJHRnc2aFB6VVNxVXBVaWlhclJJQWtaUlMr?= =?utf-8?B?S0RyUVBLU1E0KzNKajNpOFdPc2dsaVJZSE5PRzlqMGRGb1VxWEFJQ3IxQlha?= =?utf-8?B?YzAwcE1zZEQ4QndmaDFnTzNJc0hMYnZ4VmcwOXBCa0NtdDhmc01RVTB4NFRD?= =?utf-8?B?TnRLYzY3NE5LNHFETnN2bDZHSHVKanZjNUMrOTlucktHNjJNSkp1SWF5dmZw?= =?utf-8?B?bHBHUFpiTW5ROUVZWkZsMENUWGpYRDlRUGUvMzdZenhtM1JId05oNy82Yk9x?= =?utf-8?B?dXpGaWlUQlljbHloZ2pIUXRlNXhKdz09?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB018; 6:eMjYX80dxnDB0RCiCdmkZK354DEEM2dvraqr8udOxPE1vod8eYLmizwtF5WUOqCTRdUedY/r+YXN43Q3T8A8AxNzdtFx/z9jTv7C/ySPm6VX+DmpbjzFuow2OBkKf9dt60Gy6VFstqD01ngovBEes4DZ07hcN3GAawtWhkGTbGETxaKPFHhXzo9tC/bELGfX2E7Wlgp+kzaTIZgsPAc5ctUTQm+CGVhjtbdQWm52oDgAX57kiub4kVaeTDzj/SqEJVZEP+SUYGkWX3uFfCmNgw6ovjngaHQ1FVLy3smQa8b9+SBa+r5UdNOjSRuyms3izxnWJSmGFWZv2ya3okPKTjX/bdVaeAY9kUUjDPQceEr/UczVNLL+z8rp8kSJFBljuod9d+17aWq2YvPTOHPWMKO3WbpZKbihQ+I4EynBuRI=; 5:tNuN50g3OEa7On73oNDL3tgCqQ2q0gz4Cc/bs+ArMCeFP4IvLyvdBsZYXWZaIJi9c1TTA4WDcSNWM5XvByq9XL0ZecTkS0MZjFnbLFibT8eAxf5zIgVpVs7mr6AE7r9x+olUcBOVdx5kqDxNr0azCg==; 24:mBQDLuKugaSR9rfuJQNJLO4kA+GC76+lPnEHvGAP0f/NpapAAHr6MfbZMH+wS7D+9S/bm0PPgRLh0Sn3SsD27pfph3q2h4PWq40PeUgy1mI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB018; 7:CRglSHXdETJESaDfBN9L0W2zleAVqT+lyWcNTV6d6OHUYhArIL+3nBpfx6XwxH3Tx1acC9Xri7lPRv+hybCewC3JHGpnlLaUV9UrjFn0FUDDnBi5e6HYI8cF3YMxge0nyztoZQo/RAeFcCx3kABFtbsEhWsy3Jz8aECPvHSVSZygGQAGohUYFDkGHuzJDxr+CDbgsPjT7d1DbIG++vD6sJa3OknT5O8+pvNKmn4c4ifK1201hEZhLtKP8zymC2UMqHQ9a2eyVYChWnQvGFSTtbZ3KReTaOfccDK5qTywZtepVobbfO+U4lv+29UxPwzCG8ALZGZZVgZ+NDNR1lAExrRW9kOxGSiPmYYcseIs6tCVST18IzuHqPAbSDHUnrIH2BUsr2UivQAjNCknuvq7lqi8GA5DzET2LlkyUGG3gnyNF1AFpzJTmtAD9cPR+QP8Die0slzI0rA5Qll/CR+VVw== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2016 21:58:25.0101 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR07MB018 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran Out of order(OOO) processing requires initiator, switch and target to support OOO. In today¹s environment, none of the switches support OOO. OOO requires extra buffer space which affect performance. By turning ON this feature in QLogic's FW, it delays error recovery because droped frame is treated as out of order frame. We¹re turning OFF this option of speed up error recovery, Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index c02f31a..6ab191a 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -6578,9 +6578,6 @@ static void qlt_disable_vha(struct scsi_qla_host *vha) return; } - /* out-of-order frames reassembly */ - nv->firmware_options_3 |= BIT_6|BIT_9; - if (ha->tgt.enable_class_2) { if (vha->flags.init_done) fc_host_supported_classes(vha->host) = @@ -6683,9 +6680,6 @@ static void qlt_disable_vha(struct scsi_qla_host *vha) return; } - /* out-of-order frames reassembly */ - nv->firmware_options_3 |= BIT_6|BIT_9; - if (ha->tgt.enable_class_2) { if (vha->flags.init_done) fc_host_supported_classes(vha->host) =