From patchwork Wed Dec 21 21:57:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9483801 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A5953601D2 for ; Wed, 21 Dec 2016 21:58:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8AF6F28481 for ; Wed, 21 Dec 2016 21:58:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7D45228497; Wed, 21 Dec 2016 21:58:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5704828481 for ; Wed, 21 Dec 2016 21:58:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759554AbcLUV6Q (ORCPT ); Wed, 21 Dec 2016 16:58:16 -0500 Received: from mail-dm3nam03on0065.outbound.protection.outlook.com ([104.47.41.65]:1281 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752789AbcLUV6N (ORCPT ); Wed, 21 Dec 2016 16:58:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=aa/HtM8WN0LRiNkUDiWHx4qZMvpjctmQpG7gxcgYBNE=; b=EpDRSMdxTXjGlBcOQGP6puGn6/FGi/5enrkPJhkHpd4jTKbgUoP1xf0YC52MVkrwf114pSH3jVv7ywYIBoFPXiHuIv/FDzJ8k6RJ3ggAeaqT67WIiIfWM6j9JN3RftuuQXjZIVeCHhjD6NZpvDjalzR0fsUBmVF6UAAUcobYcQ0= Received: from BLUPR07CA0033.namprd07.prod.outlook.com (10.255.223.146) by SN1PR0701MB2094.namprd07.prod.outlook.com (10.163.132.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Wed, 21 Dec 2016 21:58:11 +0000 Received: from BN1BFFO11FD015.protection.gbl (2a01:111:f400:7c10::1:146) by BLUPR07CA0033.outlook.office365.com (2a01:111:e400:841::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.803.11 via Frontend Transport; Wed, 21 Dec 2016 21:58:11 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; linux-iscsi.org; dkim=none (message not signed) header.d=none; linux-iscsi.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1BFFO11FD015.mail.protection.outlook.com (10.58.144.78) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.789.10 via Frontend Transport; Wed, 21 Dec 2016 21:58:11 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.309.2; Wed, 21 Dec 2016 13:58:08 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id uBLLvste031112; Wed, 21 Dec 2016 13:57:54 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id uBLLvseS031111; Wed, 21 Dec 2016 13:57:54 -0800 From: Himanshu Madhani To: , , , CC: , , Subject: [PATCH v2 01/10] qla2xxx: Fix wrong IOCB type assumption. Date: Wed, 21 Dec 2016 13:57:30 -0800 Message-ID: <1482357459-31079-2-git-send-email-himanshu.madhani@cavium.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1482357459-31079-1-git-send-email-himanshu.madhani@cavium.com> References: <1482357459-31079-1-git-send-email-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(2980300002)(428002)(199003)(189002)(5660300001)(2201001)(38730400001)(8936002)(39060400001)(106466001)(189998001)(6666003)(86362001)(626004)(4720700003)(47776003)(2950100002)(107886002)(105586002)(50226002)(8676002)(81156014)(81166006)(101416001)(4001430100002)(48376002)(4326007)(33646002)(356003)(80596001)(42186005)(5003940100001)(50986999)(76176999)(92566002)(69596002)(2906002)(5001770100001)(305945005)(36756003)(50466002)(87636001)(266194004); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0701MB2094; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD015; 1:LufUC7asq4OPNnEmkPIgYru7CO2JqadN0vHIEN9/XGVtWQgAAw+fH7xHPu7w5UKlyuM0xB5y/42RIN/n/VbUfvSI6eU0DVUGCXIgjAREIL/BCeKVj2K/ERfPLgSA6Z42j5RMjNfNmZcUBnYEbBAVhdcDwMQmJqo1ikT26GWOJoDHnDkX/efOHMBoCyIK59opgxZ7jk2hHnZV6gjyy0Xzq7Va2aFtSBR2MSvFlfpngM9uQOoNq6VCzRmAj3hm7P71PUpSoGheUNuZ3wtD7WYt872F4MYQV/qr9gczTtgemOI4cyVEQy2UDqsRkPEFi4NXxnWWqPk6KZZpZblSwj9v/pymdY6ykWsoiywJ1QoJ43kOsL9KC4hJpM7LbNCgsttZ2OGzjnLpj59X+Voqus8xkBpa3Hqzt25y5ODaGc0iuAcxWfG1hiQbXArTqju9wfxUIXcR/5pyepKCXMnqR7IuQFozTLZ0VjwzewGSG5EtEDD4S1Ie7tSnyRyMVf8aoSopkIXsxwQy7IpDPp87TRFbi5HzVgTIEEG1MMudQQ72YxgpXinN2/NZ0n9U3eZg5LHY X-MS-Office365-Filtering-Correlation-Id: 5151ed0d-fcaf-460f-92d6-08d429ec74ca X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:SN1PR0701MB2094; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2094; 3:MaQJ1yZb1XpZ6thSyLGsQIuyl46SJ68hT9NIBIh200HReIGD5A/gybJnqljxLMNSQZXxHBxGv84mty9kMhPOL2P+MjdPrwPCg0wOLWA+Y5UoBPhDoEgWU1RHTJbNKfq7l4nvqSIbDIrn9ixrCQ14lQ3xCIPqN0sLThc8c++y16P2sQHU/qE0aGub+NEv5kZb27lO/lKz1BR3TrxHotF8H0BvvZxNIdWLHMKSe9skQ+ap2Z1mL5uwSQ8kMF+1Rzo8nEcbJKpNDSmAVKVCsSbIu6/An9fnqmpqrAOIEO/6Hv1ecbwUiH+txyueb96slowC/33GiOzrBqQ4+l7w/OZ/c96u58jb1JocV+bb33xhBJL3OptREWWJPjdgzawArPuq; 25:UZKeQCoRv+xM7jH+qzDim9aHuedpbf1hJYFlt/2hjLev2oFIuiFMPj5aIbT46d8wr87Oz11QNZkmLtZRCajvbgNF+UGDwfgn1VyBTNkkUpqRlnPyqYSZ/3pufakiPHmyE8LQefabwDOPM7eW2gL7Oj1o4pU6hXkFpwfcW6PY5fc4M8Qv9MmO44WsqG3UwIkW+mfzHmNm1D0YZFmTfMZ5KjPK8qXVrnD3JdF1+aqbh3zaGp30h64LDZUBatkzFXqFOXZWahMkGINlKkvYBFqQrzl+46QZl2fIXwHXicoRAN9XONkiTS3VBKHm1+OzW+BMHnnfzhA8H9Oroikf/GKdW0WuzB+m0FgmDKWKTKlWpUnoWqnCkx8pXysYkLeiQb1IXD8dNv6YegyJvdeDmBqz4ImKlPQzOikn/QIbf3ibE03LD886iNS0GhNS0CgTtHE6/jU/1mK2keQBywdoVJgypQ== X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2094; 31:TlEFg6/+HVHjyxfmYxV0+26KvvBzfYxQ8Dfs848HfLPXb03A8q5swTa/We2TYJZ9EGtfqTc8xVk/XZ9270ynWFAT18RhGzXeS6JftRFDuNo4oBOne4zCzjI9/vhg2D6tuoW0fqFUHuNIxP99yuBmB+dts41xQLuEwcFui2NM2viUq5VMCNz35riVuezPOV1RqkFWMjnpTlOVMmsBlUtn0clP3juQdotgk6Sn5uSXcz74IEMIq0SJINFYXhIMk9hy4yoyDhYuzMPJi099m2JgNw==; 20:78TEyN7MC2LX54NZ6fD+AkBC+dwBnjlkTdZFPl+K3duJRB1V7L0zQDuQNR2Be3PNc4KLqGjA/1aImTgcgZ2pJHbhM+UC1bW0FGoKiaTw1tnviFPIAgQDscVTBvAOZEX8eGCXmOA0RUPy2t8TOIlb798llt6/2w3gRwinC/mRQ0Ktea27MIpyS3GZwPiLgYgTs6/IrtFmfzrUwCAnCm36aqgpSVbZ5JYvEiKt1D279KgsyfbzijOCXvpwNXOCxplwcIi7vJKfIU5U0ek9s2Cp4SY87lR477NMpytBjtiBNB4AuHNbnYlPVEVKRxOmIciZ35bqAS6OJ7jLy85M9aJ3dH7QAqQJTL49LG2MCh9qWjFFT4VrwshWMAP/M877wIqqGMIFjqD1ztuHcU9hqEf3sRdGobXeALTZxcYW9us4/TEFDF9dpO1WTuitgPJ4kgK8j9ysVp1YYQs/letvpGxBMA7elqBLJlgxyZkotNB5oPQOVryv5TTHyZ9O/c8qpMRD X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(13017025)(13023025)(13015025)(13024025)(5005006)(8121501046)(13018025)(10201501046)(3002001)(6041248)(20161123555025)(20161123564025)(20161123560025)(20161123562025)(6072148); SRVR:SN1PR0701MB2094; BCL:0; PCL:0; RULEID:; SRVR:SN1PR0701MB2094; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2094; 4:schXKzxIDk+BJNDZN1Ultmb2ILfkLdoT7go+zJ1GlWSOs79YBQtxtRktARwBUTaRG4Uwb1RUyZp0c9JWDAvBZVr7FIHHVSpoefzQzbHPnlQaYqt4RWM0TWWVRWRVMkocCPni5RhXhsT7M6ManFNuOnAHYVpriK+3NjN38mZO/+rA+f+AdKIZjwPNgTvOQ7qFK0zEeZx6VCGV3DaPMrTJoItiO34yEpY2TKRoodbMHAAkWAwVOsXptE3qPBiuLuqIZwegL2pmjIRjf6DlNTXFl9aIrXc9/wVNvimcFTvQntKD9Ev8oC5+KyyviNuzzSCCCyxRLUHsqaAgyQjioDi8KQElIM6PB12wfHuoaF6u5g/Q2jGsralvZXXoPIyFqX9Izyzy60KpR+HpEZY/3mOqVE90k9V9Bl6LnAHF7PMuxn779CPgfKN8/OOwHUXR4n30nnr/BMqvDVGOwpvQEfo10VdOufTRzUvYrmtFUws9i12Waw+e5Ow57B4H2WO6s+/hC4k91ljQxje977VnbQeCkv2Xpj3GQsh9LGZihazy5okSPPNoNjkadnnUNNMjw27T+Pgf0VEqk/pGqDqoFf96tv8tqPYPeE+TWk4Mt/Np9ZibmBaphds9revTeEuEmqJc+ZN8HXdkAxxHudLAPHtnFWjpm0nU7IoCJUJ1idiEky0= X-Forefront-PRVS: 01630974C0 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR0701MB2094; 23:wYEMqmxXVAU8xY+80FtOdzOmzzqRsdp+I8oHTo+?= =?us-ascii?Q?1+8BjGzHKZHUB/kXINokujDlAoMEu8zDxX2un3EpFQaozSvLAwndY0wycw+B?= =?us-ascii?Q?2nZiegnSO9U9qGXDKzhdbnTbfVggRSfrMDRJoQZKwZRS2CekGc8L1NO/3R7X?= =?us-ascii?Q?TZKEp68awN6nk0S5kv0cYzGyJQ2bD8IYxegXlODHYvQKZj0AlL4UiYYNhlpS?= =?us-ascii?Q?S9YUyDGqtkUiZAv9OVma3MNITScGboJNhT5AYaeQFkxf6/UtDBo9ydx5/XF4?= =?us-ascii?Q?LwJb9mjidWuCsQzGONTCaVwh2PHBf2GzTpZlRfvnRQGRL5kZYkaicotEneyl?= =?us-ascii?Q?qRYdu2m3DYtRp064yPFn4pLflhPvVrdjG3U0jvoXvrzOnQpXv3kDOrvOBO1H?= =?us-ascii?Q?UGWVmB07HMTeCdHq1LwJt0zMs8FXmGMM366XVW1YYJuG0Qirc7e19nb5urmy?= =?us-ascii?Q?HFfhHhTMXG/SFtH641VmfKNmktrDofuVMp6dMX6MXvcAoyhNaOMO93kIEcDI?= =?us-ascii?Q?PUiWM/O/OERY3GxytpLE6rGOrk+mN6CEheTBPTFmJVtXJ5ayVfSMWvkunZEi?= =?us-ascii?Q?imVn0ov6ut+1TfOOTdGJPwjkD3STKRsk9cFPkeYo8MHNNX+zO/lGGf16RnaQ?= =?us-ascii?Q?SjQDc28KulhXSxjZP+G5WUDKteOwRkknp5eUEWc9BJKtzs+6ZCjqJScrMfY2?= =?us-ascii?Q?dEiyYnuKPd4rD/+xOV4uYLcwIMfEzkVUse/yZZVsV/vOBg+Q1Yv0cM6mtT70?= =?us-ascii?Q?NFQkmsdKx8/53nUhoVId/7ebDO9GH4IbF9jrKI3pVrPcS50QCULkZ58c0Zch?= =?us-ascii?Q?ZfvitKSqFCb+TiiruD9s2VS/16vP4BrOjxnlva4HoPwF+NG0TfHbpx5j5If5?= =?us-ascii?Q?2nBEXS90vnvyiFWKZOxJOWikVllXTnIqt+07Kn8VQ+pqBPHcYwG2W13BrzPD?= =?us-ascii?Q?5Q5VvC19rPTzdifmOa4PCavPAfbkenH9vMs1PKBe/KLaJFWlF+btKkYDMIrg?= =?us-ascii?Q?CWU7lCIHdJ2SZL5Jq+SL4MSg1D4Uhn72K7eg5l1+UhO1qpsaeVQXwv6Madpy?= =?us-ascii?Q?BFZUIE5Csww1el/m6xPRVwd9ZBJLCKjT2ry5TWvGvcGfOn9LaPpkw8RTdC9D?= =?us-ascii?Q?H+OeiUMCRqU4CAlEnp701xUjKmbDb7GcG?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2094; 6:WZx6dY0TTDtWt2nWmyxgzsjsTv26vpO5XEGOEhLzwGYo5gL/UqqS7H3ygEdvtENOFhd8Qic6Z/nNOBkPNkNQpAc+ax90K9AQUmyZz3NBRC79gttRkHFD1FdY3UKPz/zwuGrKWK85UNK0H0fBmLAGVqkSAcjA10LDbf/G8Mu35saABSv4ChYKDKsWMhVs2DIYqWQWorKQtTTpZFBByGwWlXlsbTIeYB7whW6Q44gLW/050un6puJISc4Mkl70uBPMGT6un0m1AsW01D6njXcPhiKKx+8kVTP77tr1fzZepkNQxBXZcHCNEYqlgKIryc+gaxe0v22w+smdM3wS6A1RA7XVPbxtRmo8XtHvh8CBCD2uR9VF+Z7CYB7nc8eLdQYWTlqNrooeXa8j+85rvj23DPPBph06nveNg+73DOwrWw8=; 5:NCUUIFlOnthRrD4M92GxZzvYp6VQMLLi+ubEjelixktG8sw3Tnr4SAUdAEiOrsgrteAqARusUE3FX963v4I24dTUgsTBDITwNVq+DWCQTq+Og375r4XNSaHZ9194jCHBmRnB7lOHgamGfAOAQu9Ekg==; 24:PQnR6EbH42+gI76QK3OLhUh1GVAAm46KnY7FvjvnR74empLcGGm+HSsR4eolXVMKEUUm2AnSkRSh2QDYpsNCla0di0uHxV7gEZ9W91djeXE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2094; 7:YFJ/JpHfMbWC0jvQDCz5HuBalYs3x/mXcptX8K8T/ngXg7yfFS+sKSjXqyTxeJ+/qn2hvta3Sak6fwmOzuHAQv7iCxAKGZ3hedB/Fvd0F5l0zkllmxA6QhDwEsJev27ueUUkkH23lRQNJwVwdhQ9dEi1qhEFlHnj6O38uT9wnPTjBQGKsXGg6u/3XQlp+kyoiCFQ39sHUiQ0f4ZfM7T1gQ1E3qi5H+rLnqaZfJRuQLKeW2tLH1lmBNqrZpy0QTrUep2FJirW6RjCAlgL/T4c/HAEOMyzMZyTdMmb9inVa7IWkcrBkVu/QBe05zNY7DeEgcyzWrAYc4aRDpMsRs/GPqSLCWyBNLLFu2xKimxeG9V0sSV7DJVpvA6WtaGEbaZq21hJpvxbJqc+eWA1inQ7ATezI5A/6PGilEUlVj62T28vuoJMaGfk41xwsQBM5q5bsgA+tj92i7/cf8Ou2hax8A== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2016 21:58:11.1104 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0701MB2094 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran qlt_reset is called with Immedidate Notify IOCB only. Current code wrongly cast it as ATIO IOCB. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index bff9689..b9c559c 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -668,11 +668,9 @@ static int qlt_reset(struct scsi_qla_host *vha, void *iocb, int mcmd) { struct qla_hw_data *ha = vha->hw; struct qla_tgt_sess *sess = NULL; - uint32_t unpacked_lun, lun = 0; uint16_t loop_id; int res = 0; struct imm_ntfy_from_isp *n = (struct imm_ntfy_from_isp *)iocb; - struct atio_from_isp *a = (struct atio_from_isp *)iocb; unsigned long flags; loop_id = le16_to_cpu(n->u.isp24.nport_handle); @@ -725,11 +723,7 @@ static int qlt_reset(struct scsi_qla_host *vha, void *iocb, int mcmd) "loop_id %d)\n", vha->host_no, sess, sess->port_name, mcmd, loop_id); - lun = a->u.isp24.fcp_cmnd.lun; - unpacked_lun = scsilun_to_int((struct scsi_lun *)&lun); - - return qlt_issue_task_mgmt(sess, unpacked_lun, mcmd, - iocb, QLA24XX_MGMT_SEND_NACK); + return qlt_issue_task_mgmt(sess, 0, mcmd, iocb, QLA24XX_MGMT_SEND_NACK); } /* ha->tgt.sess_lock supposed to be held on entry */