From patchwork Wed Dec 21 21:57:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9483807 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4D8CD601D2 for ; Wed, 21 Dec 2016 21:58:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4041C28481 for ; Wed, 21 Dec 2016 21:58:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 34EFE28497; Wed, 21 Dec 2016 21:58:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 02C6F28481 for ; Wed, 21 Dec 2016 21:58:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759880AbcLUV6Z (ORCPT ); Wed, 21 Dec 2016 16:58:25 -0500 Received: from mail-cys01nam02on0074.outbound.protection.outlook.com ([104.47.37.74]:55405 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759680AbcLUV6V (ORCPT ); Wed, 21 Dec 2016 16:58:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=p0YhTx5SFKgxJe5hyhtv71CQaKXUuAZot/bgXb2p2iA=; b=MwTUAO3x2nOGpX5VaFLFXBWms3EiDlPjv1j2Jm304mKq/Sga3jn7DXOGxJHYbEJHYypiZYAct5zJwh5LjMqPpjssPSvVAUWdSTcHdW0sAqkx1R83XUSlkbNFYfvVSmCfelm6urnjtaTKWFoHuu7ZkGdHvcdwZxB6HsrxvNPr1pk= Received: from BLUPR07CA0107.namprd07.prod.outlook.com (10.255.223.178) by BN1PR07MB197.namprd07.prod.outlook.com (10.242.216.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Wed, 21 Dec 2016 21:58:16 +0000 Received: from BN1BFFO11FD015.protection.gbl (2a01:111:f400:7c10::1:105) by BLUPR07CA0107.outlook.office365.com (2a01:111:e400:841::50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14 via Frontend Transport; Wed, 21 Dec 2016 21:58:17 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; linux-iscsi.org; dkim=none (message not signed) header.d=none; linux-iscsi.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1BFFO11FD015.mail.protection.outlook.com (10.58.144.78) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.789.10 via Frontend Transport; Wed, 21 Dec 2016 21:58:17 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.309.2; Wed, 21 Dec 2016 13:58:09 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id uBLLvtSx031124; Wed, 21 Dec 2016 13:57:55 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id uBLLvtj9031123; Wed, 21 Dec 2016 13:57:55 -0800 From: Himanshu Madhani To: , , , CC: , , Subject: [PATCH v2 04/10] qla2xxx: Reset reserved field in firmware options to 0. Date: Wed, 21 Dec 2016 13:57:33 -0800 Message-ID: <1482357459-31079-5-git-send-email-himanshu.madhani@cavium.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1482357459-31079-1-git-send-email-himanshu.madhani@cavium.com> References: <1482357459-31079-1-git-send-email-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(2980300002)(428002)(189002)(199003)(81166006)(50466002)(626004)(81156014)(38730400001)(6666003)(50986999)(4720700003)(76176999)(39060400001)(8676002)(4001430100002)(2950100002)(106466001)(42186005)(8936002)(105586002)(36756003)(47776003)(80596001)(69596002)(5660300001)(50226002)(33646002)(4326007)(189998001)(2906002)(86362001)(48376002)(92566002)(5003940100001)(5001770100001)(107886002)(356003)(101416001)(2201001)(305945005)(87636001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN1PR07MB197; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD015; 1:UtIcNpaZo1uFiGjsPC3lSw9pWH1Fo/V9AQeMkzvNHhLX6NyEJIaQrxlaSfF9pDx5uVWJh1Ib7E9tD2nC8Bx5IcpHiztfouzCIvZST7IiAaeBEo/kjbeDATkS3UlM3U00RBZdnzi4h6XJPp3Monhi5fGmDZpJutonTMN4XZODqgRHxA3SlbWWf9tdU7FpF1ihFK61aYKUC7lN02XaGLnVnDGTaNryGvvdtBpZhXHtS15D0BnVzRRJRF6ul7eTanrKFK5t3OT6j91PyfAH5Ek2MUvolQTcmaCab16vwvKMQqxgLH/JuUlYeJRJZwI+A618T8TmgCDKLyp4IHuYrR0eOtRHHh5PWp0we2jRMaWEVqA7bmQ2mWNR+dq4dyN7PG09FU5M4L0g5hgOY1Z03EMnKBtUGxdU0zGh4DYmbnh+7yo2gWHJdcl0+NHpQWxApOyFK7Ae7OBafPlheIZ+1knWWpAPMftBMK6aQqA02PRNL7h2GHrIbL7O/1t8xrx8wc85fwWwoyOlY0F9JpyT279P51PuFXOLFe67GyzRh/UklOUeBKOp7054qt0z6//j3NEU X-MS-Office365-Filtering-Correlation-Id: fae633c2-b262-4297-29da-08d429ec7866 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BN1PR07MB197; X-Microsoft-Exchange-Diagnostics: 1; BN1PR07MB197; 3:/SznNrExles53ieikivmdjyDRQZiHh7IFbfK7m2JrByuU0TbN5mrVpM+KVPFacHxf0cPG8cATpc5+yAOWduGsuPBedBMJBXaJZY4Vfd06CKzr9RU0/49sookbOg98Kp5IVwjeDdEb8/ks771wI2OXT8vDc7KwwA7k0X3mK6A5MjmDPhKdo+rJfJI5nn0Tuh8yynZKU7vKok/+C9VntV53lqA+req5M+y+7K/WQL8BT9czH1f0IoXa9q86cmpKV8TelbepXWN+3qHfqUfBuQya7FjE8VZXeE1pW+xxEI9mvZq4QJ4V1knaLA37nA/QiNWl5Wy99GmpjLr4OC4BmPSfmC/wMlqsf3eHxk8EUSH2RoQ1tZGqOagkB67x+dCDOws X-Microsoft-Exchange-Diagnostics: 1; BN1PR07MB197; 25:YBV+4UBMxcB7qi7LvpAvvDXOD16YUwTtT1D1UJ8Mkes+l9ffql5j7guvKzitIArNj2JLfd3gmSalTUuYW9LdrEFrGAjReLl9VbQA7ZlQjPVAifFyD2324B4U1o9bL7XOoyXqwv5fn9No4fowz68zAgLjUYl8Vx9Ei1Lasr3EmDg/oCDwWpDIGfksuu6Wi5KeUeCbHP1vV+EY7uZEnSoIAoCOj4Bem2AKmKvJQpDGEbdLz4XNCp6QBWnjeOZkCqUGcfrl4K1JG2awJ1rH/fDkAhXOR65tZJJJG4caG7yU8xjpTfS1CNUUNBs2sgv/zBaZaDzFwN/aOD1hnqjMrZyOnQUPTrQOiLHynBx8IKyVRUijOKRiUK/E9pljiaLsQdKjnCyheAFPYR7/AzgYDWiHq2zDaNjKnVENIcc1wxs6N29P3foNoaKOVKG464sSGLRD4zWeklv+kQffwYlfJFm0mGhZlZ+h6oBWF97Djfk4gFGOSJ4yVVbN9AASfvJR7q7KZjyiKYe390EfdZKXC1bXbc+azfKhPMP2HTc4ll29AxUzZtFdu7CwH2oFDfqWuLFySckssbRCYIiDlU3lYR4p6+nxQe5o+Q5CH42N0yPFlaZlaYVRpD3M28hXUr+TY+Xht4JuCudR4oY8KIill/PgKcVwcRAcI1SMJVIUw1VYCcoR35pgrFAj/gQPA7U3+z/DdfOtjrNk/wAACQjDYZf9UuOI1DJGAVRABjq5L2CBSRiZB5hRYfHx4xFHpm9zEs1VvGebZnr/awhr1HYhElso2ozfu/iUGEIkcdWABei5/793FolhgG6c443d1GYAVXGKIe1JCVsrHQjGXfGQFjZZXQdEoHWo4+6LLJ+PYgeBc0k= X-Microsoft-Exchange-Diagnostics: 1; BN1PR07MB197; 31:1XslGo8ZYU2YR2E3qz2FbCEv5cUS3ZDONsPeqOGUUQVJGkUodwaPZ2KXtR84meZ+xShimgDsfxrC+qBzysknnsG5sEpiXOB0Y6kWPcDcoxdNzNh9xRaB3V/t4yMKV9yQ5iRC+I/OuEvCLU43X64E/mlQ0e0crZ7eDCZnDpm0iy7fb4uhzI2Md1Mk6kekeYN2zgDp4nBeIXb8nxywRX0LaL5/HN9LQeN2mBijWYTtTByX45774Mn5m8MxgrfYkkk0vg0iZBjDBK3tuLXpGxR+BBqdWdq6O78U1EkUo5S1tYE=; 20:851bVynpzaEQya+3C0b7qIIfUAxPnBX+778SaadCDMTVQg1Cvehf/abx5oaZg84nj7wPlGuT5rBAKzvPWo3gip8DmzqnRDA1Xws6iM6Jxcy+hCSoK4oHZABTT3fg4PpMl2yiphvw0lIyptheXSnfbvSxysrPXv9bFbGixlY31FLcfHquIQCeMahsBoz04G0o9LdJd9eJgxoJ8ggGfrGDgCxz4Zb0qMN8x2pbwcvOJ4xxx22ExNkvu/JayF+k+B6kibhfHF2Ol0g6p8VORoj+8Bes5opVCY/QdlHIQDuIuQAe57jlM0bmcJOq5dhl3ssZR5s7io9+u0D9pVSHiFUZ85tfNqrHvxkbE5iBBgkzrPO7Xy2ysvYBCuyRE8JIiSfVYasYZXZaPGT0h4TSiFk+KHguXUAc7KIsUT39FpWuhq2n7kF/HV7pJIoXo8XLcfTadyB+HQUc4NJRYTmFhw2vCChFvKkG3XM2zFr6RB42KH4Fpa5xKorUxTXuPx3bgEk4 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(13018025)(13024025)(5005006)(13015025)(13023025)(13017025)(3002001)(10201501046)(6041248)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(6072148); SRVR:BN1PR07MB197; BCL:0; PCL:0; RULEID:; SRVR:BN1PR07MB197; X-Microsoft-Exchange-Diagnostics: 1; BN1PR07MB197; 4:Dg/2vVPLuuBoyFnSiDcnhs00BHWAiOm1CRGIdP1yhQLdeWr2AltpUJdTZz3CWzFvC8e8t/y2Qt+k222ncCepW00EjfJYaceBefH5ix1fM2xkT8+O3TBZSbduwM0qVhr03C1vHisSR/LHByIG6bVOT1rjVS+bznrDK63yn23sHZfi5f0vH/+YqM5tJffxDRY/M7RYZoXsD9/Dm/noOLdAleOl1p2Rz2i5+PnRXuLiH+GG3wun0yNEu6s2WDdufhfVt6Xx/499YSWtM5sJjCRWEO5LrCOFIcYZm1Ub+FfxSJSHHawyaEIHi5yAqWivQhRd92kXGY1bTKZY50BCKZ4VglZwHMfk2D4dbmznfsy2npPKNzmzgfkgeVRHjCMcOeRAzK4u1e1a1Q7r231qfJf3ZSx1sWiX1kSf0diUZvi5RABCccP4J+2zQ00pswDH5XyX69kZQ1xFQ7Vx2ZBYN/pgqqZ9YLrLHlZPLgS9074qfaKzha+UchyJC63Ws25+rdViY86LNRPhchbUNVGJJVwBla9qIl/jwvAod4sRaIxyyd6Ss9jMNbYbmmnKhuvV2gx346x48gLtft6bZAMQvXNVkVhmL4CorkIu+5BtheXKaXagsoTyc1GAlthVKu7TxkuUr3wEASGtq5JF2Xju/P/iiZ/r0HHcN11qM0t0wwOdpb0= X-Forefront-PRVS: 01630974C0 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN1PR07MB197; 23:A7ovpta5rbyrVIMn5WgiB1F/vrGN/ilVmqU7etWO4b?= =?us-ascii?Q?ddBCwr3BswomiR2EnxurhEbGopnaDxgdZV1vvkQa+o/GhzIxhJj59Jg/wtXc?= =?us-ascii?Q?WMrrBO12ewlCjMwC3KynOQPGTBVLZaOzTzgjfGyLXc6xsWLHNnvjZGG8GA5c?= =?us-ascii?Q?3leYKyTwcW/Fy3p4bF+IRrGyAQ7FwRtzZY6iaVthvfrAAwsSyBfAPb3Hc5JX?= =?us-ascii?Q?pHbTnnEggL2lghrRPcQ+daBZFNgCke4pWc/nL7H0cqYiGC2A8nN8/6OD73qr?= =?us-ascii?Q?TBh+Hyxo2dJK4QpyHt67UsA6bF+mGrchY8hdzO7xoWFlP1maXUZvzGcXeMq9?= =?us-ascii?Q?CLtBSQFx1AdupV1dQ3s4qi/2y5eMhcM2JIqfWwz7g0TDZBQLwgee43omCbyj?= =?us-ascii?Q?CdfHntrFHxOBCIwoYNfAaeOExxwCAwBtz7eMQu9Vp2LFzi666ZypIx54yjbo?= =?us-ascii?Q?pp+42AScQVtjjzNfNORggq+H6vr7JTwr4ssRD56jR7duI9GYnyXZQHm0tR1L?= =?us-ascii?Q?P0NFaMzniBxT9N8YrE8vHt9sH38W4b2J00QOxJ8uqHnq9PCPF9+VMjAp6XUL?= =?us-ascii?Q?ZtBLJoKA55qCWOXxf7GCj7NExz+H3J+SM6H8iUfzl9aBKvIyolKggsREYfhD?= =?us-ascii?Q?wU6WWBbMF3sICtsv/2S/pdyhnHD70QI5ZPKUmBUnD4+jNvFKHtqF0wOaitGg?= =?us-ascii?Q?31OvOluDCM++Gi5a2AhM2wxYmC/YoZy3u7BkQFp3IMmATeTa0Uf5CBFgvYyS?= =?us-ascii?Q?ZQT6iIuMG0JWMWl8yI4SVc9wDn7aiyLc+pfAie4wANIOI7u70f1czmjkqB4s?= =?us-ascii?Q?3QGikZJaOMxHX5RI097+DBTkweregvgs+UuNMJQc0pzaY1e8ubUGr/zgYiQu?= =?us-ascii?Q?+uQWc43jkF8wivZV/vYFotEPvNhYBUbDMsxIvxB/D4fkRkCtMeVCjlSdtpMl?= =?us-ascii?Q?YX12tJufSCa4VVlxPeRHGIKP8Rd7wGG4kn89uLplZzncXUwB4HVhqCKGHjCe?= =?us-ascii?Q?Z4joTxLZKEQfmWJ+h7+Qzz1lmQdtmq7HUTnLFr8fHpSshhRTif9dA3YlKN9I?= =?us-ascii?Q?3RoTWIDfj0VRY41H11BuFqKwz0hTnpI7F+vHenlPVkMtPsLHX05TXwgKuH7q?= =?us-ascii?Q?D2Ed28Zyo=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN1PR07MB197; 6:IjHxLI7SPAVSRgH56PaJYHkdWV3HxoXSKCo1F09mt+lo1SZfL4ioiu3GkzsYMyLrBKL5IKNWEVa3vfJBszPhXpPSJ5exwEqdSK1TBm3rSLOSYeylmI4Ej9OH8xz4cTHvknkbIB2nvi7Ba6sMOF0xvfyeD01/EHavfgvUPU9o4+aonLHC1+bpC6tfpT/mbRxH4TPBFjNjMSTYxjNm+DR9j7OgUDz45Zb7MjiC+7T60nKV7dUy/c17scItbckBpvsZ+v/en8XmIYTKQZl/w0CQ96MNiVcLoYhnXyT9Nq2lBvy5wzvhNIWtL+3tX03pFVTOumrpmMdBOA3txR26vyv4yPTmQN8vdeaa39/jx1eTu5OIHIWCt1fMP/7Wb2igmDJkR4Nx1OiJm56Ushav2NWB+UFNGSOGdYD05sKvm4iLckw=; 5:+LSBdQAcbh4+G7zeGkLsHaSJHjj1Qz+KHh7X05dnyuM9QYPeCnbgdILXW6P/gFBy9JCMa0E2zGCewx3tKEZR0NDL8cFoP6d6Cdgel7lmUsiwtx4QHEUDLa28bDrXhA8lfiuHpUOI/fZLnk6RnHo1nA==; 24:NsuxaEVXTqgrOwsy73Uz0vSScacSVsO6O+SXV9GYInh3wf/rbqMNItcqhU0B1N4+k5AWeTtzKL0r7XUzMWys6LJXG05LciiERA7+TJEBvvk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN1PR07MB197; 7:ZMeUNEqsj5KXcRHleEgLcaVQ35R6iJE4XXE6TypyY5mIFPEOolXi2WCqzoH4eB2YoFY09jn/7f6v8uwEXaoXrGy6AfrjaMoB/3y93UpysaswtomlY9IbUp/JeOkTN7gTI1BWfkixzs6A6O1IX4oIr4iPzbVvaMvxXLq3yjEKKe85KaGQsn86htFwHWUezBvtI3WPKKWkAVoBPt5O/XJq6OFoV8l9uQi+EelXxrW8meDpWEWc4/dBe3q3wt67py1cBcVQT02paHhJ/BYUSZ7pAiEBPoitNFthq/lIm22yAyWcmwKLkn1HS+u3sfgKWKOwWJa0AhGoAFm0xzmmLTfEm9fBxSISO2MFVLNSt4iO9kKJ1mUyrsLxI41NOsiI1l85iyyYr90eqSQF0OSvb/2nTOPqdjwMBBm8MMlS8Nog4vl02oOlPvAe3sC574m41S7kZK1HrfiE1rvIaXAi8z0gFQ== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2016 21:58:17.1476 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR07MB197 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP During NVRAM initialization in target mode, reset reserved fields in firmware options to Zero (BIT 15) Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_target.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index b9c559c..5037b51 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -6539,6 +6539,14 @@ static void qlt_disable_vha(struct scsi_qla_host *vha) /* Disable Full Login after LIP */ nv->host_p &= cpu_to_le32(~BIT_10); + + /* + * clear BIT 15 explicitly as we have seen at least + * a couple of instances where this was set and this + * was causing the firmware to not be initialized. + */ + nv->firmware_options_1 &= + __constant_cpu_to_le32(~BIT_15); /* Enable target PRLI control */ nv->firmware_options_2 |= cpu_to_le32(BIT_14); } else { @@ -6623,11 +6631,18 @@ static void qlt_disable_vha(struct scsi_qla_host *vha) /* Disable ini mode, if requested */ if (!qla_ini_mode_enabled(vha)) nv->firmware_options_1 |= cpu_to_le32(BIT_5); - /* Disable Full Login after LIP */ nv->firmware_options_1 &= cpu_to_le32(~BIT_13); /* Enable initial LIP */ nv->firmware_options_1 &= cpu_to_le32(~BIT_9); + /* + * clear BIT 15 explicitly as we have seen at + * least a couple of instances where this was set + * and this was causing the firmware to not be + * initialized. + */ + nv->firmware_options_1 &= + __constant_cpu_to_le32(~BIT_15); if (ql2xtgt_tape_enable) /* Enable FC tape support */ nv->firmware_options_2 |= cpu_to_le32(BIT_12);