From patchwork Sat Dec 24 02:06:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9487765 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0A25762AAB for ; Sat, 24 Dec 2016 02:06:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E87632074F for ; Sat, 24 Dec 2016 02:06:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DD07226212; Sat, 24 Dec 2016 02:06:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0F47E2074F for ; Sat, 24 Dec 2016 02:06:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754674AbcLXCGa (ORCPT ); Fri, 23 Dec 2016 21:06:30 -0500 Received: from mail-bn3nam01on0054.outbound.protection.outlook.com ([104.47.33.54]:63531 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753899AbcLXCGZ (ORCPT ); Fri, 23 Dec 2016 21:06:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1vh2GwHP3yp6E0VMRmGC8Vxm3evWjgtFU9hkXUTiZcQ=; b=NrI+lZZ5eM+IvnuYft/8GyqM/1zHoERgvUBqZteqRjzmrkg3ktcz8//6gZK/SK6E/shz8RbTPs3I0DnPtQOxDPmEXkZrRFBkMM1umYzgSAvP8AW8jBhwkiqbsV3bpJKllBByEwv3YU+PurcOe8btNgqkT7jIRAvUfnGQxa7Tx3s= Received: from MWHPR07CA0022.namprd07.prod.outlook.com (10.172.94.32) by BY2PR07MB028.namprd07.prod.outlook.com (10.255.241.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Sat, 24 Dec 2016 02:06:23 +0000 Received: from BN1AFFO11FD027.protection.gbl (2a01:111:f400:7c10::145) by MWHPR07CA0022.outlook.office365.com (2603:10b6:300:dc::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.803.11 via Frontend Transport; Sat, 24 Dec 2016 02:06:21 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; linux-iscsi.org; dkim=none (message not signed) header.d=none; linux-iscsi.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1AFFO11FD027.mail.protection.outlook.com (10.58.52.87) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.789.10 via Frontend Transport; Sat, 24 Dec 2016 02:06:21 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.309.2; Fri, 23 Dec 2016 18:06:15 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id uBO26FQc000846; Fri, 23 Dec 2016 18:06:15 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id uBO26FH3000845; Fri, 23 Dec 2016 18:06:15 -0800 From: Himanshu Madhani To: , , , CC: , , Subject: [PATCH v3 01/10] qla2xxx: Fix wrong IOCB type assumption. Date: Fri, 23 Dec 2016 18:06:05 -0800 Message-ID: <1482545174-811-2-git-send-email-himanshu.madhani@cavium.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1482545174-811-1-git-send-email-himanshu.madhani@cavium.com> References: <1482545174-811-1-git-send-email-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:CAL; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(2980300002)(428002)(199003)(189002)(8936002)(69596002)(305945005)(189998001)(36756003)(4720700003)(356003)(5001770100001)(80596001)(8676002)(6666003)(5003940100001)(106466001)(105586002)(107886002)(4001430100002)(47776003)(50466002)(2950100002)(86362001)(81156014)(92566002)(81166006)(2201001)(33646002)(26826002)(5660300001)(39060400001)(38730400001)(101416001)(48376002)(76176999)(50986999)(50226002)(2906002)(42186005)(626004)(4326007)(87636001)(266194004); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR07MB028; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD027; 1:ERqZyfBUW5ai/w9x7vVAXzvMg38lenu9y5eVr28fGpFSxk//GiF66/9nNlcXoSxABeEfbFzA49JtqHsJHnUECQLF85Tf1e4r46EliO6kdy25KlkEmTNbwl13xqWFdHwsC9W1G5Ywxo8jzbCxC07n68KBnbRzbEFUGzk3Hk0tEiGzjwAnI6e4K3xqkLRdGOIAMNunC0aeVgmW7j3fFdtysSxF/40Qtxbo7TUc6XYPGeVq0q1AFctYg9bUVuJ/F270OfFBAcW7HU4hKca2gTqtw5DYbA7j0qnPzIF2ophcY5PBS29TxswFySsaclfjmjT1KpKOhzBVqwJAbHRRwZXRnog4peqwH5RAeh897/JTeWrQDEY6OO7tddgD+qT5nAD1T3S5hr+9Fu04yrWrDHXp5wc7oalUEza+R4NIBe1XYznvsu40hns02Qp9SHxqhPDaTRs57c9f0GjtN0mRSqWltzst7UIw417yEbqLjagvvfOE7z+PNN89XwF8kkIcmM8GWnVRW6izaxlujc51XvtxeQ== X-MS-Office365-Filtering-Correlation-Id: 08daffff-0d76-4e58-2b16-08d42ba174f6 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY2PR07MB028; X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB028; 3:QqrZQtdhLw0hGI2rIC8jw03x451Y/F9bJytd3bWP2WSrY76ce8aY/cw2ymUbrcDzuMzUydCWJzG4S43cVMqWL3h06JtD7toiWp4OLjAxiMJCmzIoAyHyylMFuAzo2hZp9uWxoJca0hWvbhnbz8ULjASJE+sztHXqqUjxQJpJDjG4Phn1J2pUaWDnDk+ub98sKLC2K8uB7lzD1S9F0zGb7qd9YBMIAg40pV+BfyySZgL/whaIU/xMQRqet4mTy85wkKBfLlZvGX9Sc6PQ1xlPHkF1+0IVIfCx7wvsG5r68RruHDZdBYgGo7rzHO7zFa4t8SDNcUb2KRESfGTeO/22eudX7hJC4M5KgHxPJaKt+XOR9lRCjOeYvapoXclL3L88 X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB028; 25:VZNUl0Ea4icCB+hOFx4bxGlLlnISTm5otBU5fOISLnBEZkCBlZsQdyWqC6EtrU72yOYB2+ul/EwsRFWqkLFTTstuTAhaiv0dKPnngTrSAYhUAyibdofLk4GpkufsJaIK5tRET5ooD5PXMSyrs4+rzuBq2SVO2qgvY59Z6y3LetIfGE9FTdU+oiN67XkMFa29CmynEa4n0M8ZKmHibwdRScsZ6nd3efba/3HMub3bqF/0Yz+A6/xfoLoONdOMZratd5jzbE06ccsEDGSwx5uhvduiwQ8RAbNoCG6S25vbQ52ONGI0R7p+iPEHEH0mv1sskb2XhUtl+tfia+Nze8KXRCehbNZ0lg8gJDnfI6cX0WlzyAJP3ni8TPyQQWtKquJ02PE87JxOv5+RZkIpDoQViuyF0Tpl0lhUt+r4b0c6uSBDZlxPYUR/ey1SYv6ejTYEkvBZIK0hIGuz7rlXxnrE2/3SQk9Iujnx2GKNe8MG355/AFR5VMgImJIZA1EfS97F0n+PC5dm9JYFlnQNDeF0koUyA7RHKVUrKowf2/XI7XA/JqdBNTnEiHcqUQncNknbLzt+8p/aA9IvkScx3g/7rvH0+ePl2g8cUkG7t8DAdURWVwo6MVLQpYS5IN7qGXFKG5I/hDV8lzsjue4xtb2MDcBxw7vCZODcr31Aab8+LzNx2QyLjmqsCndwz7GP4Vkavil3mv1MOiN6ZYavtL7jmhYpTgBr6reFom+68Fw04SWbUt8w/Kk+WK57jeUagJunPz14ifO5b4j5sB+2L0Y5C4FlxrDR/Z1tKQwdq/8KF8aVdV2RcnyQwd8ca3tonTtHiPOnIVqP+wpXNM3I0TJV68Ga8o9tAz+zE0v76EADZBw= X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB028; 31:zKCgVZ3MIEhrA1bRT5/gbHY82XHLQLjXaEO+74JZYTBsVa4z+1G041vwrBcI5ugwxSIdL/fj+/vWZVaQKz2hjxfXHNMUCUHgTqo/4gnMCRAKHSeNL1kfprGwm57uRPcICezdGhtj3LHSFf5LgIZzyCbSBgeo0BwCvkqqLDP5ieGMV7cmvpd62j/ch03ivRQDWcpBYe2vnI1TLDmOjNaS0Nd6Rfj8iOeN0iSV8LczoAY5gC1b5UNBdWKnU/bA9LGFAvnD/iFv6Qp8pjfUkHZvyAUZQR7oHdATDMaAh0GSPQw=; 20:PJ2vnG/C+2gViOiI9GN+FZdDlDxVkUDd37619bJ9gcn/VP/fARGMumK/LtymA3E+rrJQwMDnYuiqwtEsq7mG/ILdzkEPcXCY8f/ol2XcjggRFU5GtbaISk40r9Kg9111lfbjpBrrnXEOMZDrWaB5D0+cxkIP0eb+X1oD18XJMarPq1FYe4TWRFAqdCxvOp3N40jIDXWUoPg0HS4gkI0gQgT1Fs8WyazrIhYQESud0t1glqY6Qa0Huy8kKHsoh76jbjXQTioFjLFfZ77j2Y3ZfiD5m2fWhadJMf9T2CNxLQt83wPER4ughw8DEk6Jl1D7Piua+ei5api9+m/CFJQH0KLg6VegqFK59QoEASka+IlW7QOPVDFKU3ReFlasqi3ThPu25zEmyQ2y6djxF3YTUtEYqezbyF3DGq5gnWkkR/Huea/Cztgj9vGC+fJJgGsnG4q3CRGwerzZ9BVbvpFCJudH167R2aaxxrnJzTKjthNRKDUVfq2BeTDXU7M+qqaa X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(13013025)(13021025)(13023025)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123562025)(20161123560025)(20161123564025)(20161123555025)(6072148); SRVR:BY2PR07MB028; BCL:0; PCL:0; RULEID:; SRVR:BY2PR07MB028; X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB028; 4:uRng9TvczylR9YbuAyRZYF/ZKj3f+E5gcEyT6TxADyhkwTu+mcy90cVErT4OrMhn+RgezMOiktmUXajssGiRj0EEKcJgaUZ3qb79kZ4KDyWQXq0xhbaYynDTyaSqgA06slvtehC7Yq2/D9IzK/J/g3imMRmFH7A/4jOgd/eZticVXQZsK7UClRGpt4aQt/mSqnfjUalZqCn1AUXO3P5W1wtGu9G3vaan6pDijfRSRkYbQZ50m2CcPz/rTXLtImxSAl/9JEjir1RxYafUzZFEisxY6fc3VA33NEp+FQnOP4iCT6wvHtCQWaqbyqUn1UcuundOg8kRTc2fQwpCX+GVNof2az5CqsqtfiSVE17yAlE5g8Mm+58GI1HJeSJrLZ8fGIndLHDr1tfjhVoPozf7PkiCbFWYbFsQGtEhDVZZbCskCdKA1nNlMdzhVr3l/w2ki7j3kUdKZoNo4fL/9SbMSgjwkYU93lZXpFsERN78EmHmOOW91VPC5eTMivRTP8CapIBaFKomgLmO1f2rgRHd72D9fPhcpIdA3b5tDte/ubwMBF8jL1vlVRrQrH8zf2juYA/jLcQiHlVsiOOZnc+A7pdfgXJf9URonaqw9rMiqWOr1NKf1t/4M/qP4k4hFfjQ X-Forefront-PRVS: 0166B75B74 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR07MB028; 23:8dDmTVS8K37tRXodxQMRwXj5k3gt2qs7rlBWqGYnfi?= =?us-ascii?Q?EfJ/gmqyUcGJaHcusO/t+nQuQVZ5tCPa3+89FLW4xEeY9qX8o0XqAaEf8J6B?= =?us-ascii?Q?0x1P1pLRBjTKOlIJn9zq54tQOicuPAE+zqDXKxcDq4Qz0r2EVo57UlauT2Og?= =?us-ascii?Q?nTg839lxmiwVEfZSDKB0+JlY22eRaa2ZSQ2xavv3ehyUP0xYA3CPEf4U1u8D?= =?us-ascii?Q?efqESIkVNhLRQBRyEb2eH72VlQs9WmBAbtKZxxkbowHiZm/op7PWrZmdPUw3?= =?us-ascii?Q?AkDBsnxGO1IGZLnqExvtZfcI7lkAOyTEftzD7VwAnKVNaigLpohv6NeEiFz7?= =?us-ascii?Q?T5UbY39L+L6L1ICE7d72Lwo9wqaTH77w08ao5lffB76AQEnRT7dLoXYfdYOv?= =?us-ascii?Q?AtsnpmdHaeue6NYKb1hQL/1ARzeiR+wLnQgNsplqz7vJCDlJCotHC+xa/L1c?= =?us-ascii?Q?1m2S1PsfIaI3dN4FmqfLDuGg08ZOLXN/Ae9CizfPzUew1HbMUDazR1syJaiQ?= =?us-ascii?Q?BZSc+Ao/vLWHqsq14RKVFtAle6jf+GSOdfvOfaITOlvi37PZNI/g3ZW300m7?= =?us-ascii?Q?6zBWAwvvpFz9N8+ixwZ0KRxM5BjRDl6dfjF70JFOiaqAL43RHbJPbjhj+aal?= =?us-ascii?Q?iK5cryBUxDIn5lFLOPWvkKYMMGeCfLJp70NEdlQ4GZvNEEgkWYghN2GhQalb?= =?us-ascii?Q?7NhD7jvDyHi6Izdt5CCEVsSUKCLI11BEZ0ReD0ZZPP1mYov8HKy0RmsOk8Z+?= =?us-ascii?Q?2jerwSSMYa9BPao/6hgABkEAcDW29Q63T01Qn3BxdmkWISuz09nO7AQj9cSx?= =?us-ascii?Q?xQekNhFSHRWVrNaGRFl/bxQCeC0ltEdVbgmSifQaHqRlZsLxE4OT6TO6Rm6R?= =?us-ascii?Q?S+TSMpdtSweDMEIId75eHgf70UG03Wl+QXNF5BPyoBhA6B9hjGN9qzCk6WXg?= =?us-ascii?Q?PcAItf4p+3qe1YZF6NcXvz5gdlcIe2BGV6YmRA1cQHDCIzSODQIVO1G4D7Lh?= =?us-ascii?Q?QN8pb9McJc2WjsvIhFLcAkzwQa9PBnKaPFyIcdoHJJwdtHHJokuB0KpUNnI6?= =?us-ascii?Q?yekgzzzszW/r08qKg2/CyVFnCsar6FOkoJrrkx2SJ1x9T9OANM9cNsk2B2rh?= =?us-ascii?Q?SdWjRHnx26BKvMYSHWAfrdD03A71M0eYqQze3gwzW5KO88iMz7KQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB028; 6:/7gCzobnd7N5bZ+8uI3E78Mb6lKR165d8Lca80RTH/lkgto7aN+10+NYD0MS1tHXQPOeZnM/PmBuelpFPWZ6+YHZWBWoEYzx9b6ekWsH4Jjl+QQxlNGouGLvB4iWapzrw+9zS1TNhqf8S15mvaQLtBIIYYTMDMz1rhDhfX2B6dSDtl+js7Io4Q9dMBZj3CWRHMPH+l00nk8r0SJLg4iYCInkVmXfbxnpl2u4rHvRl+7AzHSj+Ti4tYAZqxM/7Xa7Ojn2CSxiG/Y+9GxhpiJxEZtGcnAyEtFljJBW5kGCw5pVtUFMzMFX/PdbQnBJe5oIxJc5FABKGvu6cFVgURAIMsghcLijEQeug0LjsKsh1sjE3SmsDTFrNPNHkdnR0GTcqHbMDxeLg8nAYHBM74QyxVZ8ZvkRdq2ZC+H099mete4=; 5:mWnWJRZzZ54970y/37rQVR2TXNOS/qAMPIr1hkkJednGMaAWCAbZ5vHGT32MzV0FAOvAuv/GaMW1z9AJAc6rKZc4TK+asy05HoXkWbNU7BMM96eMCV89Tvn+aYZZ2d/wVxNk/iL4xNPSXlwauYl/RA==; 24:RispdMg74zn4ONrvbLHIJnKcRa9DMK3gqixfX1TiHPIAP+g4Rr2gSQkMmyPcfw2kmuJo4TuU6Zcskkinx1QlsBhEp097V+swQ5PYI8fT6yE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB028; 7:ZRAqTX8RE4HqnmZxFQj34GO8s7PYjnCK8nrEZftJysIBvcUN7yrN98VFFbE0DbRmWwzoiZaJ62AO11ZlYg5RiKmQkvKTIs0vas7OV/ef9Ym2nq+z4N6Ga874jQ8FgvzvSTb9z5Z7+HbQUGR14oiC/tH2Z7xUEEvJouapwIPrpA4E1zgilCeGaQ/F+orRluRtzu+d1vmNqbj2VckcH0orZ5gF/+amNAyks8uX6kiuJf3qox0TxEUJCaFid9IuFJkRHl7yUTNKEOU/VEKINdxQBOl4gbrdCeKG2NjUQqNQDPRieTzXeoyDihDbcd/iT5cnvXKD20p0MFZbFsybCuezgvnnslrCRvwj2aNBvLvpw/Mm1m5ihI/jTZASGr1WNiaIpVcEAuOCOpYKIqNjl+1qGay975Db5B0WRYrMoozF/ocQ5l94uDqWDg6twdCdrjHozcl0AjXstHuOstjxQxn4HA== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Dec 2016 02:06:21.4513 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR07MB028 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran qlt_reset is called with Immedidate Notify IOCB only. Current code wrongly cast it as ATIO IOCB. Reviewed-by: Christoph Hellwig Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index bff9689..b9c559c 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -668,11 +668,9 @@ static int qlt_reset(struct scsi_qla_host *vha, void *iocb, int mcmd) { struct qla_hw_data *ha = vha->hw; struct qla_tgt_sess *sess = NULL; - uint32_t unpacked_lun, lun = 0; uint16_t loop_id; int res = 0; struct imm_ntfy_from_isp *n = (struct imm_ntfy_from_isp *)iocb; - struct atio_from_isp *a = (struct atio_from_isp *)iocb; unsigned long flags; loop_id = le16_to_cpu(n->u.isp24.nport_handle); @@ -725,11 +723,7 @@ static int qlt_reset(struct scsi_qla_host *vha, void *iocb, int mcmd) "loop_id %d)\n", vha->host_no, sess, sess->port_name, mcmd, loop_id); - lun = a->u.isp24.fcp_cmnd.lun; - unpacked_lun = scsilun_to_int((struct scsi_lun *)&lun); - - return qlt_issue_task_mgmt(sess, unpacked_lun, mcmd, - iocb, QLA24XX_MGMT_SEND_NACK); + return qlt_issue_task_mgmt(sess, 0, mcmd, iocb, QLA24XX_MGMT_SEND_NACK); } /* ha->tgt.sess_lock supposed to be held on entry */