From patchwork Sat Dec 24 04:23:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9487867 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8B350604DE for ; Sat, 24 Dec 2016 04:24:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7AD2725F3E for ; Sat, 24 Dec 2016 04:24:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6F9F927829; Sat, 24 Dec 2016 04:24:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1127025F3E for ; Sat, 24 Dec 2016 04:24:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938909AbcLXEYB (ORCPT ); Fri, 23 Dec 2016 23:24:01 -0500 Received: from mail-sn1nam01on0064.outbound.protection.outlook.com ([104.47.32.64]:35776 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932809AbcLXEXx (ORCPT ); Fri, 23 Dec 2016 23:23:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EyZiUvf92X3h69j+SJ/VsjuVTgYaTVafz+zMMT55ynk=; b=GL0qfXBvLGWwM6o6xpn/USLzApoCFcIjTOeC50AHNMItMNMCo6LPglaKwhD67iVLd3IqO7cHSGqEZZXZg0moytOL1VkJPkkOV83lxx5l5Syk+mSFsJ3IdN38vYTg1LgqsmQu3dDD9Fs9DDma7MF7nUB0w5F8VKJtzLJEq7bpvSs= Received: from BN6PR07CA0040.namprd07.prod.outlook.com (10.172.104.26) by BY2PR07MB026.namprd07.prod.outlook.com (10.255.241.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Sat, 24 Dec 2016 04:23:50 +0000 Received: from BL2FFO11FD012.protection.gbl (2a01:111:f400:7c09::103) by BN6PR07CA0040.outlook.office365.com (2603:10b6:404:a3::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.803.11 via Frontend Transport; Sat, 24 Dec 2016 04:23:48 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; linux-iscsi.org; dkim=none (message not signed) header.d=none; linux-iscsi.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BL2FFO11FD012.mail.protection.outlook.com (10.173.161.18) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.789.10 via Frontend Transport; Sat, 24 Dec 2016 04:23:48 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.309.2; Fri, 23 Dec 2016 20:23:40 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id uBO4NeHF004150; Fri, 23 Dec 2016 20:23:40 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id uBO4NeJn004149; Fri, 23 Dec 2016 20:23:40 -0800 From: Himanshu Madhani To: , , , CC: , , Subject: [PATCH 01/11] qla2xxx: Remove direct access of scsi_status field in se_cmd Date: Fri, 23 Dec 2016 20:23:29 -0800 Message-ID: <1482553419-4117-2-git-send-email-himanshu.madhani@cavium.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1482553419-4117-1-git-send-email-himanshu.madhani@cavium.com> References: <1482553419-4117-1-git-send-email-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(2980300002)(428002)(189002)(199003)(81166006)(305945005)(81156014)(101416001)(8676002)(76176999)(92566002)(50986999)(39060400001)(38730400001)(4001430100002)(69596002)(80596001)(8936002)(86362001)(2201001)(356003)(2906002)(4326007)(50226002)(105586002)(36756003)(106466001)(5660300001)(5003940100001)(42186005)(4720700003)(6666003)(2950100002)(50466002)(5001770100001)(107886002)(48376002)(189998001)(33646002)(626004)(47776003)(87636001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR07MB026; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD012; 1:GvgVOBEnvX4f/g+U2bqnzRa99TtBnowPmHjKKnkMhVRH0kVnLTKjM5E0Gzi+gssLjlYZZ9UnWcKo7Pp2vVbNP/E1t8/6xNzp8aZAZF/WHQ0fig4IIa5OteBVXgDvECchKbgEAL6SbqjpDySZI5/1PmMyPZUNL0PXSt7Vk2pnogzIYB55W8eDEADXZgSt/OqPeEZmz6cZk/5QMZdBzLQC9VQP1RWjtyoTXJybRBOwELWG/bS+gfwiRP7fN76zl+XJ/VEui68629omoP8/t+sjjBGyFO2wn4M8F/Z5IUBTSYBlfXYPRu4keZv3xTokwb6SozTw0ASHYjaIYLHnWKgI1L0nyW/5W0eJkG75vD6Fe5/3Dpn5YV4rslaYmWl8N0SAdCe12pkoQMiSsfBlvCTRIgmWHA6mGh7l5gRAv45p5UEUp9y/HKCFAPV9RQ6tun5g1O/B0ofwpAHY65e6ZmtfsZvOHorHhMerdjbVyrxceQgzZ90SfHLe1Sm8HhsLTRiRRD8ZsoWwkpmcsXcHln67gygzC/8CW6WHVRfQqxcsH1InNXGZ3nKM+WDsp5268eiS X-MS-Office365-Filtering-Correlation-Id: cb5394a9-f9d1-40db-90b7-08d42bb4a85a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY2PR07MB026; X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB026; 3:3ST5LRWMHrYNYxm0IJ8SYcmoNhe0gJaCvPF7vF2FPurBk+D2G++KaP1ae2KKlkAQi181JMcF8fSqlHQsErTlTO+tgjO/hVNK1bVHO597wNUvbOZAE35/s6kwSQ0NR2MsW/HqTDMwXwnx9GT5G62ORLq05JHP139SQ3tkGTHGVkZDiYxXyGHWMYDyJTgYWaU8RcMTqUZIHCiCUmk4dNG3ILosAC3mOZ537KO14E20SZE41CZ939ypGe6weybjvbM/TDg9L+TehoVcAIHMxb3XgWtBKDSgEpETobWZgn6TmozXMf0jaiRamOvWuFEB3Sq+a0mob7IqyjVtfC9IJmZ8YLCaVuAMNQAg8kPjBB0WzNY=; 25:35SndoV5YIkjDUo1v8tolep7Mh+Fti+cSwnllo+/Uo+DsbJIz9Mhpk9RP6otZZootp1ei0OgPzISJgbBl4hsnu2Fb38jNBzK7DySIOinjrvoQF2nhCWDzBlYCbGpDA5734QyRedfgPGrSEVtf3O0BlbmAF0k2cDIOV4GR/PhPFocL64+WuaF+qsa2pVLvU3Z+8xFoYufs09Wpu/tmPbgBwIB55Zu+PugiB6TN554UKGD8UXA/DnlLNZuKbovQ9K6ZXSgTGl7uqp+QNQgVr4H7lKjzcQ/qumZiiGtEl/AoUM6CSYJU1Z2IG1aTIqTJMAbFPtZkRaAfmGbnhAK0qFNBHEPw2Twt4Ejhx7zPk7SlKV30hJZaww0G/FOKmkeHOJAXAdHsV+1k/znLdMXKYpBQntG1QIQc9SlvniU8UWNWj04KZC4JKcl+2MGkiFvBVobNdzSWJiBW2p9L6A6Sf9xHQ== X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB026; 31:WA0qrRPFPAd9V1p6Cm5TlrOEHzs7rTwRimld2SQmdTQMPg48/axq5F0eJOJRYh0I85eFvA8v6rF46YNMrO54wmJ4IE8tLsoiTNThLmYfF98xd4DTWhJxnf6hN00Vqe8HToADc0cj8jkY1KxheFe2o4cU9dmFYgTn+azwJKKA+G+02bY7CwZG6yCWlu/ZGIoDdUvtrRUb8NnUES6Z0A4wMJ0JQLyYIwko2RpI+/GWt/qf9LCzki3i2070PisAEk2rMJ6pGhuueSX6/wYxKJOaBPuoZcF6rsO4ol3JEVYKsEk=; 20:lw6JAE2JASokDkFL6iOIIQLiK7QxxTW/ffGOfh9b7V0L8/OPt4X/KX1l5Y/uQe4aeS2BT9Aii8KIHGcY/ufNMv/jlsVwDLvc6l/ANOTysX/khwKRHbIUfCycAovyEV4+CIcWEb02LvvChKfBQHw2XNS9PFBYe49o1z2fD4sn6Ws3AmZIgdahqVBxFzVG732A3A16ELjqVQWW1GPLrPuDXhXKkEYfPv1pzFq3X+UzyHUDVrND+JLSdCkj1n3IhYn5lMldpQofGMqPcLmxpcqwdLvhcesNbyhmU7oH7t52Amp1GCpj5kYMMmJVXWNZjusINDPdEe5GBNsKmwgkBzaAX1eELX2S1VAIOeZL1r4X+VugdDnk/K0S1zX/dSF2G9PjC+NWEBZEQxQ9CSnJok4i3dsI+ZIGs/WBaS/Eg/P32OWhz+zihKOIFKWQjUturqWs8dPEVvaafZfJS8StQO2vyh94aICqiHqyeUbKyW/FqQaYhgmSQcDMeIdOB/G5CyPl X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(13017025)(13024025)(13023025)(13015025)(8121501046)(5005006)(13018025)(10201501046)(3002001)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(6072148); SRVR:BY2PR07MB026; BCL:0; PCL:0; RULEID:; SRVR:BY2PR07MB026; X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB026; 4:X1sqnuqBE0uol+e/vAgxbIq9Q1A8DoGD6B2vDQf0bMfedE8SMcqyJJ2XTa/EKGn5+1xk4E6kcV/+oEFRNi2MZg4it5HGvoRM/dL0Bw8Rec5S2Z1U/t8oh3yUAR/kIA2dozEt+xEvuxYEewfeUQvu2aVZETkcPU3OcZrile1zbxKh7DMlNp77KwADwY1hOb7wbps6xZc2rj/och1vCBMCCgIkRibdyhFInzcEjlvGnhjLcUZHSi4RgjfclHHyDR61Karew/A8GW6e07eIHXaH/H0XoNFFPJRGxiHGhCQGqFe/YpSHhPN/MP9x/oxPvSZYWol7AifdEnLsBDTb/YEbW2h0DxVPeDjsF1j2k0cUAlZFuDzzJYINtIqgNhOU+IaTfqb2vB/dZLygmg9d5EPzzw+t2uIgvz8y3NbWRX7OyHWQaakDRW/uL+Gp+d54Tn+VXaCLAtPZHdxdKWXWDGzJDavWFntN3149u84QIvpMIcs56LhIljypwfjX1etiElE0iV3oo3KB6ydtOv+bMgZoiNJP9RDTVK4xAhp+i0HLyl/lQxX0AzEhVmEiYy3aZ4xijLiN1ktTTbKiXTjCfIBl+4FzlWLJCOgjupEXy2DLAvmHCyZJDU/rSgKnVqa+jvND6oJrPh5MYscN2C9VQ0qcyf0QKHozUvGFb9LNNhM4XyE= X-Forefront-PRVS: 0166B75B74 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR07MB026; 23:T4h+AeFyG9vmCMkiKE9LJMUKNlnOP9xWnUKB0LiT4H?= =?us-ascii?Q?m/gCTKF03vacKLlmSImLfuRATvtblB3p3oxost9TDK2ZKhm5rpivtNoouEeR?= =?us-ascii?Q?oh1COrkCPaoifIJLj7OasR7ZCyHEWpQnnuUFCEnKpRa8fbW4JVo7Jm83Vowb?= =?us-ascii?Q?1WGKE95+ZPHw5Bk43Yl8VMb7Og8BAvV0redSYkU3dFVFpRXRT98NEY0w6c1g?= =?us-ascii?Q?69YGx6mCfHRRbUM64RDFHAnrHR287mGvclpIc1WX+p2bSPEieF0oGPqTvNQB?= =?us-ascii?Q?WUp6ZdSd3YnRo9c/Sq5k0kw+ANEUDL8DgwLElVYHhZDKMDwRAl3LmtrjO1xa?= =?us-ascii?Q?bqeGpMv8s7d9lLKef75zP9UK8S8lsNRhvTJYGqR0/PaNQKG2g0UbWRy1/Ykd?= =?us-ascii?Q?RDAmW5XR7dfVIgk83NAVW2oDNctvMkVSC9hCyRVdH8gYr0uLQ00O6fETzFZf?= =?us-ascii?Q?SEFBHqFeldEnez5+5pGM6CfzcUsLGB8V7Pl5tq/zfOuZ/fFmRxCgTcvT9uj7?= =?us-ascii?Q?fuVdHT2MnLumfH3KHjlKRQEfNAhHkyqwRIw2he/H5F/r8RgzqaP5tgHL5ppK?= =?us-ascii?Q?7LWud82br4xpPM4bSiqsb/9MVO3BS9JelCHeOYikgNsUmYD4qHgBUoL0bK9H?= =?us-ascii?Q?SXlW07CzYiKjYKAaUT/k6WuOwBlqw55t5GhdwhqPS5APwTA22BzXWSqaQ3iS?= =?us-ascii?Q?YqIp+XTDJB2CCrHEN2Zhfr5Fhd5YPDemdW3Y0Uj71oLuxx5jf+qh4F4SGMhf?= =?us-ascii?Q?2YjWrNv0DE7UYimx+Vikowt0G+1vE34vjKN+QheASvZYWqpcQN9qBSUY3kEU?= =?us-ascii?Q?VtUcSN+E5q4b1iqjwjVQkaM8BwR7NsROEVGgA95p3xHVgOiQVzool/HhLEPe?= =?us-ascii?Q?1ZLVezAxxaeVj353JB0zXUO7+FDK/r2ocywtN7aT+UEeHAXCZysfZN+eTkk3?= =?us-ascii?Q?3AOA6P6SXgc0XOebkXcZJxOjOHhEFguhYWZCUeVmHZHm6okejQVX2JFUTB0Q?= =?us-ascii?Q?8GWjAmdWtf3DAwFAaBdo+2fonlwaEksuFR9OYOnyubdBvTcz07jGhTBgDLN+?= =?us-ascii?Q?5OMZ9j3ugy9FTLC5SyGHn38rX9SBz/F1gHetUAWK0jbP/g/ibmxXGYyTpkE5?= =?us-ascii?Q?1FitnWMtc=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB026; 6:IkWS/e1ay5BJOybQkOc1LGWLve7Y8UVsyugfYi+Tw2miaJIVUCge3sFUlzh0QcvUswOLUAI4sFUfHMOGImch3b1fZ8oO2P/p40y90tvAQ+9DR0/D1B3+IU/xpJsfNvdU2Z1Ot9MherONOqKS4fhXOqLyhLSwFKPATf/J9hLYMbKc1GJfWgVZPgTkSI37E8uD9Oo2WdDJQVI6+lTr1qNmuyS8wJZAfk1+cbd9ktGRV5HxUFGm/ipz8MpWtvsAO3BP2kSjYKwCa9dwf6cj7eW7j0Ykvb/ClFn7C6y1YvGPqSUtJCyU5pNuqE4CThxuB95LInTWkwXXml53rPzsAlAzKiQ61ljOKGsgEXlaWKnu46oHN8DM9R74LF4WL/aaROiQ2pp9tgy6ypgPbxuPxvSf2Ln9fff5ncx+lm29NLR3DTs=; 5:DkDZH+ls2N+orvrs6FA64WoE2VIWpFma/QYvnRevbuIoajsSAO2ohbbaDujoXEm1ktxPF0xJCkX2gTER/uPQmnNryt6QsE5mEH9TgycUrmwPOhgMNCqoHrADNHlDxPGe3ECG0abCWUMRThO5gX+wZg==; 24:vulxiSASy78rvIk+Tk3Ly/YffW4zettwmWsLU+ry303Yf9Gf50Em/2cHysTonsVzHp8uwYFkCztdM043oAKCULvfj6f8uaye8I0ES7tAV+w= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB026; 7:fxzvCIWS+6AdaUjNp9G85W9+tGJEV4orc+lrSIFATSWbmRP5NrebPo/vBhcYjlKcAZoQbjf2i8zy3LFhdONEeYpuX59c5BEBz+h2QXAXc6T7Vnsa23j8zCm2Oew04D+8HTiIuuJmm7MA/C0ZTzu78g5dnymkZtJ9DX6syLmHt1PdhW5V9nmFZo+1h3vEtUtcufH02uoLHIzTRQfcfw55WJYgp6ewehBI64KL+th/n3xmLZFYR4+CA/rLqtpG4StdeNMpaVeGj7fyttwpd9lJj2CoiZOOTH6T6ylCZ7R8yoPmLYE6qe26XVOqXjYPbPiEeyM9a4d84vCaLOkSawDF9w8C5DagURhXhPdIRyMjyv1JAOHSh42W/IiR3BEVXmf5P9RcGAmkvkh7ZJEdrXOinLEW8ANdwGNt2w4OQ5ASmuO46GKfVqSPQibXsl2ydPyhKj74T2osgGHasf5SX9Ji/w== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Dec 2016 04:23:48.1109 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR07MB026 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran Reviewed-by: Christoph Hellwig Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_target.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h index 1f7c6d2..1196150 100644 --- a/drivers/scsi/qla2xxx/qla_def.h +++ b/drivers/scsi/qla2xxx/qla_def.h @@ -1794,6 +1794,7 @@ struct crc_context { #define SS_RESIDUAL_OVER BIT_10 #define SS_SENSE_LEN_VALID BIT_9 #define SS_RESPONSE_INFO_LEN_VALID BIT_8 +#define SS_SCSI_STATUS_BYTE 0xff #define SS_RESERVE_CONFLICT (BIT_4 | BIT_3) #define SS_BUSY_CONDITION BIT_3 diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 9c6cb75..47acc26 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -2288,7 +2288,7 @@ static void qlt_24xx_init_ctio_to_isp(struct ctio7_to_24xx *ctio, int i; if (qlt_need_explicit_conf(prm->tgt->ha, prm->cmd, 1)) { - if (prm->cmd->se_cmd.scsi_status != 0) { + if ((prm->rq_result & SS_SCSI_STATUS_BYTE) != 0) { ql_dbg(ql_dbg_tgt, prm->cmd->vha, 0xe017, "Skipping EXPLICIT_CONFORM and " "CTIO7_FLAGS_CONFORM_REQ for FCP READ w/ "