From patchwork Mon Jan 16 20:35:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9519399 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EB12B60209 for ; Mon, 16 Jan 2017 20:36:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DBF9926E35 for ; Mon, 16 Jan 2017 20:36:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D0A7827D0E; Mon, 16 Jan 2017 20:36:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 60A4427CE7 for ; Mon, 16 Jan 2017 20:36:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751216AbdAPUgH (ORCPT ); Mon, 16 Jan 2017 15:36:07 -0500 Received: from mail-by2nam01on0069.outbound.protection.outlook.com ([104.47.34.69]:3347 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751177AbdAPUgD (ORCPT ); Mon, 16 Jan 2017 15:36:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EyZiUvf92X3h69j+SJ/VsjuVTgYaTVafz+zMMT55ynk=; b=ZbVFiJ2GsY08ZFhzCsPyYioYxRtuYk2nn4dm80ae3xv+uxVFsyHtgJbiYGZ26YhgSAwj7EzYtcg4r/ydHq/34bYP8gGymjT7fkSoFLTq9nwGDL8LrFPL62Bs82M3h8/9U04yStnfnf0xRklsaypJd8CFvl6VHVqXzP8IKCHrUPE= Received: from CO2PR07CA0037.namprd07.prod.outlook.com (10.141.194.175) by BLUPR0701MB2084.namprd07.prod.outlook.com (10.163.122.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.845.12; Mon, 16 Jan 2017 20:36:00 +0000 Received: from BL2FFO11FD041.protection.gbl (2a01:111:f400:7c09::137) by CO2PR07CA0037.outlook.office365.com (2a01:111:e400:1414::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.845.12 via Frontend Transport; Mon, 16 Jan 2017 20:36:00 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; linux-iscsi.org; dkim=none (message not signed) header.d=none; linux-iscsi.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BL2FFO11FD041.mail.protection.outlook.com (10.173.161.137) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.803.8 via Frontend Transport; Mon, 16 Jan 2017 20:36:00 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.309.2; Mon, 16 Jan 2017 12:35:53 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id v0GKZdmk029099; Mon, 16 Jan 2017 12:35:39 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id v0GKZd5x029098; Mon, 16 Jan 2017 12:35:39 -0800 From: Himanshu Madhani To: , , , CC: , , Subject: [PATCH v2 01/12] qla2xxx: Remove direct access of scsi_status field in se_cmd Date: Mon, 16 Jan 2017 12:35:13 -0800 Message-ID: <1484598924-29066-2-git-send-email-himanshu.madhani@cavium.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1484598924-29066-1-git-send-email-himanshu.madhani@cavium.com> References: <1484598924-29066-1-git-send-email-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(2980300002)(428002)(189002)(199003)(105586002)(4326007)(2950100002)(42186005)(6666003)(107886002)(2906002)(81156014)(92566002)(189998001)(305945005)(54906002)(4001430100002)(47776003)(39060400001)(50226002)(80596001)(5001770100001)(106466001)(20001)(69596002)(4720700003)(81166006)(38730400001)(36756003)(86362001)(50466002)(101416001)(2201001)(33646002)(8936002)(5660300001)(5003940100001)(356003)(8676002)(48376002)(626004)(76176999)(50986999)(87636001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB2084; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD041; 1:dmHkXTEFgu5FOYX6XRGwW+WLwUmKG5gMmoFrKRwF8O5k3Dmp+8EqyY0wu5BI87BZttaj6lUmdUkiEGuF0MmSp08CjWo3q2BWGPPCh1Yp/s1P2UR4oOaAFdeytnzzcC5yTkX3UjJ03wQ1HsJdOycnYUsg1ltPRXbimpcQPoQDVFJJxdhMoI1uGzZ+3MOhvDHEFlsCa92k7BxUHuwG+aXtrijJ/SYLUnOGMPa5bfxVtxXPdOF5HWS4SQoEZl0nl31piIgTGCcGfeDerDgt0tBgHM4hF6ny1Y8aZZfqae5kokTfz1BePUtHnO5kjneOLHEIicuTOYHYQ3D7vaSXOUyEQt7wXc1EgBOw/o6AwuflNFezs5AEEa5d0OUJoJlvUWUUkw6+aqzLtaKdXKwKw/zUzAMXqvvvzkfrxN/mxpnKtc3QIKmmzmUPTpu/Hadhc3diggKMkNh94uiF0r7HFJt9RtfD6J9oO3oVQpz/5cZ4jJAT0ZcL9rlvGqCuUaiQeunMJO/m7Ddn7qStl/lsLRrUkQ== X-MS-Office365-Filtering-Correlation-Id: f25ca3d5-9be5-4ae5-8ad0-08d43e4f4898 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR0701MB2084; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2084; 3:lE/VAlHM/Fh6joxIgj6H2OVVw8JP6ydi0TCY0/sBQwkPz63mvutv8t8DvhDe+qb3a9lWX3O5aPkGflBDo8vZaffpD4qPTdmXeBwpF4kdbEQSNwt0keAiuap2+SdAzPXTeQjWQrn3U++Z6yANVqQzVyOUXMD8EaAlC5hXk2RCA+WTsFiVHSRue84UJ9ROucYw23kgCJT+YDob3Ig3HCnPnLMiUXBkXFgltIPSJwtCpE6TfMROe9vr7cNSVoFRZJ9xg2NrQUv4I4b+x64oFiPs7FdNalfqtwidGIhzOIo6M5k3zrYhZ/PqpyhCpAUyTJy5BJrGSpb+gAHYjYRoT8BaNI4XpQeo1Y6jJSPLp5I6/7JdZDBlOkiRAFQyOV8TUYHf; 25:7+IHTWAuvu31F+Sx82IYDumAWwwFSsh/jSkYV8mmtbrqEPzugwuLtMQi2yK2kR3yg5/n6jlSI+MbfUvKpbCCnJmsMoULvw67Hl4T6g0P3zZe/THt955ViVo3cYknnXCWxAMu/gOfQHuDQ0+8suAiZLaId24o/fitPRrLfDNYCsE0pf2dAE1iVBSk5N9TSE5MR7fx9rcmCPoEnivv9wWHqadezQnuYnC9HFkLWhXaXVhnWB8IN2+AoXLYbJfoRozxiC4+lYNdfa9/UWDqNc2ifN3EJMHPLqSxiGXy98zxLdwC3p6PcEuOrXJx9Ylk30DnybN+wqiR6A9vrYRCjZ39NTbPJnuwUZhrzhFLbO/0MfCW6SM2+WCrq8gJQuiHtWhXXTGXp2NX9D4YhZeqNGao5yY/LsUaQafuDa85rcT9p6b3GcnptwOGPunAavm+xPNfkqmWuIKx9NGvFjDxaEnbBA== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2084; 31:BXvIloOKCow/BsxH0luEN8Eh8gPBkpSrRtlVQHXO28RV7zrwL3K9mUbiPDEH3cPUpHsDJPhNGrCfNSRiTMiOXCBKXj0p2vrga20ckovkQl9D+eLVUwZh9q2f6j5Y9hNDqKnlPO29iASIdzG81Uwgova9OnNMzG9H+NT8imnJJSXym6jApAT3UqZvBbekaWhv85CoTgffkGWtTW+qXXdyQ+kjV+OUOH3nSE81gpxyF8Fyke3TCX/qDAuCy5/Tng+eTcQ8NXC0XXb0lSYzdgHPOA==; 20:fHBNoz+iZ+kPUBRrWwBVWA73UeFZ8gVTa7Yd9dCEBrScK5wKw1j+dwi27kzUlCvXPtXLmmhVP53OIqQqHOy2WC0bQLbT7gJJ8B62CKWiT3/VxSH+iT7/7qAGJGTnsElaM09Da/BDHpterNtvdy78tjiHHbVxfeqU/gVYUEMLxAhpGJLqTmHTXrYprXdS3pt3v8fm6PPXPKyEe8EQWYiptId5yh7dHB+ea1N4sXB6md5DxJY1m/gdYOe6lG6shaFrzcz210zIRYnm/5dQz6YTKlpa9BTnaEuQVl6gDFy8P5tPVf3gL/x9cWe+cQQS9CepCZptI0kgfjpWl/MEQXpLEGayewFcyWljOm2n3qRBHP76/RFsbPefG7C7JgGGhpP5lAYcf3HWUxP9IfTkipLCM9U1z/83y3tPSE251hUc0BS6Naab/ckwvT54iGAbJbfK0RnN9bV9PqpudiYbLclMGPapEMsbuz/WYVFW2nscdd1BLKwUibmkHjk7dGDYz9fL X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(13017025)(13023025)(13024025)(13015025)(13018025)(10201501046)(3002001)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(6072148); SRVR:BLUPR0701MB2084; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB2084; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2084; 4:fnlcWnT7hbuY4UCUTtXed8SR5+yoOW6mQvSUR97HrYBNvP4eWBXvVyIt86ME3u8FrhoP9f+vhnMoKc1xRYVTvSusPG0AtNWajWuhMCzkwl5B9FIlgM5JRyDYVaMIafT2kV6DzIlYqYVECcN2Tc1IYrFQ5CJTRB3hCK537eL52Uwy9gIiGT7+qFCTgZ4/VZ3uauETDrmH+snGvWnWr+j0brSWfeJ3NFfAs3uOl9DfSu9+EcEJSKpBFj7WiEbhYlPHuaAO2tb3BTlshH6NmImYsJs6dEuobtwzfFY0PZ39GrTyf7BHb8/P5SW3oqEgsoUxZmjx/t4hCucWLVghLxXeXI0YVnq9qt3Rjmjjem87JzN4DoRI2hDNmcy4meok4ibcJe32+Z55k2WiRb6nVaFrDazNS0IriVr8YpbNTkKtCm34M50KuJsfALzxsSnQ8ZGwM5a4GgYUO+NSBt/nsSxy7uqYciD+S0NZb3sKR28/WEmlqTo/CYG4hno35ZC+ix+/4BZu8fItMbhf3P2xRM4GRTA9IuURK8z7E7lQ7G62dHBbB2Zs0RQ0hZy9Da175QmktnBpDKxsqi146BnyXr0LXZnN9TylfE103ZQvToRBN86fZ5h6rKYuqA+Slq8N8HLNzsLZgFW5MA/AhoAzZJoHT+S7+KLDTPsQtzzqtKvUROI= X-Forefront-PRVS: 01894AD3B8 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB2084; 23:5i1nr75Cc9K7ChHfbjXpqdasftitl903UILR10G?= =?us-ascii?Q?9SvotYOdQETfUnfW73ncM3UqehKyoRdjXwox0rFHszF8/B0u0baHLjG4c/OS?= =?us-ascii?Q?+6zt+FAzdAHnYFerN4otqDFX4QCmKQcpjTLv5XyzKj7AudfwerLEYT2zFqVj?= =?us-ascii?Q?DsIk11ntUCrEQN7tiJ/qJXWH1I8GHxwB4N/i2bvjW6GWtRDCGrQ1f1XjZgur?= =?us-ascii?Q?WF9oNrA4okD3AJ/R2Z35NFDRLO0EMSlI088MHfc8O2B2rXDSeMiELNPm1fuU?= =?us-ascii?Q?W3NS2hYQX3msmkCWzXLIq2FW9sWKFs0npdo5dy17WW5Vxyf+RoOJIEJJoXKh?= =?us-ascii?Q?Pg+1sX6BFzsHTVKOrQDey8YCNvh2Cc7UHEUECpC4RgGUY0pc/YPc7JyWZyOn?= =?us-ascii?Q?MgzGuSF3A9pcRtF3HNt92CVDzl8Ek3QsrISPO0RM6LvjafmWffh95oDPZbMo?= =?us-ascii?Q?uRLYkuo9Z3Q8YvA0U1j6rXTUWEEBVMP3sU3gDET7YR9hhPVA1tHr2RatH7QI?= =?us-ascii?Q?II1jHF2qOr1ycFSuvcrJzqJSp/DVce7hBw6UAKuTNnl9i3ryBjcCyYEsUfOn?= =?us-ascii?Q?p3VseNmWrdKIFfb7+ZlqBQVSIeyZyVVC9xQAsTM2MRyKncvFWCrvdhJOr8eJ?= =?us-ascii?Q?2Wkz+KvPuG8UDrWxuwfIYwvoDnBEK1XR1RBD4b7au6mT3eV3RMX402TMlBXX?= =?us-ascii?Q?c00wK6qK92/123kPB0P86qoJ1Zwdou07DH3G2uHzVSF1l0miSWDPqDN9tmSS?= =?us-ascii?Q?NyCT8dVQeBSbFxdy/1joLt1jJLSNEZTW8boNGwkB+D/xO7Vng3FI+AB02TR1?= =?us-ascii?Q?cfZ1jI30IhJt1rZ7DHWFQEQomvFYTn+Qd9xYNGPWYMgoLCOiWAouNn96KSV8?= =?us-ascii?Q?YCu9lHRs4N/e6UCvCTfmtwAKzg+fQ55sA6VHExhIWkHUqp9CeciyfvG/170+?= =?us-ascii?Q?nh3OHa4tzM3yPPMeeQzpzr9dcfUDZBKqs147qWP4P/oR/ro7tIBDdji5bwme?= =?us-ascii?Q?O2ZoFTHh2QOR2ReivdSTCC3Je//Rp+/kSJWozGKqztkig+H82ssFZI5GYwls?= =?us-ascii?Q?uVa2uqPWmkpCA1fWAEcaQUWQs4sD+UZYciW1Gzo7GEmsvNTL7RaHCH5YJuKO?= =?us-ascii?Q?03hLhIHKLVfYd7PP7MyOwHcY2Q1ERtAg5Y5LlJQiAxFQW9L1pn50FCw=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2084; 6:qN7J4afOqeqZjPpSrCnYKj0bngV8/kD0bomZ639RgkJgV4IHivpJ0hKCtL/HWs6aOspILaEevtKtfW1M2frfRHR4JDpoMhwPcmmVO0tyQ3D9SvlO8S50dKze26dRI1XbA9G2qoX27z3Mm+ixW8wEK9wtK7p5c/OQOjfcK/4MAnG+xx+OCOoU7FX+aKAG9Su5Bx6rnP5k5AxfFyBoQznSNa/y4KGGdYtbiuTddo3hNIGj3hKN2T6G39wz/vgPTRB0h6vRQgwCWrLIyMyxFOWmgMqJrtqSYKONOb9JybcDML+JPGeya/4LjLRJ7PIF33kedocR6dZDVxJo/5NHeX3vRsrqlVEVcZ/g8pY5TRH56nxkoatu+aoGJqDtpa2xDuAVnZeQLWZrzNHwiJsVSevlCrqwSZ7AyG4icO7nGD2KePo=; 5:WnXpEGedfureej3rulfEm5zAlPRtC71WF0Jvw8me6UuAeepj68CEXj59jm+Js9i5eFIpqi/pHxO7fR/K70qrv5AH2lv9ipj7ASlW3rZ/sqvrI8IkKjQXUjDEDvCb/Ow2HsVM70TE/7DdKN4BrfBDP22ZTcmjppulJxzFBTI292E=; 24:apdk9DnIfqdPCB59wZ716S8lKOK56cd0mqHlOpX9yY7l6iLT34nxNN0Z1DQv2hMRUg6g/UWXDwK7d8ZU6rHXruYrx4j6tK7GK3bU8u2OWC0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2084; 7:JGV7w0dGrHh2nV1rPNYW504l4uh19L1hF99SNwPL6cxpQedHaAIj7Ec1j5EOKMV3G/n1waZNKo97sby8606vlI8hVj1EtnOTWi7X/5ivOKniU1zDgdRpsRdvJzVT2PN2Lf1pIe+CcsDseGQ250++AaWpZ96tewaxpgqHyNftFqruC21sz5RKNkEM9WjdTAUNFiPRtXpCbOSLCqTj1zsp30/mJ0VxSsh+Ob6gT6ENQQivr+QHtyDwEyQp20g9oUNwR4DSNrjj8ojUhJYnQ4JIZZqAdMPwmnADPM/qvHohuRJ0JSSSWkoSSzRyREktBq8BXLPVKzQZPtADBOJor9ZMPzz/Ti8tEAcfrrffmOFHEPLPAkGyZ0b1BohbKY/TguSQDx3ajz2f+h0hI7v96Lbf0R/aOZuFxgLC6UhCO/5bGCbL+PsPiA8O7l/CpNCGPJdmBFS6fsdMzxSXPu3U0l3O8g== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2017 20:36:00.3789 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB2084 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran Reviewed-by: Christoph Hellwig Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_target.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h index 1f7c6d2..1196150 100644 --- a/drivers/scsi/qla2xxx/qla_def.h +++ b/drivers/scsi/qla2xxx/qla_def.h @@ -1794,6 +1794,7 @@ struct crc_context { #define SS_RESIDUAL_OVER BIT_10 #define SS_SENSE_LEN_VALID BIT_9 #define SS_RESPONSE_INFO_LEN_VALID BIT_8 +#define SS_SCSI_STATUS_BYTE 0xff #define SS_RESERVE_CONFLICT (BIT_4 | BIT_3) #define SS_BUSY_CONDITION BIT_3 diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 9c6cb75..47acc26 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -2288,7 +2288,7 @@ static void qlt_24xx_init_ctio_to_isp(struct ctio7_to_24xx *ctio, int i; if (qlt_need_explicit_conf(prm->tgt->ha, prm->cmd, 1)) { - if (prm->cmd->se_cmd.scsi_status != 0) { + if ((prm->rq_result & SS_SCSI_STATUS_BYTE) != 0) { ql_dbg(ql_dbg_tgt, prm->cmd->vha, 0xe017, "Skipping EXPLICIT_CONFORM and " "CTIO7_FLAGS_CONFORM_REQ for FCP READ w/ "