From patchwork Fri Jan 20 06:27:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9527493 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 96BC460113 for ; Fri, 20 Jan 2017 06:29:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 86FD12867A for ; Fri, 20 Jan 2017 06:29:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7BCDF2867E; Fri, 20 Jan 2017 06:29:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EA2422867A for ; Fri, 20 Jan 2017 06:29:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751393AbdATG3J (ORCPT ); Fri, 20 Jan 2017 01:29:09 -0500 Received: from mail-bn3nam01on0061.outbound.protection.outlook.com ([104.47.33.61]:62288 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751260AbdATG2s (ORCPT ); Fri, 20 Jan 2017 01:28:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EyZiUvf92X3h69j+SJ/VsjuVTgYaTVafz+zMMT55ynk=; b=esoMbt+3aZiQN2lECSFnNo0ZUrTZzaWFdHNPTNya85Msx5ssB3E/OpDlpQyS3V/EXKXm5gwc+lX5hipslV1qhX4Jgl6CwjCGmU/+xwBhh3JbcQUveISqnGoMiohgvLkOtFhu6ZbKQ6Q/RehVi2/KdYSxjL1owmmfRwyJChdcQc8= Received: from BN6PR07CA0044.namprd07.prod.outlook.com (10.172.104.30) by SN1PR0701MB2095.namprd07.prod.outlook.com (10.163.132.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.845.12; Fri, 20 Jan 2017 06:28:14 +0000 Received: from BN1BFFO11FD032.protection.gbl (2a01:111:f400:7c10::1:121) by BN6PR07CA0044.outlook.office365.com (2603:10b6:404:a3::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13 via Frontend Transport; Fri, 20 Jan 2017 06:28:14 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; linux-iscsi.org; dkim=none (message not signed) header.d=none; linux-iscsi.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1BFFO11FD032.mail.protection.outlook.com (10.58.144.95) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.803.8 via Frontend Transport; Fri, 20 Jan 2017 06:28:13 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.309.2; Thu, 19 Jan 2017 22:28:09 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id v0K6S923001289; Thu, 19 Jan 2017 22:28:09 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id v0K6S9s1001288; Thu, 19 Jan 2017 22:28:09 -0800 From: Himanshu Madhani To: , , , CC: , , Subject: [PATCH v4 01/12] qla2xxx: Remove direct access of scsi_status field in se_cmd Date: Thu, 19 Jan 2017 22:27:53 -0800 Message-ID: <1484893684-1255-2-git-send-email-himanshu.madhani@cavium.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1484893684-1255-1-git-send-email-himanshu.madhani@cavium.com> References: <1484893684-1255-1-git-send-email-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:CAL; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(2980300002)(428002)(189002)(199003)(107886002)(8936002)(2201001)(2950100002)(8676002)(189998001)(81166006)(305945005)(38730400001)(5001770100001)(80596001)(39060400001)(6666003)(69596002)(4720700003)(47776003)(50226002)(4001430100002)(356003)(86362001)(36756003)(4326007)(5660300001)(105586002)(33646002)(81156014)(50986999)(48376002)(76176999)(2906002)(626004)(50466002)(106466001)(92566002)(26826002)(101416001)(5003940100001)(42186005)(54906002)(87636001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0701MB2095; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD032; 1:cOMC6nwbd9CHaTfHEv5oH0Vxc0NsL8XZNVbtkkG7QTgbnOtUEEPdrslryp36ghbOrv23/MxRSrG7o1xmZR5yjHSE82p7Yzep1rhvO0cNpufg4R0RQwaQJ99ifMn/VWzJ1vBattXUUxJWt3XZA+GAFKc/XUT2oFM/1zsRdJYJk9hwby1nuimINlNr6+l9uSNULzAuYMaFbz7rAtWAvHA0vXAvhRDwmqY0rOiqj8ddJXVIbJEgT8qfji+wmy6rjUU4BSQq9jkgpSVEsV3g80bkvvulUzutYaMfhewqVrl1pxpKLomuhQYLVXpc/uPjTK9Low379IhnTrFy4lCj40t4TYXjoCNu21N+1pkN1xtwk8y585pIwguuWyFx7bmBMtZFdhkNdanpG2wIXjc4Hv7NmPE16ACT2w8dgqEA6cFnRg3nDv+5zBFzzzCqjEpAfKRiZS5aQ/0vagIEdRmYeWt25Zyzi4nPeTzwmEcyxaJB4j1DuZjdYOrhHUlz+WclVMP+ X-MS-Office365-Filtering-Correlation-Id: 5596a94a-e367-465b-e653-08d440fd831e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:SN1PR0701MB2095; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2095; 3:jbVNVmnRoQTU9Z4GzUeJc7jtsNdiwVbuwLJBHHkXQZMmKUUWvGtckWjm1yXTSsPdSR6RyMYo5RH1oc6aprJbNfUQCrHR1duoUCYiingV5pIp0PFpF5P2YDuGEMsjBKAfyl/Esy0kCW9oT5tGlR9IqjGRmU5feUGHg922E/vWlBVr7mO3U9/eENzrqbwWk32xhxcie/rEtavm1UBtNEf2Utqyc9vvxcBQKh75RWFSphcZwvvQvx1utOmT+xZIumxsylWZBenMtLsfqpqjC5jsRghJZEFqbufWkDyQ4EbgFyHB/qW4r8wuWdUPIDhQKRiEVUsUl7Wa5PSTf9kSY4UoygBP4lU/MX1KlDT//483O28=; 25:s53aLyJ8ojk2CNr3YqiRmnSj6mwivqT9Ja7YxM3qqtlLVq/s76bXNYiXNdSpSEIVBo3tJ/jhxvzaBwJCCVxmL8mH8mrea0Z9+4HF9yPe0LtkgBmlOZecT1jUYCaLooswnLybpybobBM11pNhfT42pXl14iueCffaxrh64PKl3IfttQTcsLyikz9KcVuO5dGMu77DsmZJFLZLbpEfZMCwOhmCpE1aM3Y5Ho/zOWIQ2NoXQGNPny++vJXvZ6igujjrbet3EsJ5khHXXm1J2dFq6xjQT5kmWV5thGyHsufhVJYvbzyGtjaRAxY2Kp+MthLLbS56VnKxwB8VD0ifQBcB83qPTtnzTwT2KEvwMz/oFrINcHJwTLZu1WlZICmUGp70H5x3PtsArghqQsRWz5mlb0xUspmBxRRNspzUvj8ILEQawAwkKGQQJxc7wXel+C+uJmvLxV573O1/xZplsgWe3Q== X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2095; 31:YZMs2isjSuz8EVHD/H4PL0CsPYzpCbnV5qg48anLBfOE7kZclNW6Dit63Qnipa7UHhRqBVh7xBErOmR65yvLH8zseLeWaPSXB7R/I0OMFT8EKJOpaZAtlXMM9/8ywR1A0pa8BYP9BLu5mHcYdMhkud9uNTLCuWinfLjdA6Cm9LHPPGsZRmf879pgevYfZ5R4qGc5PlajkgfVK7uqhoa/UfDmv29aRXOCwBjs9XlQOts+RJHQOAxOuOf0b8vZvjzRuPjEkgZcArNYG3QHk2nDZA==; 20:KvVJOvItb2Y/faSqTqxymJgDey0AoEhJXj8WL0sOomI8TpaqpEYjpr045M7V6E6Lgar01uZKK2xNJECFUqX667Sw13t0VnwLRxcst8AziUYYvfXzVDGHunFQ6/b4KpqRfUev9uP43toGr21r0RMeZkKCWfpo6LZzp4DRyyV2VCMCcPs9dUvL8jLixwHfKF5csKQkmhsuT53eY/RCCQvFX+rH4yLEzFGB5qWsxrjtIkw6CYGRnsJI5a3aPaHD//T2OpiNl89N1R9D4wsP0E/VQgwcNFdQHaC2JjRV7pYJUcSbZQbiisriNOA7HoEybtvJsloWZNZnGlJaiSPGCw5nj2r+Lp87wX1t1XY/8QQFIwlVEPDredvco/ASwC6iwFo+OtcgSWZtWd+iZzt0aqSb382DVtNq2QmB42mOkt0wVailQmEKw64rVhHsLgAZ8IzDG6BUP3Rg0DryluWhCCbgN+inZEjGlLkDAZjvV1Weuj/GlNfsJ0Y+JfZ3S3N1MoqP X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(13023025)(13013025)(13021025)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(6072148); SRVR:SN1PR0701MB2095; BCL:0; PCL:0; RULEID:; SRVR:SN1PR0701MB2095; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2095; 4:bwgnIvdWoHVRiJstTfJh4lA5hhWYZdCiL3PKvjussbnZrqwAVP+98f97PwA3XHmeXiPJBadIHeFmI3b/HLUnJy12pIVkuN4lCsj/8cxE+CfzBGENzWPJNJnFFAExXv3xiKqbaf64GFIxlLykQPPwoFUdNzjz4YXDsEaUMrkfNkE65Cdg4MTwiAkGEo8ZeiNyuwmw1Pxogrw1URKkzZNr2XHUT88norAF5dgWkK0pRnUfzCMgT/dGQI5KA63nGJqNVa+5CxDyDtDd4dgKuYnuwUUqxRy1+HWZCxgzDm2LSk9Icz/bwt/IoAarkINkWb53mfjdq6nz0qkRkRmmMkaDcXRXBz/+QlzhyX4C455PgV1h4TPh4ddamfiYZh10pNBmc0lOG+dhreNlTK1h/vXOcKbEeWXgSDsqkhVTsr/zAXOmtxRvE7a2LBng7rKFLh9PBSKLiVw4Yu0rRlgwhfEvNCD7E/0bIRE2T5wxzF8gEsMQtf8RbhsOj+loeKO1uPG83KLG1+3bKjd50Vp3+q7CgjLfyHNLSlba5vJRvzLlnubKeEpMaGYXhKvreoGFW3I09m30g6E7/cofp5X8RRSD8+Hnj7iMIhB85AIL6QjFIzQYF/mpS1H+S7Y+JI/OrNiW X-Forefront-PRVS: 01930B2BA8 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR0701MB2095; 23:K7UCgiR67XJ/swjuf6hzTbiBgEZMfvYJYP1Q1p4?= =?us-ascii?Q?3CMCsSCssfvQEteASkllg4QwBeLhB97Zy0mYqwDhFbdfNtRO98+W8FHOdys2?= =?us-ascii?Q?IL02cJGpmjjcbr7YTs9qb779Pm2bVCciFHIk0NCGyKfF+giwCT9gaRDZ1b94?= =?us-ascii?Q?JRgGh1pdLqUwDqjmJaFiteISlJFxcewlb8CjWlx1gllz4qxu4qC59vCZscij?= =?us-ascii?Q?jK9acSUT0AWA25l/z3pYMiL/6NXCof2xd9f8Mso4ploKE4EOF+5dyiGtSAiB?= =?us-ascii?Q?+ig07BpVV1NhhFNsRpADLKZIFVX2ZE/NN7N3fix0MXE67IkHPNwkMuTFtRVE?= =?us-ascii?Q?26g7vOW/AU8tig1PtMMtPxBbhprKA/hMly5/LxErPqmBJ0PC9OvjTY8OzLpV?= =?us-ascii?Q?VKRy6IySh4xom5hmPGj7p4Nmf65ICz+F0tV5QTChDR4oh8ZSfAPRCfBMObVl?= =?us-ascii?Q?S4cwhxSR+yxAerdIH6PGyFzrZx2uPsczc5CuZmZkDr8qu9KYSen8WZcevhXO?= =?us-ascii?Q?WY2f0R/J9BC6qviDESQFBafD+LZY8bsfBi3tPvgG77ICBguk1x4kfU4CEANC?= =?us-ascii?Q?YdHp0EbhgsYGNpSjv1rI3uDPiQoyVwmylNwc7fyL/LM0YS76TCiwrSU9ou84?= =?us-ascii?Q?Ysy93F/e7vVSPPHg8snLZHA7zzSSicILn5rIWMGlePQj3UupxZTMETRCLVZx?= =?us-ascii?Q?bPu8YjVthUwIF76YtNl1M0QnA0bblu1Eq0RmfUhoofDF2ssMqsszwzuq38FS?= =?us-ascii?Q?2GMzp7T/TZm3ynMKd83tMXtpqnWtxtgt8mE4zf+T6oUZVe+/DUZLWoCZUkbj?= =?us-ascii?Q?r3T+SMSEd9Z68ZPDIbpUDRAVVcZJrCubPO2Yr2T/XJVJ23oUX9vHJYSUdfNL?= =?us-ascii?Q?1G/KuRh/6w8lEfATwV8+5/OJF5JOjTmLLhMx+ZEQR6FJYZdklZRJL0N8ZUgl?= =?us-ascii?Q?YabE0OR3nKlH+n5rTYiaC/p4UVMCpRuWmwoIJtijw04hmgdVxYRq9nZ5vjI9?= =?us-ascii?Q?9fAnf9iEWEGdQxLi9K5f3FSXEI7JO436/P0I0qHAQURoQvqOKrk4Dk9L+us1?= =?us-ascii?Q?M/YadXwr90Ktw8Y/KRLOrkgXuoP9LkCXYLhfgh642q82o2T/qH4+0rAFejBm?= =?us-ascii?Q?Sf3NOANP7VL7m5Wsrkbd7St4LOwJ6LXRezYw1C/W4MgdiJA9yLIeczg=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2095; 6:St6vW1H9d+1MpQWG1S40MWzoiuxpwmqC6oZGOKM++i8lnOUMqCCiL5AOg9hnjJhzBu4udf+HqqzQg8vJPlVlj7Es1x30P3hT/tvXCMtMMBeLn8lZvQPgMRvu5tPwgPoUd64V1sZOXU9wUQX5SXE6jnjB+TtqWWJQeRJ1sltMywv1Yfk94x6dxggVQBL1phK1/THLqgKPJWD3J5u88qQ9aihqlWDn46azzBbHBxVEfFG433XFyQ6HAz8Kd08l/ygNvd24gRGc3uRmXTSCv2zYwRKQPMyOXz4l9JcmNT20LfTLGtZwj5necpx+hd290+nLpe6XRSl3dptoh6X9zDiaqSzSvvcaBrHw5KHD4T2lLgnXkXNDTPoHj+J3XGCVa4EKyZJNvSeJcu5wzy+JxEbbO1L+4j08dbnRV56oCXLOJ3E=; 5:ObrMeHvu2BqWGXrTI1U6pF/Un9029ioCeAzRp52SV0nwRVkpXKIzEvaw70oP9iyFXjkofYcyeaw++dB0lmPT5pTNNJ6sOmEfr15lf4K+oa8p3SomlFl2Ultwo00Os/kBLlBNxSIuIg2Wv3wguV27x2Jh4vSv1J9TA9J9RE16vTI=; 24:6KCwC4BbnkiDF0MAGOWArHJFXdzsdZKGEkSAo0ee7rAF+gF9xyxB82vN4ORrOYPB5oBp1wqh57jicXG3BGvhh1TQ48RBVuVk+R7SMIrh4/g= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2095; 7:ifoAC9wi4DBkGwrEqlf2YZCfpdyyKsLPGXRDpE/Jd/6El8tFLU/K5gaiUREtocJIqUGzWqyqhSEasehFgGZS6rj87MliSqMeW2RHCbQ8IdfwJlegiqTbZmrf0dPKcphtI8w6YWjbp+nnANYxOvgl7TAK4M66yGk8Dn1oI3PcH2ptwC81AhBwyMVskrPmCm9t3jdyXBSxpp4+R+KpMQmG1+R1Q+5PXjEOWBz+RAuNDAkjLwKn/n5AN9otDnmP20fpuU9sV5WhrbhDM/NU4knxUYtj8XPuwUZ5nHvYjbQpNqp1/GayDFoYRopLRgadGpAlBo8vaViaOFosDUVK9i8+OHhlpyxx426AiyjEYBjhaEh3eP7McJF976lZdyBIvQBkO+n3RM4wHHg/4Ym8aH6GhHH/sXE0DV3yF6pLJJgdGnxnh1ArWT0/ITTqtvvhUh3MwIffyQscrdpbBT/6PpCUNA== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2017 06:28:13.3238 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0701MB2095 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran Reviewed-by: Christoph Hellwig Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_target.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h index 1f7c6d2..1196150 100644 --- a/drivers/scsi/qla2xxx/qla_def.h +++ b/drivers/scsi/qla2xxx/qla_def.h @@ -1794,6 +1794,7 @@ struct crc_context { #define SS_RESIDUAL_OVER BIT_10 #define SS_SENSE_LEN_VALID BIT_9 #define SS_RESPONSE_INFO_LEN_VALID BIT_8 +#define SS_SCSI_STATUS_BYTE 0xff #define SS_RESERVE_CONFLICT (BIT_4 | BIT_3) #define SS_BUSY_CONDITION BIT_3 diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 9c6cb75..47acc26 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -2288,7 +2288,7 @@ static void qlt_24xx_init_ctio_to_isp(struct ctio7_to_24xx *ctio, int i; if (qlt_need_explicit_conf(prm->tgt->ha, prm->cmd, 1)) { - if (prm->cmd->se_cmd.scsi_status != 0) { + if ((prm->rq_result & SS_SCSI_STATUS_BYTE) != 0) { ql_dbg(ql_dbg_tgt, prm->cmd->vha, 0xe017, "Skipping EXPLICIT_CONFORM and " "CTIO7_FLAGS_CONFORM_REQ for FCP READ w/ "