diff mbox

qla2xxx: Fix warnings reported by static checker.

Message ID 1487017109-28811-1-git-send-email-himanshu.madhani@cavium.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Madhani, Himanshu Feb. 13, 2017, 8:18 p.m. UTC 
From: Quinn Tran <quinn.tran@cavium.com>

Fix following warning reported by static checker

drivers/scsi/qla2xxx/qla_init.c:3910 qla2x00_alloc_fcport()
warn: use 'flags' here instead of GFP_XXX?

Fixes: b79414e ("qla2xxx: Add framework for async fabric discovery")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/scsi/qla2xxx/qla_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nicholas A. Bellinger Feb. 19, 2017, 5:31 a.m. UTC | #1 
On Mon, 2017-02-13 at 12:18 -0800, Himanshu Madhani wrote:
> From: Quinn Tran <quinn.tran@cavium.com>
> 
> Fix following warning reported by static checker
> 
> drivers/scsi/qla2xxx/qla_init.c:3910 qla2x00_alloc_fcport()
> warn: use 'flags' here instead of GFP_XXX?
> 
> Fixes: b79414e ("qla2xxx: Add framework for async fabric discovery")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
> Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> ---

Applied to target-pending/for-next.
diff mbox

Patch

diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index ea6ddcf..1598e84 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -3878,7 +3878,7 @@  static void qla2xxx_nvram_wwn_from_ofw(scsi_qla_host_t *vha, nvram_t *nv)
 
 	fcport->ct_desc.ct_sns = dma_alloc_coherent(&vha->hw->pdev->dev,
 		sizeof(struct ct_sns_pkt), &fcport->ct_desc.ct_sns_dma,
-			GFP_ATOMIC);
+		flags);
 	fcport->disc_state = DSC_DELETED;
 	fcport->fw_login_state = DSC_LS_PORT_UNAVAIL;
 	fcport->deleted = QLA_SESS_DELETED;