From patchwork Mon Feb 13 20:18:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9570733 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DE1C0601E7 for ; Mon, 13 Feb 2017 20:19:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CFF2F28173 for ; Mon, 13 Feb 2017 20:19:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C46CB2833B; Mon, 13 Feb 2017 20:19:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 52FB128174 for ; Mon, 13 Feb 2017 20:19:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753258AbdBMUTQ (ORCPT ); Mon, 13 Feb 2017 15:19:16 -0500 Received: from mail-sn1nam02on0061.outbound.protection.outlook.com ([104.47.36.61]:5674 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752821AbdBMUTO (ORCPT ); Mon, 13 Feb 2017 15:19:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=k8Uz01lF+cGQ9MHHRwa6fqLK+0kFApGOTefX4AqQc/o=; b=RHpbcbJ2ImnFzUw9Sap9CoNl1yHHVdtA1MQrdiLbde4mnzRDTpeP+FXU6AO7A3u9sL4+qNElOxQH+1N/rxiJkTBL2RMCwwEPgyW9u45hhnq83LN8Kup6Jwfvszd0Sf1mDqu0jAxKFfoc7WIEZqEnV6S23ysaebHZww9cx+qFukg= Received: from BY2PR07CA047.namprd07.prod.outlook.com (10.141.251.22) by CO2PR07MB635.namprd07.prod.outlook.com (10.141.228.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.888.16; Mon, 13 Feb 2017 20:19:02 +0000 Received: from BY2FFO11FD022.protection.gbl (2a01:111:f400:7c0c::173) by BY2PR07CA047.outlook.office365.com (2a01:111:e400:2c61::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.888.16 via Frontend Transport; Mon, 13 Feb 2017 20:19:02 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; linux-iscsi.org; dkim=none (message not signed) header.d=none; linux-iscsi.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BY2FFO11FD022.mail.protection.outlook.com (10.1.15.211) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.904.16 via Frontend Transport; Mon, 13 Feb 2017 20:19:01 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.309.2; Mon, 13 Feb 2017 12:18:58 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id v1DKIiF2028841; Mon, 13 Feb 2017 12:18:44 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id v1DKIh3I028839; Mon, 13 Feb 2017 12:18:43 -0800 From: Himanshu Madhani To: , , CC: , , Subject: [PATCH] qla2xxx: Fix warnings reported by static checker. Date: Mon, 13 Feb 2017 12:18:29 -0800 Message-ID: <1487017109-28811-1-git-send-email-himanshu.madhani@cavium.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(2980300002)(428002)(189002)(199003)(8676002)(81156014)(81166006)(8936002)(1691005)(101416001)(106466001)(105586002)(42186005)(50226002)(50986999)(81003)(33646002)(8656002)(47776003)(54906002)(48376002)(50466002)(4326007)(2906002)(356003)(69596002)(80596001)(189998001)(305945005)(36756003)(92566002)(5660300001)(6666003)(626004)(5003940100001)(2201001)(86362001)(4720700003)(107886003)(38730400002)(21314002)(87636001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB635; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD022; 1:bg0ydtRdkFKeErwxHvr9X/K6RpGybO63jv0hG21tLw+WlITzbZ7aq34/VJyZ5rKFkZDM3obU9udr9IVDhk3Kt5gapRLgq8j84eu3MP8cfPiK/wU8duPTVus+7zLfu1ReKZFx3EfCrFsINSEl8pXDnZGPVv53dU1NerqoKgFsxNZbdHrG+exVZKwRjNM5rPa/tQr1Riw8U7oNaDmVfNGGzcBEbhbhw5D/HSCEsAuix8WzJCmgy9hvQPeYrrhDyFv5fKGuogfJuJDBYups/LwdGCTcyIUDCrZy/tTUzHp4mY5dS37q+H7IbaouJWahGXtzbtCfDd533XI9qWPOdbxtfuGzHicbV+3mQ71+4cwTAF/c6T6b20m59kfLL3y9IhuO6SiBvRdJtn3aoMHmy1PYImELa4DSsy3YU+fOfyjuwSFGTqfyUJO2HAduJJMiIFSlEccBg3FkxXV4F2z1yKBQHUZXBRXPvxVQ1Dc/zU1cS3O9dlHl8aB7NFI+kwJrj3OhuQJ6aTRTm+3IFBVXzoNOJODsg/U0aMYtRyUMQHgpvnc= X-MS-Office365-Filtering-Correlation-Id: 112b7184-cce7-4e4d-fa51-08d4544d8ce1 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:CO2PR07MB635; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB635; 3:6hVooW3Bcl7V6ke6FKdlgK8SdFUC/N38Y2PcwqGGK3mIiosJ0MWU4Y/g76dimn3nDkyjkqAlWy8iFj2ApCSF+cj7fwtgwTdEkpQerEE/SQx8d7FYRaaTgpvPUvcXVO/6XNAHa/9/Bj7pdwxY3jua8y0bybclPIfoNcmf7buZeQc396TUuW1AP+/G8lQG+ctLahWtH8M+USfy7yxWr9Wnf7Hv36JVoLz727MFcdbrOdm6vwwOdOwWqwfPaHxjNWG3leWebzOy5EDLJ1GQJuuYJ0XnhFnSVz7bc1cdv8YVy1BLjJISoA6m6KZDY5IgLA/SCIg4hJ1cGwFIv6CWRopwtBbAvGfaUl29Iiy0rRdpwZOpavmC3kncqJE6YvEUDCyn; 25:756A86c3KHBKte+MR6caRm9ljMm1Kh4/eVIj72yIIvDYy07rs1j/ZRqqbW0emRpdohn95cwlAEq4W0bJ7dg0Mhep4UuVGf0s5cNmr/9z5PgCrxddJxuovhyhB/HY39sMeNRFncLYih9zuUK8u+bM/f33WeSsJ2LNXPCqld/PmDrtZGIpAllhTEPaQP4ru+c5L+7NOSAgeha98ygRaRkP7hlfak95zWHBMon7qBKMz+4GsOnrVKhhYBamYMnR4LZEGgEU6ZP7pBStw07hoGl0fAbh57D94skENlwIaa4dlSNvbOb378XY9CeZERFXLC+7CvO1NM2sQE2fFzlgte6NxS4tpMvAhHKKbVijUEeZy5AXpJjFguQyFgy9x+xHlNErhnuqJzdxROgOR7Jqi7UOnSSCsQiHYtz/8s9DqmEMsi15h9hkPuCCsCwCpDAFLePsNhO4kLVaBvpLB2TtZqUf2g== X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB635; 31:HfekzPtuo3+fMyHp6APet5bUTWQxztWtqCj2y8lI0hOhWZqV2A9F8GVbN1CxPO1XBsLYtIOlsryA5O7bbTQKI2yi22Y+PoliQk+wUvTfLHyDRLQ76J9ONzbjHgbnjX1WGwagjAWvVJdj4JxFaXsnBAOfE5H11IcL9fVHq4rKAIi2FIhHai926qcYreY0zT278VzltkZGgdk1NKGC38C5JawwpJHYX7eEgIhun98OzwSBIig0UkUDGXinEtf5M3x8HE/GxniW3SJcESHczhhpOkS/r5q7Os/b9NwrLzlIeM0=; 20:CkE6cnZEqgN4H0d7Fq82Nz9S36MEugQMmRWEG1M6AdGs2gq8asfGO7r/IdP0CtuWv7Qcr8cf/DFJhgfHhC4LQRSOATLzq/fD5HsbUA05BuNLMblkXCCVlG7YQS25BNaWlJvd5P3VabsFuMAE/eGCbzk1Qi0OAM5PTCIfkpnmQDubi1f6M/XsoSx9pRAo2MoB5luZqC18LaPIew6jvpvSnypNMT4EEABUDhMvrUVV8TxVzF6/EhVn0cqOgDBy7Q6VjhO13RPHYFzJtUD4IiGEzAATIN5hQq+c3Lyx4oXAeP70Zy8sdjpWNJfm7BBf5hbZFcG0/gsQInmODyo4Bq2qyAc1J9jPGKRk0qmOSKG7JT6LHIIXqmrtRM4AhXCSfBTtQTidFt1LeI4k7BJMRIiryGEYroPQwogUu+EvkqPf31ZTdlkQ5CNqTEXy92ETkOXu5ZC/TEnCytTmdeMP4cEPbzuiePaUMOI9gXd/8J5PSf296pX+u7r9w2QWY8CSChdN X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(146099531331640); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(13017025)(5005006)(8121501046)(13015025)(13023025)(13024025)(13018025)(3002001)(10201501046)(6041248)(20161123562025)(20161123558025)(20161123560025)(20161123555025)(20161123564025)(6072148); SRVR:CO2PR07MB635; BCL:0; PCL:0; RULEID:; SRVR:CO2PR07MB635; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB635; 4:u0PMJAS5/6tKPohZiduIOtvOC3t4UwS2SwTFdM9uRlqgwdXCWhvFyez7h53/LH4at0eoHxgGj17JYAhqWpnib6Rb1jQvtqcLWOfSkiJsxpZUTL9ARliApySFmxm3R9YW3FL8NJ0E0hq1awUGSPFQhigXO8VlURpMwieHVBsx0S8hpy7OTNlWjLFfVpwsIwzaFb2aSRWYNCEqPbqqNChb/f95gpWckL2IcG/attkBdHPRoHnDP+Rj0IzRl2fC0REo8Ckb0oVc17vl72Mkr8XXmeF5WTKermr8VUDEsaJa4DZgeChZVj+cpRHA9UFPAEU2mrM76RnVSJilnpty2GwrTJk1Mj0qoSTngJ0EPhCrZVFDy7hAE+Ks5FvbXQnWw5eniPGf6GWPC4sq1appGKFKT4qe6GelZdn7KGPrQJONVTuvzEIrssDR/2tC/gG0yCP6mSH8PjQmtOmy6yTZV7GaSS0FbKGI1oVEYRLRpdbGbwBvUaguGm6a9RX3HfqbyoeXZIfxOXnbs79rDQDyYmvbv1Dx46h1A3R1hlwbHQ+DsBbcOKnhqa3E/SUCawm1F7zrFo+emy7Or21hoLfKrn/OmPpaCvRZC3+rkc4fwwQ8sSJqyLsi3zoujmAJ2c818QksKGOlIT9G6gyIYR7robIVBwpuGLfsWfR64VZlSZRdlMF4mJtFiZ+4qEaTQDznZXKexTTMHETHgXcaPkSGlh1ovqY0FZPbE1W6mYQgNal6zoeKtb3KHXkXYZeitf8truIY X-Forefront-PRVS: 02176E2458 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR07MB635; 23:4Dze8DRX6HvOQyVASy5wQWUH7y9mxAeL69y6lkJUrP?= =?us-ascii?Q?omjtMvuAnhSNQWvG8gqaZSygoUVaXGZvTBL7ltUg30Cp+R6T03Roy52dbclb?= =?us-ascii?Q?nBpKEjSCQll3SVmG0bTKaiduf8ihDqSlxMaYlhopXtma98bw2hXsLi/aq4bL?= =?us-ascii?Q?UQDPQOS4Ajs0/2IUE0aXB4Vf9UO1dhK75VYmabCLO9gehncoRXifbPLdpeh3?= =?us-ascii?Q?DXgrHpFtYl3AGM44/4XSMAmNFN9ob0Mx9hCQvONtaEhwE3fnGqRz/4IyKOPi?= =?us-ascii?Q?SMtHB7kS4efi//BcOZ9sKqTA9J0bFnZBgw3SnVTeExWhA34QEPQdUcK++JtM?= =?us-ascii?Q?uvUdVSvORdw8DZEryz/ryEUPAeM/KImkZJQ4ZaaroUvpv+pLrOuSg2J0/jkb?= =?us-ascii?Q?w5NkmiVjWiSQ6k5eGp1/DCRsdIjvOaw/rm2FZzHwi0gkPhdeEMz++bHpDBU8?= =?us-ascii?Q?WcQmn7xN8XIjsvbgFaj+wRxjji+iuYVI4OBcY8lGxUgL5fQq5plrC9Q1rQuR?= =?us-ascii?Q?IPLyhjcJ0935awk2NHbxWWCddFd7QwpUZ+eeraUMRb6f1cWFT/v8HYGgr/uq?= =?us-ascii?Q?AdFBGTme/0QNXyO7HTZjZ3RJL+6uLnAChMDJav/M7LpPfLIC03LjHUHZ8lFg?= =?us-ascii?Q?k7TaonMqmNzdRqrq00cuIGX8B2E02SdqiowrTcM/s3S37oLy1LIMY2sP5/BT?= =?us-ascii?Q?UWQ/6oxAXCIpb1TvuQ3FFhWzkh1zdiDd8ZEgiyBsWEwoJjyRfw70Bm6OGLC8?= =?us-ascii?Q?TEOiEaJAEvt+I5bih2UGfvCAZV3/G6rIjmaHPVEcRyiznvoRohvcyb6M2WmL?= =?us-ascii?Q?qoeA6zyVRyNnhXxBmNinUnTclwCsjk13437HcycrCZ2Aqly+/9HJtp6qYYxZ?= =?us-ascii?Q?lgm2IkOHOTcjn7QFtyDt4hVplSGA3KgNLH6JOyhSVwu9MlaVzZ4EfZ7zNua3?= =?us-ascii?Q?81AbRoi0uLwFcNcCL7g0WLt+/fBuV1n+A19hrCe3/KJ8pAPGe0nRX845weON?= =?us-ascii?Q?c08jsfB1VZ4UAByJ+IKrwyofoMG51lQSRR76au2d4VrF4+8soRBZogyN4OCa?= =?us-ascii?Q?S6beYRmLm0ejbxTrtMszq441Vh?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB635; 6:1pSpFNXCGkMFc7Y2GYtO8fJmaaf7xOnMPzb6RqepsgigqMiAcBjsdbwmpmT2X8PZmCbVThiEPzIxwxi0nIEDoiYJsnHi9eZdCNENF6t6A/6KNTjzPuxVJVDYCl89rk/kroLgSrcT5OLSdQBMINW7gU4DbE+5NvonE+cXuL0G+Kt20XEGEgWUTaV+xuusHDAwCnEJc1yWdPXn7G4vpH6fLUEteMjt1r0pogaMKZxu/ixGy6LjNIMmo4F4dDi28YgvvhFZWCoOSx5K9OD0wXS2b/Cowo7pn6Ktf5L5TX6ZMXf9RlwlURmOvNpv3PThWb9NdsEn85Lh49xHrVtF7hYBuJNyuOSl/OZFI7iZjQyfuraqZ382ade/elfo079M0d46SHpEzEPNChSag/GD6jm0QQ==; 5:zZsN65oOh/Si9RyYv1V7nejgScoyDjQzAJ0uI01byp6mqTLxmoVtZb3djuepEhEIWb9XRE6dudqONHO75u1ss6zQhjKC/KY4wycX3646gyBtuJMIDjvEq6Psdh6afVKbDBsfot/TdbgY72QbwBjpMw==; 24:5O9IZWcRfnOt/MUDx66QnkKCH3s3LBP6BQ743If0BR5vhFy10r9/AJ3uYoDMaD5cdBxGQYOUnkRRJRd08v5/NhGLYdULeeJcLJ2hAryVG/U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB635; 7:CfGcKB8KPEvrYMsUeU0ZHBI3rt1m/N1oivg02LnEhnTtbvIWVFH7dTGgGY92DWQKZcUgMII7mWjYpKVkhJ7oemjQctyWEY4i+1w6AWNTR4KItKN+BLH3g8NFArjsy1amfRfyMJqTbQd6keJoJsFSSkyWUS9c4JOuM3w7+JTIa7jgZARkpQqZ/CNLGFfvM3+ilDSwe0awJyk/VvuCPIITqBqMQ7/Nu8hkzVTmAssJMJPSw4qsrnJwoFr3UbgF4Rv1PWYHag4aBTKNyj73ArHY32wHWvYGd3MlqnQrgWXj09ECLFzjJlvg2P2zOn5slGO+o91d9IFRBTEfEqyL9xA0EbzHS1jJEwLyoPCiNzdA3lmm0GLdfTu1IBtjXPYrAgkIcKazmbx1bKBlrvHIDRxOxEtrnIWxIkTwv7GWMsFYy36k1GKlTAoGHLurmxVTKiGmBhv9GXCHQRho9cT3tq+21h1p57T68/uCp72XXmlBIxgqUcH7pOVoMxptm9ccWSMgkyuihtFJkpauMy/dfD3g3A== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2017 20:19:01.2521 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB635 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran Fix following warning reported by static checker drivers/scsi/qla2xxx/qla_init.c:3910 qla2x00_alloc_fcport() warn: use 'flags' here instead of GFP_XXX? Fixes: b79414e ("qla2xxx: Add framework for async fabric discovery") Reported-by: Dan Carpenter Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Cc: Dan Carpenter --- drivers/scsi/qla2xxx/qla_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index ea6ddcf..1598e84 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -3878,7 +3878,7 @@ static void qla2xxx_nvram_wwn_from_ofw(scsi_qla_host_t *vha, nvram_t *nv) fcport->ct_desc.ct_sns = dma_alloc_coherent(&vha->hw->pdev->dev, sizeof(struct ct_sns_pkt), &fcport->ct_desc.ct_sns_dma, - GFP_ATOMIC); + flags); fcport->disc_state = DSC_DELETED; fcport->fw_login_state = DSC_LS_PORT_UNAVAIL; fcport->deleted = QLA_SESS_DELETED;