| Message ID | 1498670061-39766-1-git-send-email-mrochs@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 06/28/2017 07:14 PM, Matthew R. Ochs wrote: > The device_unregister() service used when cleaning up the character > device is already responsible for the internal state associated with > the device upon successful creation. As the cxlflash driver does not > obtain a second reference to the character device, the explicit call > to put_device() is not required and can lead to an inconsistent sysfs > among other issues as the reference is no longer valid after the first > put_device() is performed. > > Remove the unnecessary put_device() to remedy this issue. > > Fixes: a834a36b57d9 ("scsi: cxlflash: Create character device to provide host management interface") > Signed-off-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>> --- > drivers/scsi/cxlflash/main.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c index 7a787b6..455564f 100644 --- a/drivers/scsi/cxlflash/main.c +++ b/drivers/scsi/cxlflash/main.c @@ -923,7 +923,6 @@ static void cxlflash_put_minor(int minor) */ static void cxlflash_release_chrdev(struct cxlflash_cfg *cfg) { - put_device(cfg->chardev); device_unregister(cfg->chardev); cfg->chardev = NULL; cdev_del(&cfg->cdev);
The device_unregister() service used when cleaning up the character device is already responsible for the internal state associated with the device upon successful creation. As the cxlflash driver does not obtain a second reference to the character device, the explicit call to put_device() is not required and can lead to an inconsistent sysfs among other issues as the reference is no longer valid after the first put_device() is performed. Remove the unnecessary put_device() to remedy this issue. Fixes: a834a36b57d9 ("scsi: cxlflash: Create character device to provide host management interface") Signed-off-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 1 - 1 file changed, 1 deletion(-)