From patchwork Wed Jul 5 12:00:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shivasharan S X-Patchwork-Id: 9826407 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5C475603B5 for ; Wed, 5 Jul 2017 12:01:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 52ED527F54 for ; Wed, 5 Jul 2017 12:01:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 477ED284B5; Wed, 5 Jul 2017 12:01:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D7A5627F54 for ; Wed, 5 Jul 2017 12:01:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752771AbdGEMBb (ORCPT ); Wed, 5 Jul 2017 08:01:31 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:35149 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752093AbdGEMBa (ORCPT ); Wed, 5 Jul 2017 08:01:30 -0400 Received: by mail-pf0-f174.google.com with SMTP id c73so128732872pfk.2 for ; Wed, 05 Jul 2017 05:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QOCZeRJaHJlmU7mohUfsW5j0lL/g7jhweZZBy8uSaUE=; b=RXc6FO8sqJHrcQXS5NuVLAV2C0TVTtGJBDW4guuoS/1881aE3R8dYmnJWj1bhU6ciD VLDRiX0Ytk3JxExxBc//SAX7eJxv8JkQ47ZkgDjiGMS1fiz5SyQAED3eBqYQa92yyKAV ZKPOcHwAMPuBWeG1Pmow3jxPs/jWweXNvXhiA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QOCZeRJaHJlmU7mohUfsW5j0lL/g7jhweZZBy8uSaUE=; b=rYbToKyCvhQ8s6Pz0DtNacNgj4ZmXH6isljzCB3SuNIJd/Ur147CcZ/5bBUihTmhiG zgrUHOhF5BuGNF7/xA7nfuR5hmBjnTE5wZHu+LAvZkiyhinbBDSVdi1apFqc0w9WM6cG J3P64QKsVcj+IzlV1EYF6vE3VHiy4znEPWx7Lbz+Yp6TzOMqMUHq1SslUEA4bqihemJH 4JUQRonN/f9vyy7EzBThpknwysP8ZmCAdhLG6zz17cvTZCaJ9SsFmnLzKeYsNQr2b414 OwgG7lRaZB7kYdiKeUOhlqxcGJqAbW6HH2v+H03Z64Cu1PWm2nAh3biT2NNHSS/nzCyF 7xQw== X-Gm-Message-State: AIVw112Ma6oPnq8+LcHPErF4MELFimU3rB5Bl9r5w9pJino1iRXEwHlB LeyvK6lBam7GiDVUl5s= X-Received: by 10.84.231.196 with SMTP id g4mr21850457pln.34.1499256089450; Wed, 05 Jul 2017 05:01:29 -0700 (PDT) Received: from dhcp-135-24-192-142.localdomain ([192.19.239.250]) by smtp.gmail.com with ESMTPSA id x64sm48454631pfk.20.2017.07.05.05.01.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jul 2017 05:01:28 -0700 (PDT) From: Shivasharan S To: linux-scsi@vger.kernel.org Cc: martin.petersen@oracle.com, thenzl@redhat.com, jejb@linux.vnet.ibm.com, kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, hare@suse.com, hch@lst.de, Shivasharan S Subject: [PATCH v2 06/15] megaraid_sas: Fix endianness issues in DCMD handling Date: Wed, 5 Jul 2017 05:00:20 -0700 Message-Id: <1499256029-16319-7-git-send-email-shivasharan.srikanteshwara@broadcom.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1499256029-16319-1-git-send-email-shivasharan.srikanteshwara@broadcom.com> References: <1499256029-16319-1-git-send-email-shivasharan.srikanteshwara@broadcom.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_base.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 395c3aa..3c50a7b 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -6867,6 +6867,7 @@ static int megasas_set_crash_dump_params_ioctl(struct megasas_cmd *cmd) void *sense = NULL; dma_addr_t sense_handle; unsigned long *sense_ptr; + u32 opcode; memset(kbuff_arr, 0, sizeof(kbuff_arr)); @@ -6894,15 +6895,16 @@ static int megasas_set_crash_dump_params_ioctl(struct megasas_cmd *cmd) cmd->frame->hdr.flags &= cpu_to_le16(~(MFI_FRAME_IEEE | MFI_FRAME_SGL64 | MFI_FRAME_SENSE64)); + opcode = le32_to_cpu(cmd->frame->dcmd.opcode); - if (cmd->frame->dcmd.opcode == MR_DCMD_CTRL_SHUTDOWN) { + if (opcode == MR_DCMD_CTRL_SHUTDOWN) { if (megasas_get_ctrl_info(instance) != DCMD_SUCCESS) { megasas_return_cmd(instance, cmd); return -1; } } - if (cmd->frame->dcmd.opcode == MR_DRIVER_SET_APP_CRASHDUMP_MODE) { + if (opcode == MR_DRIVER_SET_APP_CRASHDUMP_MODE) { error = megasas_set_crash_dump_params_ioctl(cmd); megasas_return_cmd(instance, cmd); return error; @@ -6976,8 +6978,7 @@ static int megasas_set_crash_dump_params_ioctl(struct megasas_cmd *cmd) cmd->sync_cmd = 0; dev_err(&instance->pdev->dev, "return -EBUSY from %s %d opcode 0x%x cmd->cmd_status_drv 0x%x\n", - __func__, __LINE__, cmd->frame->dcmd.opcode, - cmd->cmd_status_drv); + __func__, __LINE__, opcode, cmd->cmd_status_drv); return -EBUSY; }