| Message ID | 1502785303-41870-2-git-send-email-hare@suse.de (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hannes, > The error code from a scsi_execute_req() is a SCSI status, not > a normal errno. So whenever it returns a value here an error > occurred and there's no point in looking at the page number. 424f727b9413 scsi: ses: Fix wrong page error
diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c index f1cdf32..a37aec8 100644 --- a/drivers/scsi/ses.c +++ b/drivers/scsi/ses.c @@ -99,8 +99,8 @@ static int ses_recv_diag(struct scsi_device *sdev, int page_code, ret = scsi_execute_req(sdev, cmd, DMA_FROM_DEVICE, buf, bufflen, NULL, SES_TIMEOUT, SES_RETRIES, NULL); - if (unlikely(!ret)) - return ret; + if (unlikely(ret)) + return -EIO; recv_page_code = ((unsigned char *)buf)[0];
The error code from a scsi_execute_req() is a SCSI status, not a normal errno. So whenever it returns a value here an error occurred and there's no point in looking at the page number. Signed-off-by: Hannes Reinecke <hare@suse.com> --- drivers/scsi/ses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)