diff mbox

mpt3sas: remove redundant copy_from_user in _ctl_getiocinfo

Message ID 1505920431-13173-1-git-send-email-mengxu.gatech@gmail.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Meng Xu Sept. 20, 2017, 3:13 p.m. UTC 
Since right after the user copy, we are going to
memset(&karg, 0, sizeof(karg)), the copy_from_user is redundant

Signed-off-by: Meng Xu <mengxu.gatech@gmail.com>
---
 drivers/scsi/mpt3sas/mpt3sas_ctl.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Christoph Hellwig Sept. 20, 2017, 3:19 p.m. UTC | #1 
Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
Martin K. Petersen Sept. 25, 2017, 11:22 p.m. UTC | #2 
Meng,

> Since right after the user copy, we are going to
> memset(&karg, 0, sizeof(karg)), the copy_from_user is redundant

Applied to 4.15/scsi-queue. Thank you!
diff mbox

Patch

diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
index bdffb69..d448fed 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_ctl.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
@@ -1065,12 +1065,6 @@  _ctl_getiocinfo(struct MPT3SAS_ADAPTER *ioc, void __user *arg)
 {
 	struct mpt3_ioctl_iocinfo karg;
 
-	if (copy_from_user(&karg, arg, sizeof(karg))) {
-		pr_err("failure at %s:%d/%s()!\n",
-		    __FILE__, __LINE__, __func__);
-		return -EFAULT;
-	}
-
 	dctlprintk(ioc, pr_info(MPT3SAS_FMT "%s: enter\n", ioc->name,
 	    __func__));