From patchwork Fri Sep 22 09:51:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 9965719 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 32581600C5 for ; Fri, 22 Sep 2017 09:52:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 31EB32982C for ; Fri, 22 Sep 2017 09:52:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 26CA129845; Fri, 22 Sep 2017 09:52:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_SPAM,RCVD_IN_SORBS_WEB autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D4D4F2982C for ; Fri, 22 Sep 2017 09:52:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752280AbdIVJwn (ORCPT ); Fri, 22 Sep 2017 05:52:43 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35171 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752243AbdIVJwl (ORCPT ); Fri, 22 Sep 2017 05:52:41 -0400 Received: by mail-pf0-f193.google.com with SMTP id i23so268679pfi.2 for ; Fri, 22 Sep 2017 02:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tpiBTTYY2rWTLcwx/755FJIPPe0X6Yx1iRHIonP1+h0=; b=NjM9es8DiKvEXRk7AsASXraGlWUq7LbsfdyydetD+wBe9Sr2vwbH+fQugPsIGf/6aX jRbCXqwPKH0QYAAZ/HHoLk2HIVGBZx6PLrKzDpoOrnOUyhi7+ZYlQk5bVclex1d6401m +nieQdKOtSh3aRg5ZEzGthoAf3tdtHu+iryVQtWqiqHWrfgxez3vD9c2GuS0ItNSn7h9 wQ9cI9od1+gpzG6LdGLoErrXgGGvN9ygMs7B2jBXB4bmY1kZPROazCQHSjLTKF8jjIOM zJxOgFB5QlinebAg7IiefKm5H1bJkKG6+0wLcEL2Y+llDgwrnC5YQGq4sSVpe6RO7cDE hc2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tpiBTTYY2rWTLcwx/755FJIPPe0X6Yx1iRHIonP1+h0=; b=qKCN9M/fboCbvD3fQmXZRLTGbdw7QVWerhsvVrcgIPOtSVSEjIhh1hyrvYKI0e2yog yxDb2+GHE86SspJR8gczjKs+tQvK3HBXXGI8hQ93icsyMG3N8yDOcEq4bculmMmGrcYH zXFyD2XzpmjdwKlQkqOYjIfQa5dc8Gd+ON6mFaiXQmSCJ1ccdeIWu4xr1LbyO0heLEPK Pg0CQA+k9aH1xl7iWJAfnJb3cfkvdAXQxyPfmt9WZzpy3smBqcBNhN01C2ryoukCbmIM s2XeRjIkslLMGcdxSvE3W711mhL6ecKqEtktRbV/ngn5rUsobYxARPoWcMAnxHHhodpv twaw== X-Gm-Message-State: AHPjjUi+46L/DLgemnfwniFXmG+f1pGYqcpwOQwHCDnw41iLi2HR+E+N opNly+b6KfARQH3WhWRZfZkJY5KU X-Google-Smtp-Source: AOwi7QBidIcZi9qiNpzx9qbvQwkGc0lHrik4EWvUEJNcYR8SvouKYFfm2Zog7+GURBagR6aiiN5GEA== X-Received: by 10.84.229.71 with SMTP id d7mr8386049pln.417.1506073960934; Fri, 22 Sep 2017 02:52:40 -0700 (PDT) Received: from localhost.localdomain ([103.42.74.194]) by smtp.gmail.com with ESMTPSA id k13sm5611977pgo.51.2017.09.22.02.52.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 22 Sep 2017 02:52:40 -0700 (PDT) From: Allen Pais To: linux-scsi@vger.kernel.org Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux@armlinux.org.uk, oliver@neukum.org, aliakc@web.de, lenehan@twibble.org, lduncan@suse.com, cleech@redhat.com, matthew@wil.cx, Allen Pais Subject: [PATCH 10/13] scsi: libiscsi: use setup_timer() helper. Date: Fri, 22 Sep 2017 15:21:42 +0530 Message-Id: <1506073905-12985-11-git-send-email-allen.lkml@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1506073905-12985-1-git-send-email-allen.lkml@gmail.com> References: <1506073905-12985-1-git-send-email-allen.lkml@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais --- drivers/scsi/libiscsi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c index bd4605a..f485280 100644 --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c @@ -2913,9 +2913,8 @@ iscsi_conn_setup(struct iscsi_cls_session *cls_session, int dd_size, conn->exp_statsn = 0; conn->tmf_state = TMF_INITIAL; - init_timer(&conn->transport_timer); - conn->transport_timer.data = (unsigned long)conn; - conn->transport_timer.function = iscsi_check_transport_timeouts; + setup_timer(&conn->transport_timer, iscsi_check_transport_timeouts, + (unsigned long)conn); INIT_LIST_HEAD(&conn->mgmtqueue); INIT_LIST_HEAD(&conn->cmdqueue);