From patchwork Fri Sep 22 09:51:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 9965709 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C14DD600C5 for ; Fri, 22 Sep 2017 09:52:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C003B2982C for ; Fri, 22 Sep 2017 09:52:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B4EB62983F; Fri, 22 Sep 2017 09:52:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_SPAM,RCVD_IN_SORBS_WEB autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AD8182982C for ; Fri, 22 Sep 2017 09:52:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752103AbdIVJwY (ORCPT ); Fri, 22 Sep 2017 05:52:24 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36550 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752010AbdIVJwX (ORCPT ); Fri, 22 Sep 2017 05:52:23 -0400 Received: by mail-pf0-f196.google.com with SMTP id f84so264953pfj.3 for ; Fri, 22 Sep 2017 02:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TP29y9aIiU+GRI/cbAEHkqXr1ooBXAzcACvm2LgFTEE=; b=D49iUBXH82heIlTOOKSQZgn+VrMVFilfep+FFH0Hd3ARUoIH/6a6JFclY8PvGJncto E8LjYAeSVbLIwDDThBIpQTI42wfxSlcVzr8GYekw8rX8P+qCmd8JBzx3bDjt7qewcGoK vlb175pSiAkoZWx2ddRk7MJliG1038fnZqdt1cXEPVLOIu+08QNSlvhIGTkO9+dKC/br ho0SguoDnHCIwK/csjBYCzraZpSrB3ZbDXlV7at98UUHlcE+AfucJ094gUL2S6CvjBzN mxKioapllqex2ASXor6h9OFbyrPtdcSe+6e2vQehTY9sV1riDiDCJMy7IbLJ87ki8hPg b7VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TP29y9aIiU+GRI/cbAEHkqXr1ooBXAzcACvm2LgFTEE=; b=fFwetgOnKZbekxsaziBsNbJE/H6hKW2Txc8A3psLzfgYi9IAZlSBQy4WN5QmyjX6T5 Y05GfWpuJXfXz+ooNREV3g50Wf7jbyOebSYTszVnjToadFgwjdRUpI5SEEGaXGSFql9U L62W3p5NkQ1JRTZWNfz9OlinkqclyVYwwdvQUhuTiHTvch3wRV1oLnKG26EHk3zHpjmP qjo4OMKPenPws8FFwxVPD21n7p0uRGdqXvZbFinQ1UZR85yRquvnL9np3jZ9DnWlZ3Gg PpjsW9BBafjpxmFuZ+UE2RUSDc30pdySM0s94ipx/M2Kcson2VK92DJjbwxel7+GRGF9 FvaA== X-Gm-Message-State: AHPjjUhOqxGTLxsqZCHDM+tZ/aqfFrj0b3kf91sxlp51Jo1oahqek2vh g3A/OJpnsvNBfRRkAYA9DAnEQgTq X-Google-Smtp-Source: AOwi7QDXSPs1XRpRLyUmsILhHzBr4woC0Xa74nwI5AzmOOLctA3WuplrNg1qeywjHxdy0nwjCf+VhA== X-Received: by 10.84.133.98 with SMTP id 89mr8574478plf.294.1506073942582; Fri, 22 Sep 2017 02:52:22 -0700 (PDT) Received: from localhost.localdomain ([103.42.74.194]) by smtp.gmail.com with ESMTPSA id k13sm5611977pgo.51.2017.09.22.02.52.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 22 Sep 2017 02:52:21 -0700 (PDT) From: Allen Pais To: linux-scsi@vger.kernel.org Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux@armlinux.org.uk, oliver@neukum.org, aliakc@web.de, lenehan@twibble.org, lduncan@suse.com, cleech@redhat.com, matthew@wil.cx, Allen Pais Subject: [PATCH 06/13] scsi: be2iscsi: use setup_timer() helper. Date: Fri, 22 Sep 2017 15:21:38 +0530 Message-Id: <1506073905-12985-7-git-send-email-allen.lkml@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1506073905-12985-1-git-send-email-allen.lkml@gmail.com> References: <1506073905-12985-1-git-send-email-allen.lkml@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais --- drivers/scsi/be2iscsi/be_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index b4542e7..5579454 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -5708,9 +5708,8 @@ static int beiscsi_dev_probe(struct pci_dev *pcidev, * Start UE detection here. UE before this will cause stall in probe * and eventually fail the probe. */ - init_timer(&phba->hw_check); - phba->hw_check.function = beiscsi_hw_health_check; - phba->hw_check.data = (unsigned long)phba; + setup_timer(&phba->hw_check, beiscsi_hw_health_check, + (unsigned long)phba); mod_timer(&phba->hw_check, jiffies + msecs_to_jiffies(BEISCSI_UE_DETECT_INTERVAL)); beiscsi_log(phba, KERN_INFO, BEISCSI_LOG_INIT,