From patchwork Tue Oct 10 10:48:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jitendra Bhivare X-Patchwork-Id: 9995775 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CF692603B5 for ; Tue, 10 Oct 2017 10:48:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CAF4628500 for ; Tue, 10 Oct 2017 10:48:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BFDEB28503; Tue, 10 Oct 2017 10:48:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5182228500 for ; Tue, 10 Oct 2017 10:48:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755585AbdJJKso (ORCPT ); Tue, 10 Oct 2017 06:48:44 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:49860 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbdJJKso (ORCPT ); Tue, 10 Oct 2017 06:48:44 -0400 Received: by mail-pf0-f180.google.com with SMTP id l188so16806910pfc.6 for ; Tue, 10 Oct 2017 03:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2UH/RyIL+0u5iqg/tDZVYCWYN1TPF8j84ZiEpTi1DCE=; b=OqDIIAEQ2tszxaDyF2zgMKvtORMY4mAeac1pdYAZrbxfkDF01DgpY6tXT2ETaqWZDp ai8r5ILyz080zSsXuY9hzKj4/BXwxBDyvA7kUDxDyigDef61s9+swsQXJeQ4uLYcfbHb dTSb9zQ25hMNT5ubRNdhgRlcPITGZ3OcA+9i0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2UH/RyIL+0u5iqg/tDZVYCWYN1TPF8j84ZiEpTi1DCE=; b=DUVUqskEtTMBdyBDXVywkRoLvf3AOy7x/GxPR7k+0X7Hq1OSVaWbAmsXqJ9KOGmlim jXffgRB1d3rO5DuX3sOm6Vx4ZTmW1AeBxMIiNtNVUd9Jme7r57XqyyGVJVvFMKcnlSuT esGtP09hV+WPh1KcWj0QqFZreZPWIaZQl0eeds20sVEHZlzXpJQdSo/i4B2v2SHNuamj 9QAGX3PkzCDqfn+WWbfx86ImdYn1W50FOaNNolYQ6LfEiGvy3Afu1fwRRQs+fjg+2W9D R3+RXYu1E9SIs+qjVDIVgE+plwIGqIcZViyhOEOE9S+PD9/l7qGvvMo5paf6bAErFvtJ iimQ== X-Gm-Message-State: AMCzsaWnGxqpH6pnl/6fa9uoY6JewS1c/YiukV6ki6Fo22Do/WcHNCN6 t9VOK9kHU+io3n+ICxQvTBiiWQ== X-Google-Smtp-Source: AOwi7QAvcgk1sC++Hq+udQc7lchGabs4ABaeAOsdDhXblrwEM5cueRZEt0bxP8J86yb3vbI0JSkWdw== X-Received: by 10.84.235.9 with SMTP id o9mr11474180plk.8.1507632523711; Tue, 10 Oct 2017 03:48:43 -0700 (PDT) Received: from localhost.localdomain ([103.195.99.222]) by smtp.gmail.com with ESMTPSA id w13sm16131313pgq.13.2017.10.10.03.48.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 10 Oct 2017 03:48:42 -0700 (PDT) From: Jitendra Bhivare To: cleech@redhat.com, lduncan@suse.com Cc: linux-scsi@vger.kernel.org, Jitendra Bhivare Subject: [PATCH 02/10] be2iscsi: Fix return value in mgmt_open_connection Date: Tue, 10 Oct 2017 16:18:12 +0530 Message-Id: <1507632500-26445-3-git-send-email-jitendra.bhivare@broadcom.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1507632500-26445-1-git-send-email-jitendra.bhivare@broadcom.com> References: <1507632500-26445-1-git-send-email-jitendra.bhivare@broadcom.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP mgmt_open_connection is expected to return tag not errno. In error case, just return invalid tag 0. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c index c737753..af6ee43 100644 --- a/drivers/scsi/be2iscsi/be_mgmt.c +++ b/drivers/scsi/be2iscsi/be_mgmt.c @@ -156,7 +156,7 @@ int mgmt_open_connection(struct beiscsi_hba *phba, beiscsi_log(phba, KERN_ERR, BEISCSI_LOG_CONFIG, "BG_%d : unknown addr family %d\n", dst_addr->sa_family); - return -EINVAL; + return 0; } phwi_ctrlr = phba->phwi_ctrlr;