| Message ID | 1508182082-11828-1-git-send-email-chris.gekas@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Christos, > Check whether configured_logical_drive_count is less than > 255. Previous check was always evaluating to true as this variable is > defined as u8. Applied to 4.14/scsi-fixes. Thank you!
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 9abe810..4ed3d26 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -4091,7 +4091,7 @@ static int hpsa_set_local_logical_count(struct ctlr_info *h, memset(id_ctlr, 0, sizeof(*id_ctlr)); rc = hpsa_bmic_id_controller(h, id_ctlr, sizeof(*id_ctlr)); if (!rc) - if (id_ctlr->configured_logical_drive_count < 256) + if (id_ctlr->configured_logical_drive_count < 255) *nlocals = id_ctlr->configured_logical_drive_count; else *nlocals = le16_to_cpu(
Check whether configured_logical_drive_count is less than 255. Previous check was always evaluating to true as this variable is defined as u8. Signed-off-by: Christos Gkekas <chris.gekas@gmail.com> --- drivers/scsi/hpsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)