From patchwork Mon Oct 30 21:38:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Petros Koutoupis X-Patchwork-Id: 10033285 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 31D9B600C5 for ; Mon, 30 Oct 2017 21:38:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2429C28672 for ; Mon, 30 Oct 2017 21:38:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1873528981; Mon, 30 Oct 2017 21:38:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DBA9228672 for ; Mon, 30 Oct 2017 21:38:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752961AbdJ3ViT convert rfc822-to-8bit (ORCPT ); Mon, 30 Oct 2017 17:38:19 -0400 Received: from mout.perfora.net ([74.208.4.196]:58494 "EHLO mout.perfora.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751615AbdJ3ViS (ORCPT ); Mon, 30 Oct 2017 17:38:18 -0400 Received: from petros-ultrathin ([99.41.188.243]) by mrelay.perfora.net (mreueus001 [74.208.5.2]) with ESMTPSA (Nemesis) id 0LoH8R-1dXRqG07EP-00g8Xl; Mon, 30 Oct 2017 22:38:13 +0100 Message-ID: <1509399490.5866.3.camel@petroskoutoupis.com> Subject: [PATCH] scsi_error.c: DID_SOFT_ERROR comment clean up From: Petros Koutoupis To: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org Date: Mon, 30 Oct 2017 16:38:10 -0500 X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 X-Provags-ID: V03:K0:eb60VL8ucrpIE3clyjwigLr2MDga9jW0M2+lHVAZZta+XjcRsmW CniZgQcpdNqXuiyS3VA2Q8483PRCcGDY4+pgO4n4Govl09RNrEj9GVGXZgdph5XfSkoS9Un h6vGSSLIYvmWxriKJCipgznoLCaRj09eaq7qc/cC+Xn/gnQi22QrCbNn+cL1a/Yy9ZVd1i3 GNEhIXQAkyyM7/domdlEA== X-UI-Out-Filterresults: notjunk:1; V01:K0:sAI9ecOnrp0=:8DJGMmGdi2AAfk67SzRpqN DC3Fs983yPzSKOeheX3mrNvRru/QPo4AMdBAmWTPYBN5sYhE5zidler6TAgecL20iPTFgMHRQ LcToMyUNqA0IqUYRRA4IJXoODHEztO2wpwzUCceWygRXDRa5ufy0oMpcercfA0vFy75GUk2sW 6jP7xhycFGyjieogdqTfHoCaVOuhgzkTAqvCLkicPv7ScaelhH/fI5ok7CZuLlwajBGoyjUS5 xoA8ZxBtLRznyTZo3drdi8+oNS9+Ru6k4UGxve4nCCJOPyjjP1EXCoaz0bVo488ArkDxX3/kE 0CxMrJ++7UersLKjNSYw9AomaI6+W1QQQgIYa3ts6CoAsiJ406QI0i9FmEsEOM+ks59SRKxeN kkSypzx/9dfg5XvhWMPg9u8tOOw3PZqiNK18yNIupQlova2SuC0AAKBBh7HeEBk35GI47NDqT 9jqNbAo790e5qVTOVX4YmtTAPiznYeIxckI0F8W9+ex6Up7EJXoycEupJYdmzAxtU0Fzjc8sO BttMq7OIJ3AZ6DH38d7xhIO8dM+aSRdyEbwbckhn5qHP5THdgff4z0c4C4w0cYa29stTn/txs 8FfNvvUejn3RFRhCxbyBNuFEhNFJgmft5zQhl+5Y/nNfUoRU1+xex2cQsnkZhid5bMhN+kt1g ob3D6kvEynqqxpsq9BeIvf6bD6THqgJL94VEgys8bYFp+UhIZvYhcWHuuGhuJ0BKjok4o5esO pQpi4z55acf830pRrxEPslNud6+WF85SzWSxLS38wv+7mo+uVchmIP87VfY= Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Updated comment. We are keeping track of maximum number of retries per command via retries/allowed in struct scsi_cmnd. Corrected comment positioning. Signed-off-by: Petros Koutoupis diff -uNpr linux-4.14-rc7.orig/drivers/scsi/scsi_error.c linux-4.14-rc7/drivers/scsi/scsi_error.c --- linux-4.14-rc7.orig/drivers/scsi/scsi_error.c 2017-10-30 10:02:11.089576057 -0500 +++ linux-4.14-rc7/drivers/scsi/scsi_error.c 2017-10-30 10:08:24.352182353 -0500 @@ -1747,16 +1747,12 @@ int scsi_decide_disposition(struct scsi_    * that it indicates SUCCESS.    */   return SUCCESS; + case DID_SOFT_ERROR:   /*    * when the low level driver returns did_soft_error,    * it is responsible for keeping an internal retry counter    * in order to avoid endless loops (db) -  * -  * actually this is a bug in this function here.  we should -  * be mindful of the maximum number of retries specified -  * and not get stuck in a loop.    */ - case DID_SOFT_ERROR:   goto maybe_retry;   case DID_IMM_RETRY:   return NEEDS_RETRY;