diff mbox

[2/3] scsi: be2iscsi: Add warnings for unsupported adapters

Message ID 1528359883-13054-3-git-send-email-jitendra.bhivare@broadcom.com (mailing list archive)
State Rejected
Headers show

Commit Message

Jitendra Bhivare June 7, 2018, 8:24 a.m. UTC 
From: Ketan Mukadam <ketan.mukadam@broadcom.com>

Add a warning message to indicate obsolete/unsupported
BE3 Adapter Family devices.

Signed-off-by: Ketan Mukadam <ketan.mukadam@broadcom.com>
Reviewed-by: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
---
 drivers/scsi/be2iscsi/be_main.c | 2 ++
 drivers/scsi/be2iscsi/be_mgmt.c | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

Comments

Johannes Thumshirn June 7, 2018, 10:43 a.m. UTC | #1 
On Thu, Jun 07, 2018 at 01:54:42PM +0530, Jitendra Bhivare wrote:
> From: Ketan Mukadam <ketan.mukadam@broadcom.com>
> 
> Add a warning message to indicate obsolete/unsupported
> BE3 Adapter Family devices.

Ahm no. The upstream Linux kernel doesn't deprecate specific hardware.
diff mbox

Patch

diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index b3cfdd5..2b4f524 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -5583,6 +5583,8 @@  static int beiscsi_dev_probe(struct pci_dev *pcidev,
 	case OC_DEVICE_ID3:
 		phba->generation = BE_GEN3;
 		phba->iotask_fn = beiscsi_iotask;
+		dev_warn(&pcidev->dev,
+			 "Obsolete/Unsupported BE3 Adapter Family\n");
 		break;
 	case OC_SKH_ID1:
 		phba->generation = BE_GEN4;
diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c
index 66ca967..dff6cdf 100644
--- a/drivers/scsi/be2iscsi/be_mgmt.c
+++ b/drivers/scsi/be2iscsi/be_mgmt.c
@@ -1233,7 +1233,8 @@  beiscsi_adap_family_disp(struct device *dev, struct device_attribute *attr,
 		break;
 	case BE_DEVICE_ID2:
 	case OC_DEVICE_ID3:
-		return snprintf(buf, PAGE_SIZE, "BE3-R Adapter Family\n");
+		return snprintf(buf, PAGE_SIZE,
+				"Obsolete/Unsupported BE3-R Adapter Family\n");
 		break;
 	case OC_SKH_ID1:
 		return snprintf(buf, PAGE_SIZE, "Skyhawk-R Adapter Family\n");