| Message ID | 1528415.ru8bxkDU1V@wuerfel (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Friday 22 January 2016 15:28:32 Arnd Bergmann wrote: > struct register_host_info stores a 64-bit UTC system time timestamp. > This patch removes the use of 'struct timeval' to obtain that timestamp > as its tv_sec value will overflow on 32-bit systems in year 2038 beyond. > The patch uses ktime_get_real_seconds() which returns a 64-bit seconds value. > > Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com> > Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > I was missing From: Tina Ruchandani <ruchandani.tina@gmail.com> If anyone is going to pick this up, let me know whether you will fix it up yourself or if I should resend. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Arnd, On 1/22/16, 7:12 AM, "linux-scsi-owner@vger.kernel.org on behalf of Arnd Bergmann" <linux-scsi-owner@vger.kernel.org on behalf of arnd@arndb.de> wrote: >On Friday 22 January 2016 15:28:32 Arnd Bergmann wrote: >> struct register_host_info stores a 64-bit UTC system time timestamp. >> This patch removes the use of 'struct timeval' to obtain that timestamp >> as its tv_sec value will overflow on 32-bit systems in year 2038 beyond. >> The patch uses ktime_get_real_seconds() which returns a 64-bit seconds >>value. >> >> Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com> >> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> > > > >I was missing > >From: Tina Ruchandani <ruchandani.tina@gmail.com> > >If anyone is going to pick this up, let me know whether you will fix >it up yourself or if I should resend. Please resend the patch and add Acked-by: Himanshu Madhani <himanshu.madhani@qlogic.com> >-- >To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html Thanks, - Himanshu
diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index b5029e543b91..15dff7099955 100644 --- a/drivers/scsi/qla2xxx/qla_mr.c +++ b/drivers/scsi/qla2xxx/qla_mr.c @@ -6,6 +6,7 @@ */ #include "qla_def.h" #include <linux/delay.h> +#include <linux/ktime.h> #include <linux/pci.h> #include <linux/ratelimit.h> #include <linux/vmalloc.h> @@ -1812,7 +1813,6 @@ qlafx00_fx_disc(scsi_qla_host_t *vha, fc_port_t *fcport, uint16_t fx_type) struct host_system_info *phost_info; struct register_host_info *preg_hsi; struct new_utsname *p_sysid = NULL; - struct timeval tv; sp = qla2x00_get_sp(vha, fcport, GFP_KERNEL); if (!sp) @@ -1886,8 +1886,7 @@ qlafx00_fx_disc(scsi_qla_host_t *vha, fc_port_t *fcport, uint16_t fx_type) p_sysid->domainname, DOMNAME_LENGTH); strncpy(phost_info->hostdriver, QLA2XXX_VERSION, VERSION_LENGTH); - do_gettimeofday(&tv); - preg_hsi->utc = (uint64_t)tv.tv_sec; + preg_hsi->utc = (uint64_t)ktime_get_real_seconds(); ql_dbg(ql_dbg_init, vha, 0x0149, "ISP%04X: Host registration with firmware\n", ha->pdev->device);