From patchwork Tue Jul 3 22:34:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Don Brace X-Patchwork-Id: 10505481 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 98AF3601D3 for ; Tue, 3 Jul 2018 22:35:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 868E6289EA for ; Tue, 3 Jul 2018 22:35:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7819D28A52; Tue, 3 Jul 2018 22:35:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E5A80289EA for ; Tue, 3 Jul 2018 22:35:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753288AbeGCWfA (ORCPT ); Tue, 3 Jul 2018 18:35:00 -0400 Received: from mail-dm3nam03on0066.outbound.protection.outlook.com ([104.47.41.66]:5920 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753105AbeGCWe6 (ORCPT ); Tue, 3 Jul 2018 18:34:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mscc365.onmicrosoft.com; s=selector1-microsemi-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=54wVHDEPAbqliHX/u+K2ztcPQ2w88HdREM2asg0KioM=; b=jVpqZU6K5q7OA5vAmmEiB41WPld/ud6jmvzpKWJcieg9+ELbiUYtCUHcbd/anK4HwcdMvpswFUngvLJ8jMvXTA0qwGW877dEs34o1rXbgjqobDqh6itzAJHVvH3Tdn5d3gGJF6KbqhCm9qQybR6KfSE6Yj4O8M5Vl6Rsfa8I7DM= Received: from CY4PR02CA0018.namprd02.prod.outlook.com (2603:10b6:903:18::28) by BN6PR02MB3345.namprd02.prod.outlook.com (2603:10b6:405:63::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.24; Tue, 3 Jul 2018 22:34:56 +0000 Received: from BN1BFFO11FD008.protection.gbl (2a01:111:f400:7c10::1:130) by CY4PR02CA0018.outlook.office365.com (2603:10b6:903:18::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.906.23 via Frontend Transport; Tue, 3 Jul 2018 22:34:56 +0000 Authentication-Results: spf=pass (sender IP is 208.19.100.21) smtp.mailfrom=microsemi.com; hpe.com; dkim=none (message not signed) header.d=none;hpe.com; dmarc=bestguesspass action=none header.from=microsemi.com; Received-SPF: Pass (protection.outlook.com: domain of microsemi.com designates 208.19.100.21 as permitted sender) receiver=protection.outlook.com; client-ip=208.19.100.21; helo=AVMBX1.microsemi.net; Received: from AVMBX1.microsemi.net (208.19.100.21) by BN1BFFO11FD008.mail.protection.outlook.com (10.58.144.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.820.5 via Frontend Transport; Tue, 3 Jul 2018 22:34:53 +0000 Received: from AVMBX2.microsemi.net (10.100.34.32) by AVMBX1.microsemi.net (10.100.34.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Tue, 3 Jul 2018 15:34:48 -0700 Received: from [127.0.1.1] (10.238.32.34) by avmbx2.microsemi.net (10.100.34.32) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Tue, 3 Jul 2018 15:34:48 -0700 Subject: [PATCH] hpsa: correct enclosure sas address From: Don Brace To: , , , , , , , , , , CC: Date: Tue, 3 Jul 2018 17:34:48 -0500 Message-ID: <153065728799.24203.12531104833000590044.stgit@brunhilda> User-Agent: StGit/0.18-56-g3329 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:208.19.100.21; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(7916004)(39860400002)(396003)(376002)(136003)(346002)(2980300002)(438002)(199004)(189003)(2201001)(68736007)(86362001)(126002)(44832011)(106002)(476003)(486006)(16576012)(296002)(316002)(2906002)(77096007)(110136005)(58126008)(97736004)(5660300001)(1857600001)(26005)(336012)(2486003)(106466001)(33896004)(186003)(47776003)(103116003)(53936002)(8676002)(8936002)(305945005)(33716001)(23676004)(4326008)(81156014)(9686003)(230700001)(356003)(81166006)(69596002)(50466002)(478600001)(921003)(1121003)(83996005)(2101003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR02MB3345; H:AVMBX1.microsemi.net; FPR:; SPF:Pass; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD008; 1:Oj12/XDTtV1g5VxW4dtqzrHTH22ui9GsVomXbhnnCB83x+FheKb9YAGlreHMpV+fTH++/0A2Zj1jZjNEsL3kaADM/2zWMMJIAtmWfHiM3u3ZrrLR8MYmgvCfXdWO1wo6 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 22f32e93-3fa8-4df9-b480-08d5e13533c8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4608076)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060); SRVR:BN6PR02MB3345; X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB3345; 3:dFzMo3DPCsAprEWGi5xquL0e4UuXhv6htzrYK5DLV63yKiQW/usl+/MavDzBZ+EvweIywTxnZt3iZGGL04y+Nv9KvVvdjhauVEApX7pqTs3nRKxEwjAdMg4RtrYM0vLROIKUUwNAT2ar21Uma3MqJh5BQqXn8GYHhQOPkZaIasvz7FpyBh+/ue+ElOL4VUMiPL615r9I8rVA+jcIl5AA51fy+Va+DjypJtBbZbt0PgcCY88baLESMViKurUAjQnPxVjPb9vzhM4Q1eQLkT3pMSW23vhojjMuVdb1hBqtKUnH5MeRHPBONQn0UImK2e/T7ecGLfHSMyxDMWnhiW2Qs3MOr2frXvXqGcZxYmnzJts=; 25:dW8RmYtZ0OLFvVMZn5Vh0s9nr1xJ2tfmBphylBNMpOOfQZk6VeiCnTCCXx0CrF6h2cyBjTvxK6iFof9GwODJ8P2EeuMWjMx/1lRyDwpzi4GW/LppHWdc6RoVYHc4UVCrq+70KoL1WkV/U2OfYG2mRaIgUj3atm00mdGznrApUb/WYSsfYT6VlaRIvmDcSmcjCwmeHgFa5hlZMaivwAWRyZ16OzdfcBEIXkvIb6MhRaYnejD+0R5FG97tmpuO3C90z9By0LBCAzJe4vtx+z6X7Dm06z4ENY/ZSaHgBGaIvjCenwSfCbxDmYFyi2FyV94U5tfoOUKQUr+3m7i2rkWgOg== X-MS-TrafficTypeDiagnostic: BN6PR02MB3345: X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB3345; 31:CMBp272KIQd5+gVelu1JK5A+VNNzndJrSlypaA+dYlYKoMzIdboLK+Qd7+PH3drz4TbzuCSO0EobxCONvZ/QVar+0tgPysKOj9lmGv9ky6EpLimsWkKsQp35hya9hhXH8DcRI0kbd65/dRL9HWx9Cy/ZehP8aEfEf9IQvGOzPWAQfjOWtVq3mTV0ybydFL9Qv2bqRX//lCgQtZ2ItfsgZuY1u6bWPdfxEMkcQsNyGbI=; 20:AwC2p21zU7l8bIh4Htr6kDgPcYLY/cDbJb4Dq9N+8/CI4UlmweTMm5xtRBt9bbkBbrH0DG8ERiml7vKHrhmxv/4eDFKT1admTFxp0y+ABwqHgNT4tpSz0jhhxLpvbEuxeTnm30EmZrJbtKVIRmjftPENwEB/fCmmarne42L7ih74cSlMsZMHNzKNjYmKxcUuCWc8s49n8DD+EDAAnP656Xfq4mR4T3YTIX/nTEredUoA4muouEkpbtEVbXkQdIGUe8FJ5hxF17zSkx0sW/1f0BtwW+pP5WZwCBUlSUS7Uzhm0KeZ/vpD+x0F0n4mmwavMRK183pJ5vTluM7plvVxBJaZsUaviNNwQVZY/F1xe/lPrzndn7SiEqmxGt1JmZAA7Y8wJ8slBdmyS/e0hfkB4orQSywuTFDKSKciJj+pPsF2MqpGReQsHuw750iMYLZ+4irV14OKvajc+7/9Nn9DZjxAmpm7GOKkRYMG+Rhy1P5sBg00MlCdwz223SygW9IAa9wvUPhO4FYPZG7N9UvB3qNCKgZix1p682KLinsfOo46wdU25A1PejbaXaUfuGmEOXWDhdag2SO3Rv/cP1OJwrSErlKTLqhl/O8iGhDClFE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(72170198267865); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231254)(944501410)(52105095)(3002001)(93006095)(93004095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123562045)(201703131423095)(201703031522075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:BN6PR02MB3345; BCL:0; PCL:0; RULEID:; SRVR:BN6PR02MB3345; X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB3345; 4:1fJ80yVSxcoFfYjTWjEU7aNLtvGXkwb7cKcVfW0LAZ/MJQBv/jBkNAqDA+PgiCcM2czUb3sz5MW/oX0hPgA8qLB0WJcRt9+YeX9bIg5whO374f0ss5Fz2fwmDYZC1r0wLzfFglZew6QmvTcIP2DD/CsWxnWxO47JQusbZjyqw1EwC9VI2XhFRlh3hHQvimAWucY97+dLqfWPZd87vU60GFdPoz1aSgQwC+M3bexmuFUsxTcIDJN2k3+vy3APaUFTFbhkEjyrgbdu+IkcHKdnu8RVm4jXNTxZr5Ll52N3cq2Bsr4RusZ25jTpTebC9nqt X-Forefront-PRVS: 0722981D2A X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAyTUIzMzQ1OzIzOkpUczJJNFJ4TTNQVVEzR2FmQXB3ZWhCVmZZ?= =?utf-8?B?UExORjZMTGowNmJXYm0zV1NicVNYblVJUlNtdENud05RMm5tencvUE1RTURO?= =?utf-8?B?RFhFWTFrSTJRTFlEYmRDZkdxZWhISUZ6TldGdkRGdGswVnBpbGRZWFZZeTZH?= =?utf-8?B?UlE0SlRLRGZzWWp3NFJTcStyRTlrZGFzcSt1K25LbFExdS9qNkJCcHJnMTZ0?= =?utf-8?B?eDViVng1c0VBVStUaGt3YUQ5Zk1ROU0wNW5nUGZQUEM1SkZneW1CRlBNM01q?= =?utf-8?B?NWNnZnFZM2ZOa1FOQzN6dkp3YWRlRHVlQloxS1ltVE16dTl0L2twaDc2RnBz?= =?utf-8?B?d24zU01YbUFmcUNncWFBRGxFaUtnZGNJWU5INFFEckRNc25KamRtRldERzJo?= =?utf-8?B?Z0l2Q0lrQm1teDZyMnNFcEFwVFNyWXM4ZWJ0cVdNam1BSUN0eUthN2dyTTFI?= =?utf-8?B?cFVGYzBPbllXN3BTL1dvTk1XYlYwZUc5ZmdkekUyeUFOMUxsME9EWUFhZFBy?= =?utf-8?B?TitIek1CbjdVZWNZU3JoSitqdzNuQjBoYTFhemtsb2pWZ0tqYmZrR2c4V25L?= =?utf-8?B?eTVpcTZVOTRCTFMvRnhHQ1hIYVpuQlVTWnBEVXUrYjRMOUFCUTRSSVA3NVlo?= =?utf-8?B?L2hGYnlMOGRFUFcvNk5qdU9DamJiWFM1ZXVFYUdXSjU3VThub2pqQXVPY2lR?= =?utf-8?B?Q2haamd2UE5abGVZNjZ2eVJ4ZmFpN3IrMWZCT3VMckRtOFZKczhLYWs5OXA1?= =?utf-8?B?cUREWDVTUXRPakRWaitaOE83RVhnb0NXb3dsV2pjelFndmpYczlUdnNtQVdI?= =?utf-8?B?KzZyVHRzZkFLTUNWYW5sTVAyMnJzTXFuUGcyaTAwbGo4UzNkMTM4ZmI5S2oz?= =?utf-8?B?dzdWK0FHSy9tWktLc0x0MzVwSS96V3pyTXpnY0RVMitTamZSeXRHMC9YS0NE?= =?utf-8?B?cTV2SE5ZV3AzblozaXpNSnVjWjh1Ujl4NXZlZ2VyRjBVa2o4Qi90U1dKTy9w?= =?utf-8?B?K2I2aG9vQ0xkV1pRY2dlb3lyZVI3TWVFY0cwTUFpZHdsNExNVFdEUjA0ZTVp?= =?utf-8?B?SlczU2NQNm50RGxDOHFRM203QXZCNlFESldGTlIzRURWK3l2ZThGcVluUFVw?= =?utf-8?B?SGM2SVR2RDRCM1ZyZkN3WVJKY0h5TUxoYmJoalMrUDlZekNaWWVXcHpNMjdu?= =?utf-8?B?dVEydzlhV0Y4ZlpWam9ncXZEcjg3bEFhTVlvbHByMmQvMjkzM2tiU0NScVlk?= =?utf-8?B?SzIrTDRQQkR4eGd2VVpUNm50N3pxUWxKMWtFSGFDdHcwVDkxRFJSUjR6Q0FZ?= =?utf-8?B?YVBqNlo5UFFFQSt4TGlUaFplTlh0TTNMdS80WFZyMHFQVm5nanFiWkdZV0Jm?= =?utf-8?B?K2Jub2I0cFk4YVZNZ0pVNGRJQnBkZ1pPSUQ0SEhha2lUNGpMWE5UOW1WMzlP?= =?utf-8?B?WG9DSXpJTmE2T1lhSFpEdkJlempYY0srVldMS0wrdHNCNU9TenJxUk9KajMr?= =?utf-8?B?N3BXbWNxcU5HcGlqc1E5MzB0a00vUEJBNE14djN4M0hIeTFCOVQ0VmhWOFd5?= =?utf-8?B?d0swTlFPYlFrVVc1bXY2K2VBK21MVjJBMUpOMVdIaCtha09rVy90SUNldWt2?= =?utf-8?Q?73LyXCslrA0F6/DN05l/?= X-Microsoft-Antispam-Message-Info: wUhE6lPJpd7BBq93tyh5egsUQuuOORm/W+kB4ARx6RHOikOHCKUiCUx/Ya90NgzQc1olErjHPcO8avI1N+8OvAyenF+ERJYuuL/ZVh29YnZpLTXYxC54u8Gu1toxnKsDO8Rmeoe4fca1tXnyEu/U6TVyGqRSjaNTnm3bXBnb3BX8eRQOyEFrZrJ8HXs8bfm3MlVBcU3fjcd3ATJzNv84PYv9CKmNsbPF2po1VT4zltBBjxdwRT8l2zo3Yp8WCcI+eDn0DbObm3sFjf361G20ah1CrLksylNQvfvh05A8InZM2iDZfKs+1BduGiSQcSc307sXhOiJnr4wF0V5aTW9NdTn2csBFijgePXbPE5VZ/c= X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB3345; 6:arm4QAyK2PHVd443Nmv86olGkM9sDh3vD79S3PH5KAJ0QDey0mfX5z8XbuPDbaFfQaDajSYr4aKc5CQh2ZzQqtWd9JX/zDAowXY45L6tm1CgEhLzUlgYVo3RDl/lq9WCtDJ4MfHMU4F0C+zh378UA3pL7mdnZxkHXWYg77yWeL9MwdtoG+RJnjK1IAssa2Kbnqt/lvaVd2T8IJinSfTF1wS+NsQ2YNF7jsAx7/z7dhAqDoPmnxkmJNDQRnPvcpax+XQtjV0dv/skWa3k0+rL2W3mSucMw6iH3lUs8xLZVa/Y6EVZNMeZzGsty8lIspR5+m0zUUIu4qaqGIqbSxSGujSW5/w3SNcbrOt892h7oL46P6cI7QM8rcKvLJYETuIklpGtFpUDlkLGDzqk5Z6SNY/QLb7f38iJzOTZkLAcE9DUNNlg067nPMCvHaGzKBAygOGoMrGC0OAcXFOntKfYKA==; 5:R+tCZxdeffe6fSBXJSOH9vMRNR/9pn8BbaS2YGTWNfnRyxacUtORrijBbcrjeHovlBAzzZxLKE3DwSDyk38U4qL+1Gn7cHoTUe7KDlOdIuoKuvt1LX17FlNU2cIDB1JDzyjR/wBnRKBKUwPYG+2lkNJdPp03C0gYSV+ypMZVTGA=; 24:JU78MGu8gYKZBurhlYLkWy+HE3l4ZPuAQ4X7cmlciMRlPhjz+kNoqwybAdT35lJSBoLDcUEjy74eFM5YeyGpoa/BsJowcLwD0r+4aiaqQ8s= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB3345; 7:rdvJqd11Fe4EkcrVEC9JRDkC3pAlgAJx2+gLNa2tnd0knGXl6PkWcsDX7icLYRjEvZwasTPpDhJRrPcV1CvClOM833Ek2Nqwy+W/peaMpY38ACyMnuKqGWOpDKnhHeJELlCziCjhBzZACUs4ZpIMthyOEeUQ9xRFwSwcZqwfUWnqlZ+AZyz6Ivl9yj8Qkejnr2oskXhoSpWQEyaxw+ArRsPV5MP7kvxY1ZfJVFjnG3IE3/M4/3ACPHVQNWV6a6Cc X-OriginatorOrg: microsemi.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2018 22:34:53.8948 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 22f32e93-3fa8-4df9-b480-08d5e13533c8 X-MS-Exchange-CrossTenant-Id: f267a5c8-86d8-4cc9-af71-1fd2c67c8fad X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f267a5c8-86d8-4cc9-af71-1fd2c67c8fad; Ip=[208.19.100.21]; Helo=[AVMBX1.microsemi.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB3345 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP - separate enclosure logical identifier from the SAS address. The original complaint was the lsscsi -t showed the same SAS address of the two enclosures (SEP devices). In fact the SAS address was being set to the Enclosure Logical Identifier (ELI). Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 25 +++++++++++++++++++++---- drivers/scsi/hpsa.h | 1 + 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 15c7f3b6f35e..58bb70b886d7 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -3440,11 +3440,11 @@ static void hpsa_get_enclosure_info(struct ctlr_info *h, struct ext_report_lun_entry *rle = &rlep->LUN[rle_index]; u16 bmic_device_index = 0; - bmic_device_index = GET_BMIC_DRIVE_NUMBER(&rle->lunid[0]); - - encl_dev->sas_address = + encl_dev->eli = hpsa_get_enclosure_logical_identifier(h, scsi3addr); + bmic_device_index = GET_BMIC_DRIVE_NUMBER(&rle->lunid[0]); + if (encl_dev->target == -1 || encl_dev->lun == -1) { rc = IO_OK; goto out; @@ -9697,7 +9697,24 @@ hpsa_sas_get_linkerrors(struct sas_phy *phy) static int hpsa_sas_get_enclosure_identifier(struct sas_rphy *rphy, u64 *identifier) { - *identifier = rphy->identify.sas_address; + struct Scsi_Host *shost = phy_to_shost(rphy); + struct ctlr_info *h; + struct hpsa_scsi_dev_t *sd; + + if (!shost) + return -ENXIO; + + h = shost_to_hba(shost); + + if (!h) + return -ENXIO; + + sd = hpsa_find_device_by_sas_rphy(h, rphy); + if (!sd) + return -ENXIO; + + *identifier = sd->eli; + return 0; } diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h index fb9f5e7f8209..59e023696fff 100644 --- a/drivers/scsi/hpsa.h +++ b/drivers/scsi/hpsa.h @@ -68,6 +68,7 @@ struct hpsa_scsi_dev_t { #define RAID_CTLR_LUNID "\0\0\0\0\0\0\0\0" unsigned char device_id[16]; /* from inquiry pg. 0x83 */ u64 sas_address; + u64 eli; /* from report diags. */ unsigned char vendor[8]; /* bytes 8-15 of inquiry data */ unsigned char model[16]; /* bytes 16-31 of inquiry data */ unsigned char rev; /* byte 2 of inquiry data */