| Message ID | 1533129976-51930-2-git-send-email-zhongjiang@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | use dma_zalloc_coherent and vzalloc to replace open code | expand |
On Wed, Aug 1, 2018 at 4:26 PM, zhong jiang <zhongjiang@huawei.com> wrote: > The vzalloc is better than vmalloc+memset, so replace them to make > the code concise. > - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE)); > + fnic_trace_buf_p = (unsigned long)vzalloc((trace_max_pages * PAGE_SIZE)); At the same time you may get rid of unnecessary parens.
On Wed, 2018-08-01 at 18:30 +0300, Andy Shevchenko wrote: > On Wed, Aug 1, 2018 at 4:26 PM, zhong jiang <zhongjiang@huawei.com> wrote: > > The vzalloc is better than vmalloc+memset, so replace them to make > > the code concise. > > - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE)); > > + fnic_trace_buf_p = (unsigned long)vzalloc((trace_max_pages * PAGE_SIZE)); > > At the same time you may get rid of unnecessary parens. And at the same time, perhaps use kvcalloc and kvfree instead of always using vmalloc as the allocation size can be less than the allowable for a single kmalloc.
On 2018/8/1 23:30, Andy Shevchenko wrote: > On Wed, Aug 1, 2018 at 4:26 PM, zhong jiang <zhongjiang@huawei.com> wrote: >> The vzalloc is better than vmalloc+memset, so replace them to make >> the code concise. >> - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE)); >> + fnic_trace_buf_p = (unsigned long)vzalloc((trace_max_pages * PAGE_SIZE)); > At the same time you may get rid of unnecessary parens. > Thanks , I will repost with the change. Thanks zhong jiang
diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c index 8271785..1c42556 100644 --- a/drivers/scsi/fnic/fnic_trace.c +++ b/drivers/scsi/fnic/fnic_trace.c @@ -468,14 +468,13 @@ int fnic_trace_buf_init(void) fnic_max_trace_entries = (trace_max_pages * PAGE_SIZE)/ FNIC_ENTRY_SIZE_BYTES; - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE)); + fnic_trace_buf_p = (unsigned long)vzalloc((trace_max_pages * PAGE_SIZE)); if (!fnic_trace_buf_p) { printk(KERN_ERR PFX "Failed to allocate memory " "for fnic_trace_buf_p\n"); err = -ENOMEM; goto err_fnic_trace_buf_init; } - memset((void *)fnic_trace_buf_p, 0, (trace_max_pages * PAGE_SIZE)); fnic_trace_entries.page_offset = vmalloc(array_size(fnic_max_trace_entries,
The vzalloc is better than vmalloc+memset, so replace them to make the code concise. Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- drivers/scsi/fnic/fnic_trace.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)